October 2012 - freeswitch-dev@lists.freeswitch.org

[Freeswitch-dev] Unreachable code in mod_spidermonkey.c (event_chat_execute)
by Niels Thomsen 01 Oct '12

01 Oct '12

There's a bit of unreachable code in mod_spidermonkey which means that the event_chat_execute function becomes a no-op. This may be intentional, of course, but it doesn't look like it is... static JSBool event_chat_execute(JSContext * cx, JSObject * obj, uintN argc, jsval * argv, jsval * rval) { struct event_obj *eo = JS_GetPrivate(cx, obj); if (eo) { if (argc > 0) { char *app = JS_GetStringBytes(JS_ValueToString(cx, argv[0])); char *arg = NULL; if (argc > 1) { arg = JS_GetStringBytes(JS_ValueToString(cx, argv[1])); } goto end; //-- this code is never executed switch_core_execute_chat_app(eo->event, app, arg); *rval = BOOLEAN_TO_JSVAL(JS_TRUE); return JS_TRUE; } } end: *rval = BOOLEAN_TO_JSVAL(JS_FALSE); return JS_FALSE; } - Niels

3 2

[Freeswitch-dev] Possible bug in video code
by Rick van Rein 01 Oct '12

01 Oct '12

Hello, I found this surprising fragment in the sofia_glue.c routine tech_pvt->adv_sdp_video_port = sdp_port; switch_channel_set_variable(tech_pvt->channel, SWITCH_LOCAL_VIDEO_IP_VARIABLE, tech_pvt->adv_sdp_audio_ip); switch_channel_set_variable_printf(tech_pvt->channel, SWITCH_LOCAL_VIDEO_PORT_VARIABLE, "%d", sdp_port); I'm almost certain that "adv_sdp_audio_ip" should be "adv_sdp_video_ip", except that it isn't there in mod_sofia.h; is this code assuming that Audio and Video come from the same source? I don't think this assumption will remain valid with the advent of IPv6 and potential LAN-mounted camera's. I am actually coding open source phone firmware that explicitly will pull in networked media devices by passing on their direct IPv6 addresses. This could be as simple as a webcam on a host. If you don't mind I'll leave it to the regular developers to judge and fix this in the git repository. I would like to learn the outcome. Cheers, -Rick

2 1

[Freeswitch-dev] Handling multipart/mixed SDP in INVITE
by Debasish Chandra 01 Oct '12

01 Oct '12

Hi, I am getting following error (415 Unsupported Media Type) while my FS receiving INVITE with multipart bodies. However it seems sofia is responding with 415. Does sofia handle multipart bodies? I am using latest freeswitch build. I am attaching the log below. ------------------------------------------------------------------------------------------------------------------------------------------------------------------- tport_wakeup_pri(0x7ff2c80041f0): events IN tport_recv_event(0x7ff2c80041f0) tport_recv_iovec(0x7ff2c80041f0) msg 0x7ff2c8005f30 from (udp/ 192.168.1.10:5060) has 1015 bytes, veclen = 1 tport_deliver(0x7ff2c80041f0): msg 0x7ff2c8005f30 (1015 bytes) from udp/ 192.168.1.10:5060/sip next=(nil) nta: received INVITE sip:222222@192.168.1.10:5060 SIP/2.0 (CSeq 1) nta: canonizing sip:222222@192.168.1.10:5060 with contact nta: INVITE (1) going to a default leg nta: timer set to 200 ms nua: nua_stack_process_request: entering nua: nua_invite_server_respond: entering tport_tsend(0x7ff2c80041f0) tpn = UDP/192.168.1.10:32896 tport_resolve addrinfo = 192.168.1.10:32896 tport_by_addrinfo(0x7ff2c80041f0): not found by name UDP/192.168.1.10:32896 tport_vsend(0x7ff2c80041f0): 711 bytes of 711 to udp/192.168.1.10:32896 tport_vsend returned 711 nta: sent 415 Unsupported Media Type for INVITE (1) tport_wakeup_pri(0x7ff2c80041f0): events IN tport_recv_event(0x7ff2c80041f0) tport_recv_iovec(0x7ff2c80041f0) msg 0x7ff2c8009800 from (udp/ 192.168.1.10:5060) has 386 bytes, veclen = 1 tport_deliver(0x7ff2c80041f0): msg 0x7ff2c8009800 (386 bytes) from udp/ 192.168.1.10:5060/sip next=(nil) nta: received ACK sip:222222@192.168.1.10:5060 SIP/2.0 (CSeq 1) nta: ACK (1) is going to INVITE (1) nta: timer set next to 4801 ms nta: timer I fired, terminate 415 response incoming_reclaim_all((nil), (nil), 0x7ff2f2712b50) nta_incoming_timer: 0/0 resent, 0/0 tout, 1/1 term, 1/1 free nta: timer not set -------------------------------------------------------------------------------------------------------------------------------------------------------------------- Please let me know whether it is possible to use multipart with FS. Best Regards, Debasish

1 0