New subject: Unreachable code in mod_spidermonkey.c (event_chat_execute)

1 Oct 2012

      There's a bit of unreachable code in mod_spidermonkey which means that
the event_chat_execute function becomes a no-op.

This may be intentional, of course, but it doesn't look like it is...

static JSBool event_chat_execute(JSContext * cx, JSObject * obj, uintN
argc, jsval * argv, jsval * rval)

{

                struct event_obj *eo = JS_GetPrivate(cx, obj);

                if (eo) {

                                if (argc > 0) {

                                                char *app =
JS_GetStringBytes(JS_ValueToString(cx, argv[0]));

                                                char *arg = NULL;

                                                if (argc > 1) {

                                                                arg =
JS_GetStringBytes(JS_ValueToString(cx, argv[1]));

                                                }

                                                goto end;

//-- this code is never executed                                

switch_core_execute_chat_app(eo->event, app, arg);

                                                *rval =
BOOLEAN_TO_JSVAL(JS_TRUE);

                                                return JS_TRUE;

                                }

                }

end:

                *rval = BOOLEAN_TO_JSVAL(JS_FALSE);

                return JS_FALSE;

}

- Niels

Unreachable code in mod_spidermonkey.c (event_chat_execute)

Niels Thomsen

Ken Rice

Anthony Minessale

tags

participants (3)