Jira Please


On 10/1/12 11:07 AM, "Niels Thomsen" <niels.thomsen@fentechnology.co.uk> wrote:

There’s a bit of unreachable code in mod_spidermonkey which means that the event_chat_execute function becomes a no-op.
 
This may be intentional, of course, but it doesn’t look like it is…
 
static JSBool event_chat_execute(JSContext * cx, JSObject * obj, uintN argc, jsval * argv, jsval * rval)
{
                struct event_obj *eo = JS_GetPrivate(cx, obj);
 
                if (eo) {
                                if (argc > 0) {
                                                char *app = JS_GetStringBytes(JS_ValueToString(cx, argv[0]));
                                                char *arg = NULL;
 
                                                if (argc > 1) {
                                                                arg = JS_GetStringBytes(JS_ValueToString(cx, argv[1]));
                                                }
 
                                                goto end;
 
//-- this code is never executed                                
                                                switch_core_execute_chat_app(eo->event, app, arg);
 
                                                *rval = BOOLEAN_TO_JSVAL(JS_TRUE);
                                                return JS_TRUE;
                                }
                }
 
 end:
 
                *rval = BOOLEAN_TO_JSVAL(JS_FALSE);
                return JS_FALSE;
}

- Niels


_________________________________________________________________________
Professional FreeSWITCH Consulting Services:
consulting@freeswitch.org
http://www.freeswitchsolutions.com

FreeSWITCH-powered IP PBX: The CudaTel Communication Server
http://www.cudatel.com

Official FreeSWITCH Sites
http://www.freeswitch.org
http://wiki.freeswitch.org
http://www.cluecon.com

FreeSWITCH-dev mailing list
FreeSWITCH-dev@lists.freeswitch.org
http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev
UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev
http://www.freeswitch.org

--
Ken
http://www.FreeSWITCH.org
http://www.ClueCon.com
http://www.OSTAG.org
irc.freenode.net #freeswitch