On Apr 10, 2009, at 1:35 AM, Traun Leyden wrote:
Hey you beat me to it. I was going to have a look this morning but had no internet because some asswipe cut a bunch of fiber optic cables and took out phone/internet for a big part of the bay area.
I haven't tried your patch yet, but I see something that looks suspect:
http://fisheye.freeswitch.org/browse/FreeSWITCH/src/switch_cpp.cpp?r=12958
In playAndGetDigits() there are now two calls to begin_allow_threads() (line 778 and 780) followed by only one call to end_allow_threads() (line 793)
Extra line removed, I did notice when looking in that file other methods that probably need begin/end, for example the blocking pop in event consumer. Would you mind going through the rest and seeing if their are other obvious misses? Mike
Also I guess it would have better to test against JS, since it should have had the same bug right? Lua just ignores the threadswapping stuff but IIRC javascript uses it in much the same way as python. Or did I miss something?