Re: [Freeswitch-users] Two or more simultaneous calls not
Hey you beat me to it. I was going to have a look this morning but had no internet because some asswipe cut a bunch of fiber optic cables and took out phone/internet for a big part of the bay area. I haven't tried your patch yet, but I see something that looks suspect: http://fisheye.freeswitch.org/browse/FreeSWITCH/src/switch_cpp.cpp?r=12958 In playAndGetDigits() there are now two calls to begin_allow_threads() (line 778 and 780) followed by only one call to end_allow_threads() (line 793) Also I guess it would have better to test against JS, since it should have had the same bug right? Lua just ignores the threadswapping stuff but IIRC javascript uses it in much the same way as python. Or did I miss something?
Message: 5 Date: Thu, 9 Apr 2009 08:15:38 -0500 From: Anthony Minessale <anthony.minessale@gmail.com> Subject: Re: [Freeswitch-users] Two or more simultaneous calls not To: freeswitch-users@lists.freeswitch.org Message-ID: <191c3a030904090615j2b736b7bp890c903c00a014f6@mail.gmail.com> Content-Type: text/plain; charset="iso-8859-1"
easier than you think,
Just like Traun had suspected, the methods in the C++ wrapper for the read app was missing the begin and end allow threads calls that are only important to python to tell it to suspend the thread state while FS specific code is being executed.
2 line fix in trunk rev 12958
On Apr 10, 2009, at 1:35 AM, Traun Leyden wrote:
Hey you beat me to it. I was going to have a look this morning but had no internet because some asswipe cut a bunch of fiber optic cables and took out phone/internet for a big part of the bay area.
I haven't tried your patch yet, but I see something that looks suspect:
http://fisheye.freeswitch.org/browse/FreeSWITCH/src/switch_cpp.cpp?r=12958
In playAndGetDigits() there are now two calls to begin_allow_threads() (line 778 and 780) followed by only one call to end_allow_threads() (line 793)
Also I guess it would have better to test against JS, since it should have had the same bug right? Lua just ignores the threadswapping stuff but IIRC javascript uses it in much the same way as python. Or did I miss something?
It's similar, but we don't use swig for javascript and we don't use switch_cpp so it would not have reproduced the issue. MIke
On Apr 10, 2009, at 1:35 AM, Traun Leyden wrote:
Hey you beat me to it. I was going to have a look this morning but had no internet because some asswipe cut a bunch of fiber optic cables and took out phone/internet for a big part of the bay area.
I haven't tried your patch yet, but I see something that looks suspect:
http://fisheye.freeswitch.org/browse/FreeSWITCH/src/switch_cpp.cpp?r=12958
In playAndGetDigits() there are now two calls to begin_allow_threads() (line 778 and 780) followed by only one call to end_allow_threads() (line 793)
Extra line removed, I did notice when looking in that file other methods that probably need begin/end, for example the blocking pop in event consumer. Would you mind going through the rest and seeing if their are other obvious misses? Mike
Also I guess it would have better to test against JS, since it should have had the same bug right? Lua just ignores the threadswapping stuff but IIRC javascript uses it in much the same way as python. Or did I miss something?
participants (2)
-
Michael Jerris
-
Traun Leyden