This questions for FS core developers. I found that FreeSwitch apr libs have apr_pool_mutex_set that not exists in APR master. I found commit <https://freeswitch.org/stash/projects/FS/repos/freeswitch/commits/ffb1cb4f690473af696fe1fe3879790fe49acecb> where this function is introduced. Purpose of this commit is resolve concurrency access from different threads to same memory pool. I asked <http://mail-archives.apache.org/mod_mbox/apr-dev/201701.mbox/%3CCAHtxdDfDwmoACnYn04FTWWgtpK8giJjsgSgg5VvuSN%2Bph4G%3DBw%40mail.gmail.com%3E> APR community why not used mutex and got responce from William A Rowe <http://mail-archives.apache.org/mod_mbox/apr-dev/201701.mbox/%3CCACsi2539CFJusRo0wmReEEdrdG5ppJsJb-C9aD-g7K6tFos%2BOA%40mail.gmail.com%3E> My questions Does core team developers planning rewrite memory pool operation to remove shared access to same pool from different threads? Create own pool for each thread. Sergey
We have no plans to make major changes in this space.
On Jan 17, 2017, at 8:10 AM, Sergey Safarov <s.safarov@gmail.com> wrote:
This questions for FS core developers. I found that FreeSwitch apr libs have apr_pool_mutex_set that not exists in APR master. I found commit <https://freeswitch.org/stash/projects/FS/repos/freeswitch/commits/ffb1cb4f690473af696fe1fe3879790fe49acecb> where this function is introduced. Purpose of this commit is resolve concurrency access from different threads to same memory pool.
I asked <http://mail-archives.apache.org/mod_mbox/apr-dev/201701.mbox/%3CCAHtxdDfDwmoACnYn04FTWWgtpK8giJjsgSgg5VvuSN%2Bph4G%3DBw%40mail.gmail.com%3E> APR community why not used mutex and got responce from William A Rowe <http://mail-archives.apache.org/mod_mbox/apr-dev/201701.mbox/%3CCACsi2539CFJusRo0wmReEEdrdG5ppJsJb-C9aD-g7K6tFos%2BOA%40mail.gmail.com%3E>
My questions Does core team developers planning rewrite memory pool operation to remove shared access to same pool from different threads? Create own pool for each thread.
Sergey _________________________________________________________________________ Professional FreeSWITCH Consulting Services: consulting@freeswitch.org http://www.freeswitchsolutions.com
Official FreeSWITCH Sites http://www.freeswitch.org http://confluence.freeswitch.org http://www.cluecon.com
FreeSWITCH-users mailing list FreeSWITCH-users@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-users UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users http://www.freeswitch.org
We still try to avoid using pools from different threads. When its done its only done on a second hand context, eg.. uuid_setvar Since Sessions have their own pool, and uuid_setvar is used from another thread, the only solution is to use mutexes. That is why the patch we added is designed to activate mutex mode only when needed which we do need in FreeSWITCH. You could go on to ask him in your thread if you wish why they have not commented on our patch that has been submitted for several years now to get the few patches we have into main APR so we don't have to use our own. We have tried to explain it to them a few times and usually the answer is: meh! and its dismissed. I would argue that FreeSWITCH gets its fair share of heavy use and has a reputation for scalability. This is all done with mutexed pools so its clearly not the end of the world to do it. The final result is we are forced to use our own copy to make sure we get the functionality we need. On Tue, Jan 17, 2017 at 10:12 AM, Michael Jerris <mike@jerris.com> wrote:
We have no plans to make major changes in this space.
On Jan 17, 2017, at 8:10 AM, Sergey Safarov <s.safarov@gmail.com> wrote:
This questions for FS core developers. I found that FreeSwitch apr libs have apr_pool_mutex_set that not exists in APR master. I found commit <https://freeswitch.org/stash/projects/FS/repos/freeswitch/commits/ffb1cb4f690473af696fe1fe3879790fe49acecb> where this function is introduced. Purpose of this commit is resolve concurrency access from different threads to same memory pool.
I asked <http://mail-archives.apache.org/mod_mbox/apr-dev/201701.mbox/%3CCAHtxdDfDwmoACnYn04FTWWgtpK8giJjsgSgg5VvuSN%2Bph4G%3DBw%40mail.gmail.com%3E> APR community why not used mutex and got responce from William A Rowe <http://mail-archives.apache.org/mod_mbox/apr-dev/201701.mbox/%3CCACsi2539CFJusRo0wmReEEdrdG5ppJsJb-C9aD-g7K6tFos%2BOA%40mail.gmail.com%3E>
My questions Does core team developers planning rewrite memory pool operation to remove shared access to same pool from different threads? Create own pool for each thread.
Sergey _________________________________________________________________________ Professional FreeSWITCH Consulting Services: consulting@freeswitch.org http://www.freeswitchsolutions.com
Official FreeSWITCH Sites http://www.freeswitch.org http://confluence.freeswitch.org http://www.cluecon.com
FreeSWITCH-users mailing list FreeSWITCH-users@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-users UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users http://www.freeswitch.org
_________________________________________________________________________ Professional FreeSWITCH Consulting Services: consulting@freeswitch.org http://www.freeswitchsolutions.com
Official FreeSWITCH Sites http://www.freeswitch.org http://confluence.freeswitch.org http://www.cluecon.com
FreeSWITCH-users mailing list FreeSWITCH-users@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-users UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users http://www.freeswitch.org
-- Anthony Minessale II ♬ @anthmfs ♬ @FreeSWITCH ♬ ☞ http://freeswitch.org/ ☞ http://cluecon.com/ ☞ http://twitter.com/FreeSWITCH ☞ irc.freenode.net #freeswitch ☞ *http://freeswitch.org/g+ <http://freeswitch.org/g+>* ClueCon Weekly Development Call ☎ sip:888@conference.freeswitch.org ☎ +19193869900 https://www.youtube.com/watch?v=9XXgW34t40s https://www.youtube.com/watch?v=NLaDpGQuZDA
participants (3)
-
Anthony Minessale
-
Michael Jerris
-
Sergey Safarov