mod_shout is on its way out so this is pretty much dead horse... No the functionality isnt going away there is just a better module coming to replace it... (see mod_vlc) The mod will remain for a bit, but going forward this code will end up going to the attic K On 2/29/12 9:44 AM, "Josh" <mojo1736@privatedemail.net> wrote:
Josh, Please test the patch at
http://jira.freeswitch.org/browse/FS-3711
testpatch.txt
which is provided by Alexey.
I don't want to act like a smug idiot, but I like my version of the patch better for (at least) 2 reasons:
1. The original patch modifications (hack_out_ogg.diff) made by my patch no longer use "relative" paths (i.e. "../../") and thus comply with any version of the patch used.
2. My modifications made to the appropriate mod_shout Makefile are much better, because they use SHOUT_BUILDDIR, which is already defined in that Makefile, and do not rely on some hard-coded path ("../../../../" for example). In other words, I think:
patch -d $(SHOUT_BUILDDIR) -p1 < hack_out_ogg.diff (which is what my patch proposes) is much better than: patch -p 6 -d ../../../../libs/libshout-2.2.2 < hack_out_ogg.diff (which is what Alexsey have proposed)
_________________________________________________________________________ Professional FreeSWITCH Consulting Services: consulting@freeswitch.org http://www.freeswitchsolutions.com
FreeSWITCH-powered IP PBX: The CudaTel Communication Server http://www.cudatel.com
Official FreeSWITCH Sites http://www.freeswitch.org http://wiki.freeswitch.org http://www.cluecon.com
FreeSWITCH-users mailing list FreeSWITCH-users@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-users UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users http://www.freeswitch.org