I made the modifications as you suggested, tested under latest git and committed. Yes, I add this field to every event since we already had conference_add_event_data in place. Thank you. Regards, João Mesquita On Mon, Dec 27, 2010 at 12:45 PM, Anthony Minessale < anthony.minessale@gmail.com> wrote:
you might want to consider putting the uuid_str in the conference struct and declare the uuid_t local and just render it once into the string field. Then you never have to call the uuid_format again and you probably don't need the binary version for anything.
Also do you add this field to every event in the general function that prepares all conference events for sending?
2010/12/26 João Mesquita <jmesquita@freeswitch.org>:
I decided, for now, to take the short way out. That is, use ESL to track the events on the conference.
One problem that emerged while doing so was how to find unique instances of a certain conference. To make it clearer, let me make an example.
Conference 123 is created on Sep 20, 2011 and has 20 members.
Same conference 123 is created on Sep 21, 2011 but now with 10 members.
Besides the obvious time difference, there was a problem identifying that the conferences are unique in memory in FreeSWITCH, more accurately, the same conference_obj. I came up with the idea then of adding one member to the struct. That member is a uuid for that conference and it is added to all events spit out by the module, so we know which conference is which uniquely.
Since this patch adds stuff to the struct, I didn't want to just commit without approval, so I would like to kindly ask one of the core devs to take a look at it and give me the green light to commit it, if that's the case. Sorry for posting it here, but Jira has been out for most of the weekend. I will get it in there if it gets back online and this email has not been responded yet.
The patch is attached.
Thank you, João Mesquita
2010/12/25 João Mesquita <jmesquita@freeswitch.org>
Hello you all. I hope you are all having a good holiday. I have been looking for the best way of tracking conference usage for reporting purposes (basically answering the question: what happened and
when
on conference nº X?) and I thought of the following alternatives that I would like to discuss with you. 1. Using ESL and the CUSTOM events to keep track of what happened when (I guess that's the most widely used) 2. Creating a new entry on switch_caller_profile, that would be filled by the mod_conference module anytime something changes on the conference. Something similar to what the origination_caller_profile does but that would be manipulated by the mod_conference. This option could neatly integrate with the xml cdrs but would mess a little more on the core. Not sure it is desirable. 3. Make mod_conference spit it's own XML for each conference created so that we know what happens and can link offline to other cdr entities. Or, maybe I am completely dumb and trying to do something that it is not supposed to be done or forgetting some resource that is already available.
João Mesquita
_______________________________________________ FreeSWITCH-dev mailing list FreeSWITCH-dev@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev http://www.freeswitch.org
-- Anthony Minessale II
FreeSWITCH http://www.freeswitch.org/ ClueCon http://www.cluecon.com/ Twitter: http://twitter.com/FreeSWITCH_wire
AIM: anthm MSN:anthony_minessale@hotmail.com <MSN%3Aanthony_minessale@hotmail.com> GTALK/JABBER/PAYPAL:anthony.minessale@gmail.com<PAYPAL%3Aanthony.minessale@gmail.com> IRC: irc.freenode.net #freeswitch
FreeSWITCH Developer Conference sip:888@conference.freeswitch.org <sip%3A888@conference.freeswitch.org> googletalk:conf+888@conference.freeswitch.org<googletalk%3Aconf%2B888@conference.freeswitch.org> pstn:+19193869900
_______________________________________________ FreeSWITCH-dev mailing list FreeSWITCH-dev@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev http://www.freeswitch.org