http://jira.freeswitch.org Thanks, On Oct 1, 2012, at 4:39 AM, Rick van Rein wrote:
Hello,
I found this surprising fragment in the sofia_glue.c routine
tech_pvt->adv_sdp_video_port = sdp_port; switch_channel_set_variable(tech_pvt->channel, SWITCH_LOCAL_VIDEO_IP_VARIABLE, tech_pvt->adv_sdp_audio_ip); switch_channel_set_variable_printf(tech_pvt->channel, SWITCH_LOCAL_VIDEO_PORT_VARIABLE, "%d", sdp_port);
I'm almost certain that "adv_sdp_audio_ip" should be "adv_sdp_video_ip", except that it isn't there in mod_sofia.h; is this code assuming that Audio and Video come from the same source? I don't think this assumption will remain valid with the advent of IPv6 and potential LAN-mounted camera's.
I am actually coding open source phone firmware that explicitly will pull in networked media devices by passing on their direct IPv6 addresses. This could be as simple as a webcam on a host.
If you don't mind I'll leave it to the regular developers to judge and fix this in the git repository. I would like to learn the outcome.
Cheers, -Rick
_________________________________________________________________________ Professional FreeSWITCH Consulting Services: consulting@freeswitch.org http://www.freeswitchsolutions.com
FreeSWITCH-powered IP PBX: The CudaTel Communication Server http://www.cudatel.com
Official FreeSWITCH Sites http://www.freeswitch.org http://wiki.freeswitch.org http://www.cluecon.com
FreeSWITCH-dev mailing list FreeSWITCH-dev@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev http://www.freeswitch.org
-- Brian West brian@freeswitch.org FreeSWITCH Solutions, LLC PO BOX PO BOX 2531 Brookfield, WI 53008-2531 Twitter: @FreeSWITCH_Wire T: +1.213.286.0410 | F: +1.213.286.0401 | M: +1.918.424.WEST iNUM: +883 5100 1286 0410