I also prefer small, controlled updates, however I can't do git push and jira would be a little pain ... Ken mentioned there's nothing wrong with white spaces in another mail, I agree but still think it's a little pain to generate "clean" diff when there's many trailing spaces involved. And as I said doing this could affect all devs So I'd like to get their ideas, especially we have more branches than before it's means need more merge and possible there's conflicts... 7. On Sunday, April 8, 2012 at 4:01 AM, Michael Collins wrote:
/usr/src/freeswitch/src# grep -rc "\s\+$" * | grep -v ":0$"
1200+ files with trailing whitespace does seem a bit excessive, however I don't know how large a "problem" it really is. If you're going to do whitespace cleanup I recommend starting small, like with mod_rtmp.c. Run your whitespace cleanup script on just a few files, recompile them, verify that it's all good, then commit & push. I don't know about the other devs, but I would feel much more comfortable with small, controlled updates than a large sweep that does a lot of files.
Just my $0.02...
-MC
On Sat, Apr 7, 2012 at 8:49 AM, Seven Du <dujinfang@gmail.com (mailto:dujinfang@gmail.com)> wrote:
cat -t mod_rtmp.c | grep I cat mod_rtmp.c | grep " $"
some editors insert tabs automatically when you press enter.
On Saturday, April 7, 2012 at 12:26 PM, Michael Collins wrote:
can you show us an example of code w/ trailing whitespaces? -MC
_________________________________________________________________________ Professional FreeSWITCH Consulting Services: consulting@freeswitch.org (mailto:consulting@freeswitch.org) http://www.freeswitchsolutions.com
FreeSWITCH-powered IP PBX: The CudaTel Communication Server http://www.cudatel.com
Official FreeSWITCH Sites http://www.freeswitch.org http://wiki.freeswitch.org http://www.cluecon.com
FreeSWITCH-dev mailing list FreeSWITCH-dev@lists.freeswitch.org (mailto:FreeSWITCH-dev@lists.freeswitch.org) http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev http://www.freeswitch.org