[Freeswitch-dev] Small error in mod_freetdm

[Moises Silva]

François,

Thanks for the great work on this.

Could you git clone FreeSWITCH and update your patch to latest freetdm?

This patch is outdated ( I am not sure what the latest snapshot of freetdm
is? who make those? ). The API has changed to NOT expose internal details to
users of FreeTDM ( ie: internal channel states and members ). Therefore
things like:

while (span->channels[chan_no]->state != FTDM_CHANNEL_STATE_DOWN);

Do not work nor compile in mod_freetdm.c ( since mod_freetdm is a user of
FreeTDM does not have access to the state member ).

Ping me on IRC or google talk (moy and moises.silva respectively) to
discuss.

Moises Silva
Senior Software Engineer
Sangoma Technologies Inc. | 50 McIntosh Drive, Suite 120, Markham ON L3R 9T3
Canada
t. 1 905 474 1990 x 128 | e. moy at sangoma.com


On Tue, Jun 1, 2010 at 3:45 PM, <devel at thom.fr.eu.org> wrote:

>  Done.
>
>
>
> The patch I attached to OPENZAP-100 includes the lines corresponding to
> OPENZAP-101.
>
>
>
> François
>
>
>
>
>
>
>
> *De :* freeswitch-dev-bounces at lists.freeswitch.org [mailto:
> freeswitch-dev-bounces at lists.freeswitch.org] *De la part de* Moises Silva
> *Envoyé :* mardi 1 juin 2010 18:20
> *À :* freeswitch-dev at lists.freeswitch.org
> *Objet :* Re: [Freeswitch-dev] Small error in mod_freetdm
>
>
>
> As of your patches for CID.
>
>
>
> Put them on JIRA as openzap bug and assign it to me.
>
>
> Moises Silva
> Senior Software Engineer
> Sangoma Technologies Inc. | 50 McIntosh Drive, Suite 120, Markham ON L3R
> 9T3 Canada
> t. 1 905 474 1990 x 128 | e. moy at sangoma.com
>
>  On Tue, Jun 1, 2010 at 11:51 AM, Moises Silva <moises.silva at gmail.com>
> wrote:
>
> Good catch, thanks, is fixed now.
>
> Moises Silva
> Senior Software Engineer
> Sangoma Technologies Inc. | 50 McIntosh Drive, Suite 120, Markham ON L3R
> 9T3 Canada
> t. 1 905 474 1990 x 128 | e. moy at sangoma.com
>
>   On Tue, Jun 1, 2010 at 10:47 AM, François Legal <devel at thom.fr.eu.org>
> wrote:
>
>  Oops,
>
>
>
> I meant
>
> "should probably be replaced by
>
>     chanid = ftdm_channel_get_id(sigmsg->channel);"
>
>
>
> François
>
> On Tue, 01 Jun 2010 16:27:19 +0200, François Legal <devel at thom.fr.eu.org>
> wrote:
>
> Hello,
>
>
>
> I recently upgraded to latest snapshot, and started using freetdm instead
> of openzap, and I found a small error in mod_freetdm.
>
> When setting up the channel name in function ftdm_channel_from_event line
> 1286, the line
>
>     chanid = ftdm_channel_get_span_id(sigmsg->channel);
>
> should probably be replaced by
>
>     chanid = ftdm_channel_get_number(sigmsg->channel);
>
>
>
> I wanted to post this on JIRA, but was not able to find a subproject for
> freetdm in JIRA.
>
>
>
> I also ported my patches from openzap to get the CID onto FXS channel work
> on european hardware with freetdm. Please let me know where I should post
> these.
>
>
>
> François
>
>
>
> _______________________________________________
> FreeSWITCH-dev mailing list
> FreeSWITCH-dev at lists.freeswitch.org
> http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev
> UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev
> http://www.freeswitch.org
>
>
>
>
>
> _______________________________________________
> FreeSWITCH-dev mailing list
> FreeSWITCH-dev at lists.freeswitch.org
> http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev
> UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev
> http://www.freeswitch.org
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.freeswitch.org/pipermail/freeswitch-dev/attachments/20100602/22889cdf/attachment.html