[Freeswitch-users] RFC 2833 DTMF detection - has something changed?
peter.olsson at visionutveckling.se
Fri Jan 21 13:06:30 MSK 2011
Thanks again, I tried the change below but it didn't help - however, it gave me a clue for what's going on :)
The problem seems to be that do_flush() will flush valid DTMF packets, and since do_flush() is called every time a file start/stops playing (because of rtp break is called) it is quite possible to be unlucky and miss DTMF's during this short period of time.
I've created a patch for this in jira FS-3002, it refactors the RFC2833 detection code, and after trying this out for the last 24 hours, the problems seems to be solved. Please review and apply this patch if it seems ok to you (or get back to me if you have any thoughts about the implemenation). More detailed information can be found in the jira case.
While you're at it - I have a few other patches laying around in jira - if you could have a look at those also I would really appreciate it :)
FS-2917, FS-2973 and FS-2971
Från: freeswitch-users-bounces at lists.freeswitch.org [mailto:freeswitch-users-bounces at lists.freeswitch.org] För Anthony Minessale
Skickat: den 19 januari 2011 19:22
Till: FreeSWITCH Users Help
Ämne: Re: [Freeswitch-users] RFC 2833 DTMF detection - has something changed?
comment line 2993 and see if its better.
If it works better, what is on the other end of the call?, I hate it already.
On Wed, Jan 19, 2011 at 12:12 PM, Peter Olsson
<peter.olsson at visionutveckling.se> wrote:
> Yep, I'm on today's git, so I do have the last change/fix that was made for this in switch.rtp.c.
> Från: freeswitch-users-bounces at lists.freeswitch.org [freeswitch-users-bounces at lists.freeswitch.org] för Steven Ayre [steveayre at gmail.com]
> Skickat: den 19 januari 2011 18:33
> Till: FreeSWITCH Users Help
> Ämne: Re: [Freeswitch-users] RFC 2833 DTMF detection - has something changed?
> Brian, he says he's on Git from today...
> On 19 January 2011 17:10, Brian West <brian at freeswitch.org<mailto:brian at freeswitch.org>> wrote:
> Update we did have one day where it was messed up.
> On Jan 19, 2011, at 11:02 AM, Peter Olsson wrote:
> I have some problems with DTMF detection, which I've never seen earlier versions. I know that there was a bug in the rtp code a few days (or week(s)?) back, but I'm running on latest git (as of today). I'm also running on the same machine as before, and more or less no config changes (except for a few dialplan changes, but nothing that changes DTMF detection).
> Anyway, it seems to me that the 2833-detection is not as accurate as it was before. When using a couple of months old FS version I rarely missed any DTMF's (I can't remember I ever did..:)), but now it seems to happen once in a while. Also, I decided today to get wireshark up and running, and after 5 DTMF's, FS missed the last one. I looked inside my wireshark dump, and I could clearly see all DTMF packets in there, but FS somehow missed this.
> Is there some kind of debugging I could enable, for instance DEBUG_2833 directive?
> What's the best way to move this forward? I can send my wireshark dump if that helps, but I guess you will need some more debugging info from FS as well?
> Peter Olsson
> FreeSWITCH-users mailing list
> FreeSWITCH-users at lists.freeswitch.org<mailto:FreeSWITCH-users at lists.freeswitch.org>
> FreeSWITCH-users mailing list
> FreeSWITCH-users at lists.freeswitch.org
Anthony Minessale II
MSN:anthony_minessale at hotmail.com
GTALK/JABBER/PAYPAL:anthony.minessale at gmail.com
IRC: irc.freenode.net #freeswitch
FreeSWITCH Developer Conference
sip:888 at conference.freeswitch.org
googletalk:conf+888 at conference.freeswitch.org
FreeSWITCH-users mailing list
FreeSWITCH-users at lists.freeswitch.org
More information about the FreeSWITCH-users