[Freeswitch-users] Memory leak in mod_nibblebill or in ODBC core?

Henry Huang b_ball_henry at hotmail.com
Wed May 12 03:47:57 PDT 2010


Sergey:

just making sure. When you say it works okay, did you mean the memory leak
stopped?



On Wed, May 12, 2010 at 6:23 PM, Sergey Okhapkin
<sos at sokhapkin.dyndns.org>wrote:

> I didn't try yesterday Anthony's update, but his previous fix works OK.
>
> Please note that comments in nibblebill config file and default actions in
> nibblebill code for lowbal_action, nobal_action and percall_action are
> incorrect, the parameters are not the applications to execute, but dialplan
> extensions to transfer the call to.
>
> On Wednesday 12 May 2010, Henry Huang wrote:
> > Sergey:
> >
> > Did you tried the latest code of nibbliebill? and did it fix your
> problem?
> >
> >
> >
> > On Tue, May 11, 2010 at 12:23 AM, Anthony Minessale <
> >
> > anthony.minessale at gmail.com> wrote:
> > > ok so you don't know for sure then, this is obviously a small box.
> > > My browser right now is using 500m to let me write this email to you.
> > >
> > > if you find nothing, it would suggest pools growing more than a real
> leak
> > > since valgrind would normally pick it up.
> > > I did not make this nibble bill module but I did correct the code in
> the
> > > place you pointed out.  Give it a try.
> > >
> > > I wish I could nibble-bill this mailing list =p
> > >
> > >
> > > On Mon, May 10, 2010 at 11:14 AM, Sergey Okhapkin <
> > >
> > > sos at sokhapkin.dyndns.org> wrote:
> > >> It's already on jira - FSMOD-48. Valgrind with --leak-check=full finds
> > >> nothing.
> > >>
> > >> Memory kept growing and growing, I had to restart FS when RSS reached
> > >> 500M to
> > >> avoid swap.
> > >>
> > >> On Monday 10 May 2010, Anthony Minessale wrote:
> > >> > Why does this thread continue on the list instead of being opened in
> > >>
> > >> JIRA
> > >>
> > >> > Can you see how this issue can be forgotten because it's on the
> > >> > mailing list that gets 200 emails a day?
> > >> > When you show the code in the body of an email like that, then I
> have
> > >> > to spend a minuted wondering where in the code you were talking
> about
> > >>
> > >> because
> > >>
> > >> > it's not in the form of a unified diff.
> > >> >
> > >> > I appreciate that you do not normally have to deal with organized
> > >>
> > >> software
> > >>
> > >> > management but I must ask that you please spend a little time to
> learn
> > >>
> > >> our
> > >>
> > >> > customs and use JIRA and patches to communicate bug reports.  I am
> > >> > glad
> > >>
> > >> you
> > >>
> > >> > are helping to find problems but we really need to stay organized to
> > >>
> > >> make
> > >>
> > >> >  it forward.
> > >> >
> > >> > I redid the function in latest GIT.  It did look like it was doing a
> > >> > few things wrong but they probably would have surfaced in valgrind
> if
> > >> > you
> > >>
> > >> were
> > >>
> > >> > running it in full leak check mode.  When you say it goes to 300M,
> > >> > does
> > >>
> > >> it
> > >>
> > >> > keep going from there because there is a bit of memory that will be
> > >>
> > >> pooled
> > >>
> > >> > as you start to use more advanced features.  Did you ever watch it
> to
> > >>
> > >> see
> > >>
> > >> > how high it will go?
> > >> >
> > >> > On Sun, May 9, 2010 at 4:01 PM, Sergey Okhapkin
> > >>
> > >> <sos at sokhapkin.dyndns.org>wrote:
> > >> > > Shouldn't label "end:" be BEFORE
> > >> > > switch_odbc_statement_handle_free(&stmt); ?
> > >> > > I think it should...
> > >> > >
> > >> > >
> > >> > > static switch_status_t bill_event(
> > >> > > ....
> > >> > >
> > >> > >       if (switch_odbc_handle_exec(globals.master_odbc, sql, &stmt,
> > >>
> > >> NULL)
> > >>
> > >> > > != SWITCH_ODBC_SUCCESS) {
> > >> > >                char *err_str;
> > >> > >                err_str =
> > >> > > switch_odbc_handle_get_error(globals.master_odbc, stmt);
> > >> > >                switch_log_printf(SWITCH_CHANNEL_LOG,
> > >> > > SWITCH_LOG_ERROR, "ERR:
> > >> > > [%s]\n[%s]\n", sql, switch_str_nil(err_str));
> > >> > >                switch_safe_free(err_str);
> > >> > >        } else {
> > >> > >                /* TODO: Failover to a flat/text file if DB is
> > >>
> > >> unavailable
> > >>
> > >> > > */
> > >> > >
> > >> > >                goto end;
> > >> > >        }
> > >> > >
> > >> > >        switch_odbc_statement_handle_free(&stmt);
> > >> > >
> > >> > > end:
> > >> > >
> > >> > > On Sunday 09 May 2010, Brian West wrote:
> > >> > > > What are you calling significant memory usage?
> > >> > > >
> > >> > > > /b
> > >> > > >
> > >> > > > On May 9, 2010, at 2:10 PM, Sergey Okhapkin wrote:
> > >> > > > > Valgrind output shows no significant leaks. This was discussed
> > >> > > > > already
> > >> > >
> > >> > > in
> > >> > >
> > >> > > > > this thread a month ago.
> > >> > > > >
> > >> > > > > On Sunday 09 May 2010, Brian West wrote:
> > >> > > > >> Please use valgrind and see where its leaking then open a
> jira.
> > >> > > > >>
> > >> > > > >> Nobody has been able to reproduce this in a lab nor provide
> any
> > >> > >
> > >> > > details
> > >> > >
> > >> > > > >> to assist in finding the issue... All I have seen is people
> > >> > >
> > >> > > complaining
> > >> > >
> > >> > > > >> about it and not doing what they should debugging the issue
> and
> > >> > > > >> reporting it.
> > >> > > > >>
> > >> > > > >> /b
> > >> > > >
> > >> > > > _______________________________________________
> > >> > > > FreeSWITCH-users mailing list
> > >> > > > FreeSWITCH-users at lists.freeswitch.org
> > >> > > > http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
> > >> > > > UNSUBSCRIBE:
> > >>
> > >> http://lists.freeswitch.org/mailman/options/freeswitch-user
> > >>
> > >> > > >s http://www.freeswitch.org
> > >> > >
> > >> > > _______________________________________________
> > >> > > FreeSWITCH-users mailing list
> > >> > > FreeSWITCH-users at lists.freeswitch.org
> > >> > > http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
> > >> > > UNSUBSCRIBE:
> > >>
> > >> http://lists.freeswitch.org/mailman/options/freeswitch-users
> > >>
> > >> > > http://www.freeswitch.org
> > >>
> > >> _______________________________________________
> > >> FreeSWITCH-users mailing list
> > >> FreeSWITCH-users at lists.freeswitch.org
> > >> http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
> > >> UNSUBSCRIBE:
> http://lists.freeswitch.org/mailman/options/freeswitch-users
> > >> http://www.freeswitch.org
> > >
> > > --
> > > Anthony Minessale II
> > >
> > > FreeSWITCH http://www.freeswitch.org/
> > > ClueCon http://www.cluecon.com/
> > > Twitter: http://twitter.com/FreeSWITCH_wire
> > >
> > > AIM: anthm
> > > MSN:anthony_minessale at hotmail.com<MSN%3Aanthony_minessale at hotmail.com><
> MSN%3Aanthony_minessale at hotmail.com<MSN%253Aanthony_minessale at hotmail.com>
> >
> > > GTALK/JABBER/PAYPAL:anthony.minessale at gmail.com<PAYPAL%3Aanthony.minessale at gmail.com>
> <PAYPAL%3Aanthony.minessal
> > >e at gmail.com> IRC: irc.freenode.net #freeswitch
> > >
> > > FreeSWITCH Developer Conference
> > > sip:888 at conference.freeswitch.org<sip%3A888 at conference.freeswitch.org><
> sip%3A888 at conference.freeswitch.org<sip%253A888 at conference.freeswitch.org>
> >
> > > googletalk:conf+888 at conference.freeswitch.org<googletalk%3Aconf%2B888 at conference.freeswitch.org>
> <googletalk%3Aconf%2B888 at con
> > >ference.freeswitch.org> pstn:+19193869900
> > >
> > > _______________________________________________
> > > FreeSWITCH-users mailing list
> > > FreeSWITCH-users at lists.freeswitch.org
> > > http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
> > > UNSUBSCRIBE:
> http://lists.freeswitch.org/mailman/options/freeswitch-users
> > > http://www.freeswitch.org
> >
>
>
> _______________________________________________
> FreeSWITCH-users mailing list
> FreeSWITCH-users at lists.freeswitch.org
> http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
> UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
> http://www.freeswitch.org
>



-- 
Henry Huang
UniC Solution - Communication Unified
VoIP & Open Source software Consultant
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.freeswitch.org/pipermail/freeswitch-users/attachments/20100512/c61614c6/attachment-0001.html 


More information about the FreeSWITCH-users mailing list