[Freeswitch-users] Memory leak in mod_nibblebill or in ODBC core?

Sergey Okhapkin sos at sokhapkin.dyndns.org
Sun May 9 14:01:03 PDT 2010


Shouldn't label "end:" be BEFORE  switch_odbc_statement_handle_free(&stmt); ? 
I think it should...


static switch_status_t bill_event(
....

       if (switch_odbc_handle_exec(globals.master_odbc, sql, &stmt, NULL) != 
SWITCH_ODBC_SUCCESS) {
                char *err_str;
                err_str = switch_odbc_handle_get_error(globals.master_odbc, 
stmt);
                switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "ERR: 
[%s]\n[%s]\n", sql, switch_str_nil(err_str));
                switch_safe_free(err_str);
        } else {
                /* TODO: Failover to a flat/text file if DB is unavailable */

                goto end;
        }

        switch_odbc_statement_handle_free(&stmt);

end:


On Sunday 09 May 2010, Brian West wrote:
> What are you calling significant memory usage?
> 
> /b
> 
> On May 9, 2010, at 2:10 PM, Sergey Okhapkin wrote:
> > Valgrind output shows no significant leaks. This was discussed already in
> > this thread a month ago.
> >
> > On Sunday 09 May 2010, Brian West wrote:
> >> Please use valgrind and see where its leaking then open a jira.
> >>
> >> Nobody has been able to reproduce this in a lab nor provide any details
> >> to assist in finding the issue... All I have seen is people complaining
> >> about it and not doing what they should debugging the issue and
> >> reporting it.
> >>
> >> /b
> 
> _______________________________________________
> FreeSWITCH-users mailing list
> FreeSWITCH-users at lists.freeswitch.org
> http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
> UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
> http://www.freeswitch.org
> 




More information about the FreeSWITCH-users mailing list