Not proxying session refresh INVITEs when in bypass media mode
Hello all, Apologies if this is the wrong place for this type of discussion as its a little dev oriented. JIRA/PR to follow once we get a little better direction. We’re interested in adding a feature to ignore (i.e. not proxy across the bridge) session refresh INVITEs where the SDP has not changed when in bypass media mode, similarly to how ReINVITEs are handled in “normal” mode. So a few questions: - Does this already exist and I missed it? - Is there any recommendation on when to consider the SDP “the same” as the previous SDP? The scenarios I can think of where we would definitely need proxy the ReINVITE are T38, holds and video attribute changes. My thought is to just 200 OK codec changes that keep the same connection IP and port to keep things simpler but I’d like some feedback here. Are there other scenarios I’ve missed? - Where should we store the address and port for later comparison? SWITCH_REMOTE_MEDIA_IP_VARIABLE (remote_media_ip) and SWITCH_REMOTE_MEDIA_PORT_VARIABLE (remote_media_port)? Are these only used for audio currently? I see there are another set for video... - As we would need to parse the connection address and port in the SDP, what would be the preferred way? Just use the sofia sdp parser? Or do it manually? Doing it manually might be faster but I’m sure there would be edge cases we would need to work out i.e. multiple c= lines, etc.. Or is there a “builtin” way I overlooked? - Has anyone tried this and are there any horror stories? - Does anyone have any feedback for the best user interface handles? I.e. potential channel variables and/or SIP profile params? I was thinking something along the lines of a param called “nomedia-ignore-refresh-invite” but that might be confusing and hopefully someone has a better name :-) Thanks! Spencer
There is sip_ignore_reinvites channel var. That would be the extent of what we have for that case. On Wed, Apr 5, 2017 at 11:52 AM, Spencer Thomason < spencer@whiteskycommunications.com> wrote:
Hello all, Apologies if this is the wrong place for this type of discussion as its a little dev oriented. JIRA/PR to follow once we get a little better direction.
We’re interested in adding a feature to ignore (i.e. not proxy across the bridge) session refresh INVITEs where the SDP has not changed when in bypass media mode, similarly to how ReINVITEs are handled in “normal” mode. So a few questions:
- Does this already exist and I missed it?
- Is there any recommendation on when to consider the SDP “the same” as the previous SDP? The scenarios I can think of where we would definitely need proxy the ReINVITE are T38, holds and video attribute changes. My thought is to just 200 OK codec changes that keep the same connection IP and port to keep things simpler but I’d like some feedback here. Are there other scenarios I’ve missed?
- Where should we store the address and port for later comparison? SWITCH_REMOTE_MEDIA_IP_VARIABLE (remote_media_ip) and SWITCH_REMOTE_MEDIA_PORT_VARIABLE (remote_media_port)? Are these only used for audio currently? I see there are another set for video...
- As we would need to parse the connection address and port in the SDP, what would be the preferred way? Just use the sofia sdp parser? Or do it manually? Doing it manually might be faster but I’m sure there would be edge cases we would need to work out i.e. multiple c= lines, etc.. Or is there a “builtin” way I overlooked?
- Has anyone tried this and are there any horror stories?
- Does anyone have any feedback for the best user interface handles? I.e. potential channel variables and/or SIP profile params? I was thinking something along the lines of a param called “nomedia-ignore-refresh-invite” but that might be confusing and hopefully someone has a better name :-)
Thanks! Spencer _________________________________________________________________________ Professional FreeSWITCH Consulting Services: consulting@freeswitch.org http://www.freeswitchsolutions.com
Official FreeSWITCH Sites http://www.freeswitch.org http://confluence.freeswitch.org http://www.cluecon.com
FreeSWITCH-users mailing list FreeSWITCH-users@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-users UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users http://www.freeswitch.org
-- Anthony Minessale II ♬ @anthmfs ♬ @FreeSWITCH ♬ ☞ http://freeswitch.org/ ☞ http://cluecon.com/ ☞ http://twitter.com/FreeSWITCH ☞ irc.freenode.net #freeswitch ☞ *http://freeswitch.org/g+ <http://freeswitch.org/g+>* ClueCon Weekly Development Call ☎ sip:888@conference.freeswitch.org ☎ +19193869900 https://www.youtube.com/watch?v=9XXgW34t40s https://www.youtube.com/watch?v=NLaDpGQuZDA
Hi Anthony, I’m working on a patch and PR to add this feature. Do you have any recommendation on how this should be enabled/disabled and naming for such param or variable? Would this be considered a media flag or a profile flag? Thanks, Spencer On Apr 5, 2017, at 11:05 AM, Anthony Minessale <anthony.minessale@gmail.com<mailto:anthony.minessale@gmail.com>> wrote: There is sip_ignore_reinvites channel var. That would be the extent of what we have for that case. On Wed, Apr 5, 2017 at 11:52 AM, Spencer Thomason <spencer@whiteskycommunications.com<mailto:spencer@whiteskycommunications.com>> wrote: Hello all, Apologies if this is the wrong place for this type of discussion as its a little dev oriented. JIRA/PR to follow once we get a little better direction. We’re interested in adding a feature to ignore (i.e. not proxy across the bridge) session refresh INVITEs where the SDP has not changed when in bypass media mode, similarly to how ReINVITEs are handled in “normal” mode. So a few questions: - Does this already exist and I missed it? - Is there any recommendation on when to consider the SDP “the same” as the previous SDP? The scenarios I can think of where we would definitely need proxy the ReINVITE are T38, holds and video attribute changes. My thought is to just 200 OK codec changes that keep the same connection IP and port to keep things simpler but I’d like some feedback here. Are there other scenarios I’ve missed? - Where should we store the address and port for later comparison? SWITCH_REMOTE_MEDIA_IP_VARIABLE (remote_media_ip) and SWITCH_REMOTE_MEDIA_PORT_VARIABLE (remote_media_port)? Are these only used for audio currently? I see there are another set for video... - As we would need to parse the connection address and port in the SDP, what would be the preferred way? Just use the sofia sdp parser? Or do it manually? Doing it manually might be faster but I’m sure there would be edge cases we would need to work out i.e. multiple c= lines, etc.. Or is there a “builtin” way I overlooked? - Has anyone tried this and are there any horror stories? - Does anyone have any feedback for the best user interface handles? I.e. potential channel variables and/or SIP profile params? I was thinking something along the lines of a param called “nomedia-ignore-refresh-invite” but that might be confusing and hopefully someone has a better name :-) Thanks! Spencer _________________________________________________________________________ Professional FreeSWITCH Consulting Services: consulting@freeswitch.org<mailto:consulting@freeswitch.org> http://www.freeswitchsolutions.com<http://www.freeswitchsolutions.com/> Official FreeSWITCH Sites http://www.freeswitch.org<http://www.freeswitch.org/> http://confluence.freeswitch.org<http://confluence.freeswitch.org/> http://www.cluecon.com<http://www.cluecon.com/> FreeSWITCH-users mailing list FreeSWITCH-users@lists.freeswitch.org<mailto:FreeSWITCH-users@lists.freeswitch.org> http://lists.freeswitch.org/mailman/listinfo/freeswitch-users UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users http://www.freeswitch.org<http://www.freeswitch.org/> -- Anthony Minessale II ♬ @anthmfs ♬ @FreeSWITCH ♬ ☞ http://freeswitch.org/ ☞ http://cluecon.com/ ☞ http://twitter.com/FreeSWITCH ☞ irc.freenode.net<http://irc.freenode.net/> #freeswitch ☞ http://freeswitch.org/g+ ClueCon Weekly Development Call ☎ sip:888@conference.freeswitch.org<mailto:sip%3A888@conference.freeswitch.org> ☎ +19193869900 https://www.youtube.com/watch?v=9XXgW34t40s https://www.youtube.com/watch?v=NLaDpGQuZDA _________________________________________________________________________ Professional FreeSWITCH Consulting Services: consulting@freeswitch.org<mailto:consulting@freeswitch.org> http://www.freeswitchsolutions.com Official FreeSWITCH Sites http://www.freeswitch.org http://confluence.freeswitch.org http://www.cluecon.com FreeSWITCH-users mailing list FreeSWITCH-users@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-users UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users http://www.freeswitch.org
Probs a profile flag On Fri, Apr 7, 2017 at 8:40 PM Spencer Thomason < spencer@whiteskycommunications.com> wrote:
Hi Anthony, I’m working on a patch and PR to add this feature. Do you have any recommendation on how this should be enabled/disabled and naming for such param or variable? Would this be considered a media flag or a profile flag?
Thanks, Spencer
On Apr 5, 2017, at 11:05 AM, Anthony Minessale < anthony.minessale@gmail.com> wrote:
There is
sip_ignore_reinvites channel var.
That would be the extent of what we have for that case.
On Wed, Apr 5, 2017 at 11:52 AM, Spencer Thomason < spencer@whiteskycommunications.com> wrote:
Hello all, Apologies if this is the wrong place for this type of discussion as its a little dev oriented. JIRA/PR to follow once we get a little better direction.
We’re interested in adding a feature to ignore (i.e. not proxy across the bridge) session refresh INVITEs where the SDP has not changed when in bypass media mode, similarly to how ReINVITEs are handled in “normal” mode. So a few questions:
- Does this already exist and I missed it?
- Is there any recommendation on when to consider the SDP “the same” as the previous SDP? The scenarios I can think of where we would definitely need proxy the ReINVITE are T38, holds and video attribute changes. My thought is to just 200 OK codec changes that keep the same connection IP and port to keep things simpler but I’d like some feedback here. Are there other scenarios I’ve missed?
- Where should we store the address and port for later comparison? SWITCH_REMOTE_MEDIA_IP_VARIABLE (remote_media_ip) and SWITCH_REMOTE_MEDIA_PORT_VARIABLE (remote_media_port)? Are these only used for audio currently? I see there are another set for video...
- As we would need to parse the connection address and port in the SDP, what would be the preferred way? Just use the sofia sdp parser? Or do it manually? Doing it manually might be faster but I’m sure there would be edge cases we would need to work out i.e. multiple c= lines, etc.. Or is there a “builtin” way I overlooked?
- Has anyone tried this and are there any horror stories?
- Does anyone have any feedback for the best user interface handles? I.e. potential channel variables and/or SIP profile params? I was thinking something along the lines of a param called “nomedia-ignore-refresh-invite” but that might be confusing and hopefully someone has a better name :-)
Thanks! Spencer _________________________________________________________________________ Professional FreeSWITCH Consulting Services: consulting@freeswitch.org http://www.freeswitchsolutions.com
Official FreeSWITCH Sites http://www.freeswitch.org http://confluence.freeswitch.org http://www.cluecon.com
FreeSWITCH-users mailing list FreeSWITCH-users@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-users UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users http://www.freeswitch.org
-- Anthony Minessale II ♬ @anthmfs ♬ @FreeSWITCH ♬
☞ http://freeswitch.org/ ☞ http://cluecon.com/ ☞ http://twitter.com/FreeSWITCH ☞ irc.freenode.net #freeswitch ☞ *http://freeswitch.org/g+ <http://freeswitch.org/g+>*
ClueCon Weekly Development Call ☎ sip:888@conference.freeswitch.org ☎ +19193869900
https://www.youtube.com/watch?v=9XXgW34t40s https://www.youtube.com/watch?v=NLaDpGQuZDA _________________________________________________________________________ Professional FreeSWITCH Consulting Services: consulting@freeswitch.org http://www.freeswitchsolutions.com
Official FreeSWITCH Sites http://www.freeswitch.org http://confluence.freeswitch.org http://www.cluecon.com
FreeSWITCH-users mailing list FreeSWITCH-users@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-users UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users http://www.freeswitch.org
_________________________________________________________________________ Professional FreeSWITCH Consulting Services: consulting@freeswitch.org http://www.freeswitchsolutions.com
Official FreeSWITCH Sites http://www.freeswitch.org http://confluence.freeswitch.org http://www.cluecon.com
FreeSWITCH-users mailing list FreeSWITCH-users@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-users UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users http://www.freeswitch.org
-- Anthony Minessale II ♬ @anthmfs ♬ @FreeSWITCH ♬ ☞ http://freeswitch.org/ ☞ http://cluecon.com/ ☞ http://twitter.com/FreeSWITCH ☞ irc.freenode.net #freeswitch ☞ *http://freeswitch.org/g+ <http://freeswitch.org/g+>* ClueCon Weekly Development Call ☎ sip:888@conference.freeswitch.org ☎ +19193869900 https://www.youtube.com/watch?v=9XXgW34t40s https://www.youtube.com/watch?v=NLaDpGQuZDA
participants (2)
-
Anthony Minessale
-
Spencer Thomason