bridge_generate_comfort_noise not honoring integer value for volume level
I can successfully inject whitenoise on the bridged leg (audio from A leg towards the bridged call) in the dial plan by setting bridge_generate_comfort_noise=true. The whitenoise is quite loud and I would like to make it quieter or silent (I am just trying to keep the far end firewall port open during long periods of A leg not sending packets due to hold). I have tried values of -1, 40,1400, and 4000 instead of true and they produce the same amount of whitenoise volume. The source code in switch_ivr_bridge.c looks like it indeed honors an integer value, but somehow the end result is always the same. If I do not set the variable I get no whitenoise, so the variable is indeed controlling whitenoise, just not the volume level of whitenoise. The codec is PCMU. I can repeat this with 1.2, 1.4, and 1.6 branches of FS. Matthew Meek
The higher the number the softer it will get. You say 4000 didn't work? -1 should be absolute silence. On Thu, Dec 14, 2017 at 6:01 AM, Matthew Meek <mmeek@livexchange.com> wrote:
I can successfully inject whitenoise on the bridged leg (audio from A leg towards the bridged call) in the dial plan by setting bridge_generate_comfort_noise=true. The whitenoise is quite loud and I would like to make it quieter or silent (I am just trying to keep the far end firewall port open during long periods of A leg not sending packets due to hold). I have tried values of -1, 40,1400, and 4000 instead of true and they produce the same amount of whitenoise volume. The source code in switch_ivr_bridge.c looks like it indeed honors an integer value, but somehow the end result is always the same. If I do not set the variable I get no whitenoise, so the variable is indeed controlling whitenoise, just not the volume level of whitenoise. The codec is PCMU.
I can repeat this with 1.2, 1.4, and 1.6 branches of FS.
Matthew Meek
_________________________________________________________________________ Professional FreeSWITCH Consulting Services: consulting@freeswitch.org http://www.freeswitchsolutions.com
Official FreeSWITCH Sites http://www.freeswitch.org http://confluence.freeswitch.org http://www.cluecon.com
FreeSWITCH-users mailing list FreeSWITCH-users@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-users UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users http://www.freeswitch.org
-- Anthony Minessale II Founder, FreeSWITCH. https://youtu.be/l_hOxzCt6X4 https://www.youtube.com/watch?v=oAxXgyx5jUw https://www.youtube.com/watch?v=9XXgW34t40s https://www.youtube.com/watch?v=NLaDpGQuZDA
The values of -2,-1 50, 1400, and 4000 all have the same volume of whitenoise. I am setting it with: <action application="set" data="bridge_generate_comfort_noise=4000"/> I can see in the code where this should work (although -1 is doubtful to be silence as the if block checks for silence_val < -1 instead of <= -1), but in practice the value has no effect. I am not sure if the value is over-ridden somewhere else. -Matthew Meek The higher the number the softer it will get. You say 4000 didn't work? -1 should be absolute silence. On Thu, Dec 14, 2017 at 6:01 AM, Matthew Meek <mmeek@livexchange.com<mailto:mmeek@livexchange.com>> wrote: I can successfully inject whitenoise on the bridged leg (audio from A leg towards the bridged call) in the dial plan by setting bridge_generate_comfort_noise=true. The whitenoise is quite loud and I would like to make it quieter or silent (I am just trying to keep the far end firewall port open during long periods of A leg not sending packets due to hold). I have tried values of -1, 40,1400, and 4000 instead of true and they produce the same amount of whitenoise volume. The source code in switch_ivr_bridge.c looks like it indeed honors an integer value, but somehow the end result is always the same. If I do not set the variable I get no whitenoise, so the variable is indeed controlling whitenoise, just not the volume level of whitenoise. The codec is PCMU. I can repeat this with 1.2, 1.4, and 1.6 branches of FS. Matthew Meek _________________________________________________________________________ Professional FreeSWITCH Consulting Services: consulting@freeswitch.org<mailto:consulting@freeswitch.org> http://www.freeswitchsolutions.com Official FreeSWITCH Sites http://www.freeswitch.org http://confluence.freeswitch.org http://www.cluecon.com FreeSWITCH-users mailing list FreeSWITCH-users@lists.freeswitch.org<mailto:FreeSWITCH-users@lists.freeswitch.org> http://lists.freeswitch.org/mailman/listinfo/freeswitch-users UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users http://www.freeswitch.org -- Anthony Minessale II Founder, FreeSWITCH. https://youtu.be/l_hOxzCt6X4 https://www.youtube.com/watch?v=oAxXgyx5jUw https://www.youtube.com/watch?v=9XXgW34t40s https://www.youtube.com/watch?v=NLaDpGQuZDA
did you try 8000 or 16000 you may need to add some debugging to the code and see. If this is a bug, you really should be reporting it to JIRA as we don't really monitor the discussion list for bug reports. On Mon, Dec 18, 2017 at 1:39 AM, Matthew Meek <mmeek@livexchange.com> wrote:
The values of -2,-1 50, 1400, and 4000 all have the same volume of whitenoise. I am setting it with:
<action application="set" data="bridge_generate_comfort_noise=4000"/>
I can see in the code where this should work (although -1 is doubtful to be silence as the if block checks for silence_val < -1 instead of <= -1), but in practice the value has no effect. I am not sure if the value is over-ridden somewhere else.
-Matthew Meek
The higher the number the softer it will get. You say 4000 didn't work? -1 should be absolute silence.
On Thu, Dec 14, 2017 at 6:01 AM, Matthew Meek <mmeek@livexchange.com> wrote:
I can successfully inject whitenoise on the bridged leg (audio from A leg towards the bridged call) in the dial plan by setting bridge_generate_comfort_noise=true. The whitenoise is quite loud and I would like to make it quieter or silent (I am just trying to keep the far end firewall port open during long periods of A leg not sending packets due to hold). I have tried values of -1, 40,1400, and 4000 instead of true and they produce the same amount of whitenoise volume. The source code in switch_ivr_bridge.c looks like it indeed honors an integer value, but somehow the end result is always the same. If I do not set the variable I get no whitenoise, so the variable is indeed controlling whitenoise, just not the volume level of whitenoise. The codec is PCMU.
I can repeat this with 1.2, 1.4, and 1.6 branches of FS.
Matthew Meek
_________________________________________________________________________ Professional FreeSWITCH Consulting Services: consulting@freeswitch.org http://www.freeswitchsolutions.com
Official FreeSWITCH Sites http://www.freeswitch.org http://confluence.freeswitch.org http://www.cluecon.com
FreeSWITCH-users mailing list FreeSWITCH-users@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-users UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users http://www.freeswitch.org
--
Anthony Minessale II
Founder, FreeSWITCH.
https://www.youtube.com/watch?v=oAxXgyx5jUw
https://www.youtube.com/watch?v=9XXgW34t40s
https://www.youtube.com/watch?v=NLaDpGQuZDA
_________________________________________________________________________ Professional FreeSWITCH Consulting Services: consulting@freeswitch.org http://www.freeswitchsolutions.com
Official FreeSWITCH Sites http://www.freeswitch.org http://confluence.freeswitch.org http://www.cluecon.com
FreeSWITCH-users mailing list FreeSWITCH-users@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-users UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users http://www.freeswitch.org
-- Anthony Minessale II Founder, FreeSWITCH. http://freeswitch.com https://youtu.be/l_hOxzCt6X4 https://www.youtube.com/watch?v=oAxXgyx5jUw https://www.youtube.com/watch?v=9XXgW34t40s https://www.youtube.com/watch?v=NLaDpGQuZDA
participants (2)
-
Anthony Minessale
-
Matthew Meek