Hi! Run into a bug, when using «#» (hash) symbol in numbers using sip-over-wss with jssip or sip.js. Idea is, when you call some number, that contains # symbol, Freeswitch in a case of 2nd leg answer sends 200 OK with full dialed number in Contact field. And when jssip or sipjs tries to parse Contact field with hash symbol, they can’t do it (maybe cause this symbol is not urlencoded) So, is this a FS bug or more to JS sip libraries? Regards, Igor
Does FreeSWITCH master show the same issue? I added a bit back some more url encoding to more fields we generate to make sure we don’t send things that need to be encoded unencoded. I don’t recall if # is one of the chars that actually must be or not.
On Dec 14, 2017, at 1:10 PM, Igor Olhovskiy <igorolhovskiy@gmail.com> wrote:
Hi!
Run into a bug, when using «#» (hash) symbol in numbers using sip-over-wss with jssip or sip.js.
Idea is, when you call some number, that contains # symbol, Freeswitch in a case of 2nd leg answer sends 200 OK with full dialed number in Contact field. And when jssip or sipjs tries to parse Contact field with hash symbol, they can’t do it (maybe cause this symbol is not urlencoded)
So, is this a FS bug or more to JS sip libraries?
Regards, Igor _________________________________________________________________________ Professional FreeSWITCH Consulting Services: consulting@freeswitch.org http://www.freeswitchsolutions.com
Official FreeSWITCH Sites http://www.freeswitch.org http://confluence.freeswitch.org http://www.cluecon.com
FreeSWITCH-users mailing list FreeSWITCH-users@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-users UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users http://www.freeswitch.org
Will test against master, but anyway, according to https://tools.ietf.org/html/rfc3986#section-1.2.3 «#» is a special symbol for URI scheme (and Contact holds URI) and must be encoded. Regards, Igor On Dec 14, 2017, 8:22 PM +0200, Michael Jerris <mike@jerris.com>, wrote:
Does FreeSWITCH master show the same issue? I added a bit back some more url encoding to more fields we generate to make sure we don’t send things that need to be encoded unencoded. I don’t recall if # is one of the chars that actually must be or not.
On Dec 14, 2017, at 1:10 PM, Igor Olhovskiy <igorolhovskiy@gmail.com> wrote:
Hi!
Run into a bug, when using «#» (hash) symbol in numbers using sip-over-wss with jssip or sip.js.
Idea is, when you call some number, that contains # symbol, Freeswitch in a case of 2nd leg answer sends 200 OK with full dialed number in Contact field. And when jssip or sipjs tries to parse Contact field with hash symbol, they can’t do it (maybe cause this symbol is not urlencoded)
So, is this a FS bug or more to JS sip libraries?
Regards, Igor _________________________________________________________________________ Professional FreeSWITCH Consulting Services: consulting@freeswitch.org http://www.freeswitchsolutions.com
Official FreeSWITCH Sites http://www.freeswitch.org http://confluence.freeswitch.org http://www.cluecon.com
FreeSWITCH-users mailing list FreeSWITCH-users@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-users UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users http://www.freeswitch.org
participants (2)
-
Igor Olhovskiy
-
Michael Jerris