Please post to jira.freeswitch.org /b On Jan 20, 2011, at 6:05 PM, George Niculae wrote:

Hi All,

I noticed that in a pin protected conference scenario, if the user inputs more digits than the length of the correct one the remaining digits are accounted for next retry - e.g. if the conf pin is 1234 and user enter 12345 then 5 will be used as first digit in 2nd retry. Extension is configured as:

<extension name="5678"> <condition field="destination_number" expression="^uuu$"> <action application="set" data="supplied_pin=${sip_h_X-ConfPin}"/> <action application="export" data="supplied_pin=${sip_h_X-ConfPin}"/> <action application="bridge" data="loopback/app=conference:uuu@5678+1234"/> </condition> </extension>

I attached a patch for mod_conference that checks pin buffer to be 0 before starting to collect digits again and reset it if > 0. I also modified the code to play "please enter the conference access number" prompt just first time and only "the passcode you entered is not correct, please try again" on subsequent retries.

Please review the patch and let me know your comments.

Thanks, George

<0001-Conference-pin.patch>_______________________________________________ FreeSWITCH-users mailing list FreeSWITCH-users@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-users UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users http://www.freeswitch.org

George, Thanks for taking the time to look at the source code and creating a simple but useful patch. Your effort is definitely appreciated. Thank you also for putting this into Jira so that we can keep track of these sorts of things. -MC On Thu, Jan 20, 2011 at 4:05 PM, George Niculae <george.niculae79@gmail.com>wrote:

Hi All,

I noticed that in a pin protected conference scenario, if the user inputs more digits than the length of the correct one the remaining digits are accounted for next retry - e.g. if the conf pin is 1234 and user enter 12345 then 5 will be used as first digit in 2nd retry. Extension is configured as:

<extension name="5678"> <condition field="destination_number" expression="^uuu$"> <action application="set" data="supplied_pin=${sip_h_X-ConfPin}"/> <action application="export" data="supplied_pin=${sip_h_X-ConfPin}"/> <action application="bridge" data="loopback/app=conference:uuu@5678 +1234"/> </condition> </extension>

I attached a patch for mod_conference that checks pin buffer to be 0 before starting to collect digits again and reset it if > 0. I also modified the code to play "please enter the conference access number" prompt just first time and only "the passcode you entered is not correct, please try again" on subsequent retries.

Please review the patch and let me know your comments.

Thanks, George

_______________________________________________ FreeSWITCH-users mailing list FreeSWITCH-users@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-users UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users http://www.freeswitch.org