Hi, Finally, I got xml_odbc running, but it does not really work well for me. I am getting: 2009-08-28 03:33:47.459383 [ERR] mod_xml_odbc.c:325 Stopped rendering template, called xml_odbc_render_template more than [32] times, probably looping. 2009-08-28 03:33:47.459383 [ERR] mod_xml_odbc.c:408 Something went horribly wrong while generating an XML template! My config is: <configuration name="xml_odbc.conf" description="XML ODBC Configuration"> <settings> <param name="binding" value="directory"/> <param name="odbc-dsn" value="class5_odbc:root:JdqB-S"/> <param name="debug" value="true"/> <param name="keep-files-around" value="true"/> </settings> <templates> <template name="default"> <document type="freeswitch/xml"> <section name="directory"> <xml-odbc-do name="query" on-empty-result-break-to="not-found" value="SELECT enabled, sip_password FROM agent WHERE sip_user = ${user}"/> <domain name="${domain}"> <user id="${user}"> <params> <xml-odbc-do name="query" value="SELECT sip_password FROM agent WHERE sip_user = ${user}"> <param name="password", value="${sip_password}"/> </xml-odbc-do> </params> </user> </domain> </section> </document> </template> </templates> </configuration> Since these two queries get data from the same table, I tried to merge them, but could not get it to work. Anyone has any idea? Thanks, JB

Made a typo in the <param>, you have to leave out the comma.. regards, Leon On Aug 27, 2009, at 2:57 PM, Leon de Rooij wrote:

Hi Juan,

Perhaps it loops because you didn't include the "not-found" template ? Actually, I see there's a bug in the example xml_odbc.conf.xml file where it's defined with an underscore instead of a dash, will change that tonight..

The not-found template needs to be specified as a template in the configuration. I think I'll define that template statically in the module itself later. Because it's the 'fall-through' template when it can't find a template, you get a loop.

So, something like this should probably work for you:

<templates>

<template name="default"> <xml-odbc-do name="query" on-empty-result-break-to="not-found" value="SELECT sip_password FROM agent WHERE sip_user = '${user}';"/> <document type="freeswitch/xml"> <section name="directory"> <domain name="${domain}"> <user id="${user}"> <params> <param name="password", value="${sip_password}"/> </params> </user> </domain> </section> </document> </template>

<template name="not-found"> <document type="freeswitch/xml"> <section name="result"> <result status="not found"/> </section> </document> </template>

</templates>

(I didn't include the enabled field in your select statement, as you don't use it later, perhaps you need it in the where clause ?)

Also, note that this way the template will also be used at startup when FS tries to get a list of all ACL's - I believe for something else as well, have to check it - but those lookups probably don't give a ${user} so will render the "not-found" anyway..

One last thing, you didn't have ${user} enclosed in quotes in your query, so if no ${user} was given with the lookup to the module, then your query becomes invalid, which probably breaks things as well.

Let me know if it works..

regards,

Leon

On Aug 27, 2009, at 1:40 PM, Juan Backson wrote:

...

Hi,

Finally, I got xml_odbc running, but it does not really work well for me. I am getting: 2009-08-28 03:33:47.459383 [ERR] mod_xml_odbc.c:325 Stopped rendering template, called xml_odbc_render_template more than [32] times, probably looping. 2009-08-28 03:33:47.459383 [ERR] mod_xml_odbc.c:408 Something went horribly wrong while generating an XML template!

My config is: <configuration name="xml_odbc.conf" description="XML ODBC Configuration">

<settings> <param name="binding" value="directory"/> <param name="odbc-dsn" value="class5_odbc:root:JdqB-S"/> <param name="debug" value="true"/> <param name="keep-files-around" value="true"/> </settings>

<templates>

<template name="default"> <document type="freeswitch/xml"> <section name="directory"> <xml-odbc-do name="query" on-empty-result-break-to="not-found" value="SELECT enabled, sip_password FROM agent WHERE sip_user = $ {user}"/> <domain name="${domain}"> <user id="${user}"> <params> <xml-odbc-do name="query" value="SELECT sip_password FROM agent WHERE sip_user = ${user}"> <param name="password", value="${sip_password}"/> </xml-odbc-do> </params> </user> </domain>

</section> </document> </template>

</templates>

</configuration>

Since these two queries get data from the same table, I tried to merge them, but could not get it to work.

Anyone has any idea?

Thanks, JB _______________________________________________ FreeSWITCH-users mailing list FreeSWITCH-users@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-users UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users http://www.freeswitch.org

_______________________________________________ FreeSWITCH-users mailing list FreeSWITCH-users@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-users UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users http://www.freeswitch.org

Hi Juan, With debug=true you should be able to see what template it's trying to render in a loop, can you tell which one that is ? (I'm guessing it says 32 times it wants to render "not-found") In the xml you pasted in your mail, you didn't specify the name of the "not-found" template, just <template>, that could be the problem.. To get around the problem of generating a wrong query when the ${user} is not given, you could simply encapsulate everything with a check- event-header, like this: <template name="default"> <xml-odbc-do name="check-event-header" if-name="user"> <xml-odbc-do name="query" on-empty-result-break-to="not-found" value="...etc"> ..rest of your template goes here.. </xml-odbc-do> </xml-odbc-do> </template> But that would mean that an "empty" xml is returned whenever no $ {user} is provided. I didn't test how fs will react to that when it's looking up all the users for generating the acl list.. A way around that would be to only render your template when ${user} is set and otherwise render the not-found template, like this: <template name="default"> <xml-odbc-do name="check-event-header" if-name="user"> <xml-odbc-do name="break-to" value="directory-user"/> </xml-odbc-do> <xml-odbc-do name="break-to" value="not-found"/> </template> <template name="directory-user"> <xml-odbc-do name="query" on-empty-result-break-to="not-found" value="...etc"> ..rest of your template goes here.. </xml-odbc-do> </template> <template name="not-found"> etc... </template> --- Which comes close to how it's defined in the xml_odbc.conf.xml example, which solves it the other way around: ... <template name="default"> <xml-odbc-do name="break-to" value="${section}"/> </template> <template name="directory"> --> <xml-odbc-do name="check-event-header" if-name="purpose"> <!-- catches purpose gateways and network-list (any more?) --> <xml-odbc-do name="break-to" value="directory-${purpose}"/> </xml-odbc-do> <xml-odbc-do name="break-to" value="directory-user"/> </template> ... - First it checks what section is requested, which is nice but not really necessary in your case, since you only bind to directory. - Then it checks whether a purpose header is set (which was only the case for looking up acl's and gateways and NOT for regular user lookups last time I checked out the svn) - If a purpose header IS set, then it tries to render directory-$ {purpose}, which isn't specified, so it falls back to "not-found" which is what you want in this case - And as a last resort - this is where regular user lookups end up, it renders "directory-user" where you can put the template as specified above.. Hope that helps ? regards, Leon On Aug 27, 2009, at 3:53 PM, Juan Backson wrote:

Hi Leon,

Thanks for your help.

I have changed it according to your comment but I am still getting the looping error.

Would you please take a look see what else I did wrong?

Also, sip_user is an integer field, so I can't really use ''. Is there anyway to get around that?

<configuration name="xml_odbc.conf" description="XML ODBC Configuration">

<settings> <param name="binding" value="directory"/> <param name="odbc-dsn" value="class5_odbc:root:abcd"/> <param name="debug" value="true"/> <param name="keep-files-around" value="true"/> </settings>

<templates>

<template name="default"> <document type="freeswitch/xml"> <section name="directory"> <xml-odbc-do name="query" on-empty-result-break-to="not-found" value="SELECT enabled, sip_password FROM agent WHERE sip_user = $ {user} and enabled='t'"/> <domain name="${domain}"> <user id="${user}"> <params> <xml-odbc-do name="query" value="SELECT sip_password FROM agent WHERE sip_user = ${user}"> <param name="password" value="${sip_password}"/> </xml-odbc-do> </params> </user> </domain>

</section> </document> </template>

<template>

<document type="freeswitch/xml"> <section name="result"> <result status="not found"/> </section> </document> </template> </templates>

</configuration> _______________________________________________ FreeSWITCH-users mailing list FreeSWITCH-users@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-users UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users http://www.freeswitch.org