You have a good point.
On the other hand, it's just another random day in SVN trunk. =D
Most projects don't offer SVN trunk you can play spin-the-bottle with and land on something production-ready. But we are pretty close most of the time.
Here's my point of view:
That particular addition was a component to the core meant to be transparent.
If we did not find out the hard-way about this by adding it to trunk,
we would have found out the even-harder-way by having it imprinted in the actual release.
We try to keep the suffering to a minimum but we sometimes fall short.
At the risk of evisceration (but with the intention of helping avoid future brain dead build vs. idiot admin debates), I'd suggest that, when significant new bits are added to the switch core, they should default to being off and require a configuration option to turn them on. Such config options can be added to the default config; that way new installs will have the new functionality enabled by default, but those upgrading from an older install will need to enable them manually, reducing the risk of stuff breaking.--DaveSent: Monday, June 01, 2009 11:33 PMSubject: Re: [Freeswitch-users] Make current fails (build 13537)NO its not a bad one at all. Its switch_nat_init(); in switch_core.c since your network must be eating the packets its sending out to detect if you're behind nat or not... and not getting an ICMP unreachable like it should be getting... the joys of admins that block all ICMP like idiots. ICMP has many uses... and outright blocking it is stupid. (This is my assumption cuz its what makes sense in this case)So you're getting hit by the nice retry/timeout loop in the natpmp software we just added and possibly the upnp lib too.So for now edit switch_core.c and comment out switch_nat_init();I'm working my ass off to ensure that our users that do have to live in these insane nat scenarios can do so without much if any pain. Most of which uses SMB/Consumer grade routers which these two libs we added would allow us to poke holes and setup stuff and make it painless as possible.Soon you'll have an option in switch.conf.xml to turn it off.Please next time don't be so demanding and calling builds brain dead .. when in fact its trying to become more aware of its network config without much user input./b
On Jun 1, 2009, at 5:24 PM, Nik Middleton wrote:
Well I can only assume build 13537 is brain dead. Surely I shouldn’t have to edit a whole bunch of configs to get it working. FS now takes 3 minutes to start, with no indication as to what it’s looking for in the logs. That said, to date ‘make current’ has always worked well for me. Guess I was bound to hit a bad one eventually.Still, it’s very frustrating.
_______________________________________________
Freeswitch-users mailing list
Freeswitch-users@lists.freeswitch.org
http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
http://www.freeswitch.org
_______________________________________________
Freeswitch-users mailing list
Freeswitch-users@lists.freeswitch.org
http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
http://www.freeswitch.org