Not only that but it seems that it works differently on different builds and/or versions of git.  I only receive the first two messages about expected 'committer' line, but not the others, on my system.  I guess it's sometimes better to just sweep some very minor things under the rug than trying to gut out everything to fix it - especially when what we're talking about is simply a metadata "problem".

-- 
Yossi Neiman
On 03/10/2015 08:56 AM, Steven Ayre wrote:
I suspect it's performing some sanity checks that git commit does not. Which you could then argue is either a bug or feature in git.



On 10 March 2015 at 11:33, Ben Langfeld <ben@langfeld.co.uk> wrote:
git fsck complains about it.

➭ git fsck
Checking object directories: 100% (256/256), done.
error in commit 487128950df6ee433c131b5feaafe81ee86629f4: invalid format - expected 'committer' line
error in commit 8574988c3a378b4d5861ecaeb0e958657635703b: invalid format - expected 'committer' line
Checking objects: 100% (294760/294760), done.
dangling commit f62e8f0e250b35bbadb7367082127304f3e72e74
dangling commit dc844f983605a015bf600232864122b94a278e76

On 9 March 2015 at 23:21, Ken Rice <krice@freeswitch.org> wrote:
Git itself doesn’t say this is an invalid commit (we use stash/git and its perfectly fine with this)... There is a git-lint process that github uses and it rejects this commit


On 3/9/15, 6:57 PM, "Ben Langfeld" <ben@langfeld.co.uk> wrote:
I understand very well why rewriting history is undesirable and how git works. What I wonder is what process was used to convince git to create a commit which it would later say is invalid. As I said, I'm curious.

On 9 March 2015 at 20:12, Steven Ayre <steveayre@gmail.com> wrote:
Plus it's rather annoying to do so (rewrite history). The identifier of each commit is a hash computed from the content of the commit plus the metadata which includes the authors. Changing the author would change the identifier of the commit. That then changes the identifier of every commit afterwards. That then breaks every checkout / fork based off the tree as they no longer know where they are forked from. And since identifiers have all been rewritten we would no longer know what version you were running, or what version bug reports were reported against.

(that's why git makes it easy to amend your latest uncommitted commit message but rather difficult to edit any others)




On 9 March 2015 at 13:41, Michael Jerris <mike@jerris.com> wrote:
We are not rewriting history to fix this so it doesn't really matter who is right or wrong.

Mike
On Mar 9, 2015, at 9:13 AM, Ben Langfeld <ben@langfeld.co.uk> wrote:

I'm curious about this one... If git fsck complains about the issue, what is the justification for saying that Github is broken? How were these commits created with a format that git itself complains about?

On 9 March 2015 at 09:01,  <cmrienzo@gmail.com> wrote:
I switched to bitbucket.org <http://bitbucket.org/>  just for the FreeSWITCH repo to work around this. 


On Mar 8, 2015, at 20:34, Ken Rice <krice@freeswitch.org> wrote:
This is a known issue with github and will not be fixed 
On 3/8/15, 3:39 PM, "Podrigal, Aron" <aronp@guaranteedplus.com <http://aronp@guaranteedplus.com/> > wrote:
Hi,

I'm trying to push the freeswitch git repo to my github, but I get the following error


remote: error: object 487128950df6ee433c131b5feaafe81ee86629f4:invalid format - expected 'committer' line
remote: fatal: Error in object
channel_by_id: 0: bad id: channel free
Received window adjust for non-open channel 0.
error: pack-objects died of signal 13

This is caused by having multiple authors on a commit (which in general is not allowed by git) and github verifies the commits and rejects it.

here is the output of git fsck

Checking object directories: 100% (256/256), done.
error in commit 487128950df6ee433c131b5feaafe81ee86629f4: invalid format - expected 'committer' line
error in commit 8574988c3a378b4d5861ecaeb0e958657635703b: invalid format - expected 'committer' line
Checking objects: 100% (254227/254227), done.



_________________________________________________________________________
Professional FreeSWITCH Consulting Services:
consulting@freeswitch.org
http://www.freeswitchsolutions.com

Official FreeSWITCH Sites
http://www.freeswitch.org
http://confluence.freeswitch.org
http://www.cluecon.com

FreeSWITCH-users mailing list
FreeSWITCH-users@lists.freeswitch.org
http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
http://www.freeswitch.org

--
Ken
http://www.FreeSWITCH.org
http://www.ClueCon.com
http://www.OSTAG.org
irc.freenode.net #freeswitch
Twitter: @FreeSWITCH

_________________________________________________________________________
Professional FreeSWITCH Consulting Services:
consulting@freeswitch.org
http://www.freeswitchsolutions.com

Official FreeSWITCH Sites
http://www.freeswitch.org
http://confluence.freeswitch.org
http://www.cluecon.com

FreeSWITCH-users mailing list
FreeSWITCH-users@lists.freeswitch.org
http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
http://www.freeswitch.org


_________________________________________________________________________
Professional FreeSWITCH Consulting Services:
consulting@freeswitch.org
http://www.freeswitchsolutions.com

Official FreeSWITCH Sites
http://www.freeswitch.org
http://confluence.freeswitch.org
http://www.cluecon.com

FreeSWITCH-users mailing list
FreeSWITCH-users@lists.freeswitch.org
http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
http://www.freeswitch.org



_________________________________________________________________________
Professional FreeSWITCH Consulting Services: 
consulting@freeswitch.org
http://www.freeswitchsolutions.com

Official FreeSWITCH Sites
http://www.freeswitch.org
http://confluence.freeswitch.org
http://www.cluecon.com

FreeSWITCH-users mailing list
FreeSWITCH-users@lists.freeswitch.org
http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
http://www.freeswitch.org