Looks good, you might want to consider making the file name that is generated be an optional argument but it's not necessary just a suggestion.



On Tue, Jan 27, 2009 at 8:27 AM, Helmut Kuper <helmut.kuper@ewetel.de> wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,


again an update to my little project:

I enhanced mod_openzap and ozmod_isdn so that I'm able to start and stop
q931ToPcap generation in ozmod_isdn from FS's console. q931ToPcap itself
isn't implemented yet.

To give you an idea about the enhanced oz command - it's like this:

freeswitch@ippbx-prod-node0> oz
API CALL [oz()] output:
list || dump <span_id> [<chan_id>] || bounce <span_id> [<chan_id>] ||
q931_pcap <span_id> on|off
freeswitch@ippbx-prod-node0> oz q931_pcap
API CALL [oz(q931_pcap)] output:
- -ERR Usage: oz q931_pcap <span_id> on|off

freeswitch@ippbx-prod-node0> oz q931_pcap 0 on
API CALL [oz(q931_pcap 0 on)] output:
- -ERR invalid span

freeswitch@ippbx-prod-node0> oz q931_pcap 1 on
API CALL [oz(q931_pcap 1 on)] output:

2009-01-27 15:21:55 [INFO] mod_openzap.c:2172 oz_function() Starting
Q931-to-pcap
2009-01-27 15:21:55 [DEBUG] ozmod_isdn.c:1712 zap_isdn_configure_span()
Enabling Q931ToPcap
freeswitch@ippbx-prod-node0> oz q931_pcap 1 off
API CALL [oz(q931_pcap 1 off)] output:

2009-01-27 15:21:58 [INFO] mod_openzap.c:2178 oz_function() Stopping
Q931-to-pcap
2009-01-27 15:21:58 [DEBUG] ozmod_isdn.c:1717 zap_isdn_configure_span()
Disabling Q931ToPcap
freeswitch@ippbx-prod-node0>



As you can see, ozmod_isdn, where I will implement the code receives the
oz command option.

I appreciate your comments.


regards
helmut
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)

iEYEARECAAYFAkl/GeMACgkQ4tZeNddg3dzurACgszPDA573+uZjmY5TWXF9yj5F
Vz8An2FvK0FsDLr0JQaHFDETWnLoPSkD
=0hkL
-----END PGP SIGNATURE-----



--
Anthony Minessale II

FreeSWITCH http://www.freeswitch.org/
ClueCon http://www.cluecon.com/

AIM: anthm
MSN:anthony_minessale@hotmail.com
GTALK/JABBER/PAYPAL:anthony.minessale@gmail.com
IRC: irc.freenode.net #freeswitch

FreeSWITCH Developer Conference
sip:888@conference.freeswitch.org
iax:guest@conference.freeswitch.org/888
googletalk:conf+888@conference.freeswitch.org
pstn:213-799-1400