[master 1e6200b] FS-5074: --resolve support sqlite:// for DSNs

Please confirm this fixes the issue

Thanks
Mike

On Feb 5, 2013, at 2:33 PM, Steven Ayre <steveayre@gmail.com> wrote:

Ah I've spotted it. There's a bug in the code for detecting the old-style ODBC DSNs.

switch_core_sqldb.c:344 } else if ((!(i = strncasecmp(dsn, "odbc://", 7))) || strchr(dsn, ':')) {

This will match any DSN containing a ':' which obviously sqlite:// will. Therefore although the sqlite:// prefix is recognised and skipped over, that code path will never get reached.

The plain filename works because anything not odbc/pgsql is assumed to be a sqlite filename (switch_core_sqldb.c:366).

I've raised this in Jira: http://jira.freeswitch.org/browse/FS-5074

-Steve


On 5 February 2013 17:54, François Delawarde <fdelawarde@wirelessmundi.com> wrote:
There you go.

** My script test.lua is the following one liner:
local dbh = freeswitch.Dbh("sqlite:///tmp/test.db")


freeswitch@internal> lua test.lua
-ERR no reply

2013-02-05 18:50:47.230744 [ERR] switch_odbc.c:365 STATE: IM002 CODE 0 ERROR: [unixODBC][Driver Manager]Data source name not found, and no default driver specified

2013-02-05 18:50:47.230744 [CRIT] switch_core_sqldb.c:504 Failure to connect to PGSQL sqlite!
2013-02-05 18:50:47.230744 [ERR] freeswitch_lua.cpp:354 Connection failed.  DBH NOT Connected.




** Now if I change test.lua to:
local dbh = freeswitch.Dbh("/tmp/test.db")


freeswitch@internal> lua test.lua
-ERR no reply


No ERR or CRIT in this last one.


Cheers,
François.

On Tue, 2013-02-05 at 16:42 +0000, Steven Ayre wrote:
>         FAIL => "sqlite:///tmp/test.db" (this one should work)
>
>
> What error does this give?
>
>
>
> On 5 February 2013 16:31, François Delawarde
> <fdelawarde@wirelessmundi.com> wrote:
>         I'm on HEAD, but I must be doing something wrong, there is no
>         apparent
>         reason from the code.
>
>         On Tue, 2013-02-05 at 16:05 +0000, Steven Ayre wrote:
>         > Honestly, I only use ODBC... Maybe someone else can shed
>         some light?
>         >
>         > What version are you using?
>         >
>         > Steve
>         >
>         >
>         >
>         > On 5 Feb 2013, at 15:42, François Delawarde
>         <fdelawarde@wirelessmundi.com> wrote:
>         >
>         > > Steven, does "sqlite://" prefix work for you? Not sure if
>         it's a bug or
>         > > I'm doing something wrong. I tried the following from lua
>         dbh:
>         > >
>         > > FAIL => "sqlite:///tmp/test.db" (this one should work)
>         > > FAIL => "sqlite://tmp/test.db" (shouldn't work, but just
>         in case...)
>         > > OK   => "/tmp/test.db" (no prefix)
>         > >
>         > > François.
>         > >
>         > >
>         > > On Tue, 2013-02-05 at 12:55 +0000, Steven Ayre wrote:
>         > >> core: was an old prefix? I knew that change broke some
>         ODBC DSNs
>         > >> (names without username+password, eg when they're
>         specified in
>         > >> odbc.ini) but hadn't realised that had been broken too -
>         that needs
>         > >> documenting as well on the Wiki I guess...
>         > >> http://wiki.freeswitch.org/wiki/Release_Notes#odbc-dsn
>         > >>
>         > >>
>         > >> Just a thought for the developers, but perhaps modules
>         with odbc-dsn
>         > >> parameters should have this renamed to dsn or something
>         now since it's
>         > >> not odbc-specific at all any longer. Easy enough to
>         recognise both
>         > >> 'dsn' and 'odbc-dsn' names to remain backwards compatible
>         (which I've
>         > >> seen done with typos in config setting names in the past
>         > >> as precedent).
>         > >>
>         > >>
>         > >> -Steve
>         > >>
>         > >>
>         > >>
>         > >>
>         > >> On 5 February 2013 11:03, François Delawarde
>         > >> <fdelawarde@wirelessmundi.com> wrote:
>         > >>        The behavior recently changed from "core:<path>"
>         to
>         > >>        "sqlite://<path>".
>         > >>
>         > >>        Update: I just tested and it seems that
>         "sqlite://<path>"
>         > >>        doesn't work,
>         > >>        but as sqlite is the default, you can just omit
>         the prefix and
>         > >>        use
>         > >>        "<path>" to make it work.
>         > >>
>         > >>        François.
>         > >>
>         > >>
>         > >>        On Tue, 2013-02-05 at 10:37 +0000, Steven Ayre
>         wrote:
>         > >>> 'Failure to connect to PGSQL core' happens on ODBC
>         > >>        connections, that
>         > >>> seems to be a minor bug in the error message.
>         > >>>
>         > >>>
>         > >>> From the unixODBC error it's interpreting this as a ODBC
>         > >>        DSN. The
>         > >>> reason is the sqlite prefix is sqlite:// not core://
>         > >>> (see http://wiki.freeswitch.org/wiki/DSN). You also
>         don't
>         > >>        have enough
>         > >>> slashes.
>         > >>>
>         > >>>
>         > >>> Try:
>         > >>> local dbh =
>         > >>
>          freeswitch.Dbh("sqlite:///usr/local/temp/database.db");
>         > >>>
>         > >>>
>         > >>>
>         > >>> (note the 3 slashes - :// is standard URI format, the
>         3rd
>         > >>        indicates an
>         > >>> absolute path).
>         > >>>
>         > >>>
>         > >>> -Steve
>         > >>>
>         > >>>
>         > >>>
>         > >>>
>         > >>> On 5 February 2013 08:56, Carlo Dimaggio
>         > >>        <jaasmailing@gmail.com>
>         > >>> wrote:
>         > >>>        Hi all!
>         > >>>
>         > >>>        I have a lua script in which i have a statement
>         that
>         > >>        connects
>         > >>>        to a sqlite db:
>         > >>>
>         > >>>        local dbh =
>         > >>>
>          freeswitch.Dbh("core:/usr/local/temp/database.db");
>         > >>>
>         > >>>        but i receve in FS CLI this error that refers to
>         a
>         > >>        Pgsql
>         > >>>        instead of sqlite:
>         > >>>
>         > >>>        2013-02-05 09:40:10.379612 [ERR]
>         switch_odbc.c:365
>         > >>        STATE:
>         > >>>        IM002 CODE 0 ERROR: [unixODBC][Driver
>         Manager]Data
>         > >>        source name
>         > >>>        not found, and no default driver specified
>         > >>>        2013-02-05 09:40:10.379612 [CRIT]
>         > >>        switch_core_sqldb.c:504
>         > >>>        Failure to connect to PGSQL core!
>         > >>>        2013-02-05 09:40:10.379612 [ERR]
>         > >>        freeswitch_lua.cpp:354
>         > >>>        Connection failed.  DBH NOT Connected.
>         > >>>        2013-02-05 09:40:10.379612 [ERR]
>         > >>        freeswitch_lua.cpp:435 DBH
>         > >>>        NOT Connected.
>         > >>>
>         > >>>
>         > >>>        Can you help me?
>         > >>>
>         > >>>        Best regards,
>         > >>
>          _________________________________________________________________________
>         > >>>        Professional FreeSWITCH Consulting Services:
>         > >>>        consulting@freeswitch.org
>         > >>>        http://www.freeswitchsolutions.com
>         > >>>
>         > >>>        FreeSWITCH-powered IP PBX: The CudaTel
>         Communication
>         > >>        Server
>         > >>>        http://www.cudatel.com
>         > >>>
>         > >>>        Official FreeSWITCH Sites
>         > >>>        http://www.freeswitch.org
>         > >>>        http://wiki.freeswitch.org
>         > >>>        http://www.cluecon.com
>         > >>>
>         > >>>        FreeSWITCH-users mailing list
>         > >>>        FreeSWITCH-users@lists.freeswitch.org
>         > >>
>          http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
>         > >>
>          UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
>         > >>>        http://www.freeswitch.org
>         > >>
>          _________________________________________________________________________
>         > >>> Professional FreeSWITCH Consulting Services:
>         > >>> consulting@freeswitch.org
>         > >>> http://www.freeswitchsolutions.com
>         > >>>
>         > >>> FreeSWITCH-powered IP PBX: The CudaTel Communication
>         Server
>         > >>> http://www.cudatel.com
>         > >>>
>         > >>> Official FreeSWITCH Sites
>         > >>> http://www.freeswitch.org
>         > >>> http://wiki.freeswitch.org
>         > >>> http://www.cluecon.com
>         > >>>
>         > >>> FreeSWITCH-users mailing list
>         > >>> FreeSWITCH-users@lists.freeswitch.org
>         > >>
>          http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
>         > >>
>          UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
>         > >>> http://www.freeswitch.org
>         > >>
>         > >>
>         > >>
>         > >>
>          _________________________________________________________________________
>         > >>        Professional FreeSWITCH Consulting Services:
>         > >>        consulting@freeswitch.org
>         > >>        http://www.freeswitchsolutions.com
>         > >>
>         > >>        FreeSWITCH-powered IP PBX: The CudaTel
>         Communication Server
>         > >>        http://www.cudatel.com
>         > >>
>         > >>        Official FreeSWITCH Sites
>         > >>        http://www.freeswitch.org
>         > >>        http://wiki.freeswitch.org
>         > >>        http://www.cluecon.com
>         > >>
>         > >>        FreeSWITCH-users mailing list
>         > >>        FreeSWITCH-users@lists.freeswitch.org
>         > >>
>          http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
>         > >>
>          UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
>         > >>        http://www.freeswitch.org
>         > >>
>         > >>
>         > >>
>         > >>
>         _________________________________________________________________________
>         > >> Professional FreeSWITCH Consulting Services:
>         > >> consulting@freeswitch.org
>         > >> http://www.freeswitchsolutions.com
>         > >>
>         > >> FreeSWITCH-powered IP PBX: The CudaTel Communication
>         Server
>         > >> http://www.cudatel.com
>         > >>
>         > >> Official FreeSWITCH Sites
>         > >> http://www.freeswitch.org
>         > >> http://wiki.freeswitch.org
>         > >> http://www.cluecon.com
>         > >>
>         > >> FreeSWITCH-users mailing list
>         > >> FreeSWITCH-users@lists.freeswitch.org
>         > >>
>         http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
>         > >>
>         UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
>         > >> http://www.freeswitch.org
>         > >
>         > >
>         > >
>         > >
>         _________________________________________________________________________
>         > > Professional FreeSWITCH Consulting Services:
>         > > consulting@freeswitch.org
>         > > http://www.freeswitchsolutions.com
>         > >
>         > > FreeSWITCH-powered IP PBX: The CudaTel Communication
>         Server
>         > > http://www.cudatel.com
>         > >
>         > > Official FreeSWITCH Sites
>         > > http://www.freeswitch.org
>         > > http://wiki.freeswitch.org
>         > > http://www.cluecon.com
>         > >
>         > > FreeSWITCH-users mailing list
>         > > FreeSWITCH-users@lists.freeswitch.org
>         > >
>         http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
>         > >
>         UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
>         > > http://www.freeswitch.org
>         >
>         >
>         _________________________________________________________________________
>         > Professional FreeSWITCH Consulting Services:
>         > consulting@freeswitch.org
>         > http://www.freeswitchsolutions.com
>         >
>         > FreeSWITCH-powered IP PBX: The CudaTel Communication Server
>         > http://www.cudatel.com
>         >
>         > Official FreeSWITCH Sites
>         > http://www.freeswitch.org
>         > http://wiki.freeswitch.org
>         > http://www.cluecon.com
>         >
>         > FreeSWITCH-users mailing list
>         > FreeSWITCH-users@lists.freeswitch.org
>         >
>         http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
>         >
>         UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
>         > http://www.freeswitch.org
>
>
>
>         _________________________________________________________________________
>         Professional FreeSWITCH Consulting Services:
>         consulting@freeswitch.org
>         http://www.freeswitchsolutions.com
>
>         FreeSWITCH-powered IP PBX: The CudaTel Communication Server
>         http://www.cudatel.com
>
>         Official FreeSWITCH Sites
>         http://www.freeswitch.org
>         http://wiki.freeswitch.org
>         http://www.cluecon.com
>
>         FreeSWITCH-users mailing list
>         FreeSWITCH-users@lists.freeswitch.org
>         http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
>         UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
>         http://www.freeswitch.org
>
>
>
> _________________________________________________________________________
> Professional FreeSWITCH Consulting Services:
> consulting@freeswitch.org
> http://www.freeswitchsolutions.com
>
> FreeSWITCH-powered IP PBX: The CudaTel Communication Server
> http://www.cudatel.com
>
> Official FreeSWITCH Sites
> http://www.freeswitch.org
> http://wiki.freeswitch.org
> http://www.cluecon.com
>
> FreeSWITCH-users mailing list
> FreeSWITCH-users@lists.freeswitch.org
> http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
> UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
> http://www.freeswitch.org



_________________________________________________________________________
Professional FreeSWITCH Consulting Services:
consulting@freeswitch.org
http://www.freeswitchsolutions.com

FreeSWITCH-powered IP PBX: The CudaTel Communication Server
http://www.cudatel.com

Official FreeSWITCH Sites
http://www.freeswitch.org
http://wiki.freeswitch.org
http://www.cluecon.com

FreeSWITCH-users mailing list
FreeSWITCH-users@lists.freeswitch.org
http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
http://www.freeswitch.org

_________________________________________________________________________
Professional FreeSWITCH Consulting Services:
consulting@freeswitch.org
http://www.freeswitchsolutions.com

FreeSWITCH-powered IP PBX: The CudaTel Communication Server
http://www.cudatel.com

Official FreeSWITCH Sites
http://www.freeswitch.org
http://wiki.freeswitch.org
http://www.cluecon.com

FreeSWITCH-users mailing list
FreeSWITCH-users@lists.freeswitch.org
http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
http://www.freeswitch.org