Revision
16811
Author
cseket
Date
2010-02-25 05:51:43 -0600 (Thu, 25 Feb 2010)

Log Message

free memory on shutdown

Modified Paths

Diff

Modified: freeswitch/branches/cseket/src/mod/event_handlers/mod_json_cdr/mod_json_cdr.c (16810 => 16811)


--- freeswitch/branches/cseket/src/mod/event_handlers/mod_json_cdr/mod_json_cdr.c	2010-02-25 10:29:19 UTC (rev 16810)
+++ freeswitch/branches/cseket/src/mod/event_handlers/mod_json_cdr/mod_json_cdr.c	2010-02-25 11:51:43 UTC (rev 16811)
@@ -69,6 +69,7 @@
 	int rotate;
 	int auth_scheme;
 	switch_memory_pool_t *pool;
+	switch_event_node_t *node;
 } globals;
 
 SWITCH_MODULE_LOAD_FUNCTION(mod_json_cdr_load);
@@ -881,12 +882,13 @@
 
 	*module_interface = switch_loadable_module_create_module_interface(pool, modname);
 
-	if (switch_event_bind(modname, SWITCH_EVENT_TRAP, SWITCH_EVENT_SUBCLASS_ANY, event_handler, NULL) != SWITCH_STATUS_SUCCESS) {
+	memset(&globals, 0, sizeof(globals));
+
+	if (switch_event_bind_removable(modname, SWITCH_EVENT_TRAP, SWITCH_EVENT_SUBCLASS_ANY, event_handler, NULL, &globals.node) != SWITCH_STATUS_SUCCESS) {
 		switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "Couldn't bind!\n");
 		return SWITCH_STATUS_GENERR;
 	}
 
-	memset(&globals, 0, sizeof(globals));
 	globals.log_http_and_disk = 0;
 	globals.log_b = 1;
 	globals.disable100continue = 0;
@@ -936,22 +938,22 @@
 				globals.rotate = switch_true(val);
 			} else if (!strcasecmp(var, "log-dir")) {
 				if (zstr(val)) {
-					globals.base_log_dir = switch_mprintf("%s%sjson_cdr", SWITCH_GLOBAL_dirs.log_dir, SWITCH_PATH_SEPARATOR);
+					globals.base_log_dir = switch_core_sprintf(globals.pool, "%s%sjson_cdr", SWITCH_GLOBAL_dirs.log_dir, SWITCH_PATH_SEPARATOR);
 				} else {
 					if (switch_is_file_path(val)) {
 						globals.base_log_dir = switch_core_strdup(globals.pool, val);
 					} else {
-						globals.base_log_dir = switch_mprintf("%s%s%s", SWITCH_GLOBAL_dirs.log_dir, SWITCH_PATH_SEPARATOR, val);
+						globals.base_log_dir = switch_core_sprintf(globals.pool, "%s%s%s", SWITCH_GLOBAL_dirs.log_dir, SWITCH_PATH_SEPARATOR, val);
 					}
 				}
 			} else if (!strcasecmp(var, "err-log-dir")) {
 				if (zstr(val)) {
-					globals.base_err_log_dir = switch_mprintf("%s%sjson_cdr", SWITCH_GLOBAL_dirs.log_dir, SWITCH_PATH_SEPARATOR);
+					globals.base_err_log_dir = switch_core_sprintf(globals.pool, "%s%sjson_cdr", SWITCH_GLOBAL_dirs.log_dir, SWITCH_PATH_SEPARATOR);
 				} else {
 					if (switch_is_file_path(val)) {
 						globals.base_err_log_dir = switch_core_strdup(globals.pool, val);
 					} else {
-						globals.base_err_log_dir = switch_mprintf("%s%s%s", SWITCH_GLOBAL_dirs.log_dir, SWITCH_PATH_SEPARATOR, val);
+						globals.base_err_log_dir = switch_core_sprintf(globals.pool, "%s%s%s", SWITCH_GLOBAL_dirs.log_dir, SWITCH_PATH_SEPARATOR, val);
 					}
 				}
 			} else if (!strcasecmp(var, "enable-cacert-check") && switch_true(val)) {
@@ -1021,7 +1023,14 @@
 
 	globals.shutdown = 1;
 
+	switch_safe_free(globals.log_dir);
+	switch_safe_free(globals.err_log_dir);
+
+	switch_event_unbind(&globals.node);
 	switch_core_remove_state_handler(&state_handlers);
+
+	switch_thread_rwlock_destroy(globals.log_path_lock);
+
 	return SWITCH_STATUS_SUCCESS;
 }