September 2008 - Freeswitch-trunk - FreeSWITCH Mailing Lists

[commit] r9507 - freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua
by Freeswitch SVN 10 Sep '08

10 Sep '08

Author: mikej Date: Wed Sep 10 12:21:10 2008 New Revision: 9507 Modified: freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/check_session.c Log: Wed Sep 10 09:34:00 EDT 2008 Pekka Pessi <first.last(a)nokia.com> * check_session.c: added tests for PRACK and preconditions Modified: freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/check_session.c ============================================================================== --- freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/check_session.c (original) +++ freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/check_session.c Wed Sep 10 12:21:10 2008 @@ -182,26 +182,26 @@ return s2_wait_for_request(SIP_METHOD_INVITE); } +static uint32_t s2_rseq; + static struct message * respond_with_100rel(struct message *invite, struct dialog *d, - int sdp, + int with_sdp, int status, char const *phrase, tag_type_t tag, tag_value_t value, ...) { - struct message *prack; ta_list ta; - static uint32_t rseq; sip_rseq_t rs[1]; assert(100 < status && status < 200); sip_rseq_init(rs); - rs->rs_response = ++rseq; + rs->rs_response = ++s2_rseq; ta_start(ta, tag, value); - if (sdp) { + if (with_sdp) { respond_with_sdp( invite, dialog, status, phrase, SIPTAG_REQUIRE_STR("100rel"), @@ -219,11 +219,7 @@ fail_unless(s2_check_event(nua_r_invite, status)); - prack = s2_wait_for_request(SIP_METHOD_PRACK); - /* Assumes auto-prack, so there is no offer in prack */ - s2_respond_to(prack, dialog, SIP_200_OK, TAG_END()); - - return prack; + return s2_wait_for_request(SIP_METHOD_PRACK); } static void @@ -262,7 +258,6 @@ struct event *invite; struct message *response; nua_handle_t *nh; - sip_cseq_t cseq[1]; soa_generate_offer(soa, 1, NULL); @@ -276,11 +271,6 @@ nh = invite->nh; fail_if(!nh); - sip_cseq_init(cseq); - cseq->cs_method = sip_method_ack; - cseq->cs_method_name = "ACK"; - cseq->cs_seq = sip_object(invite->data->e_msg)->sip_cseq->cs_seq; - s2_free_event(invite); response = s2_wait_for_response(100, SIP_METHOD_INVITE); @@ -307,8 +297,7 @@ s2_update_dialog(dialog, response); s2_free_message(response); - fail_if(s2_request_to(dialog, SIP_METHOD_ACK, NULL, - SIPTAG_CSEQ(cseq), TAG_END())); + fail_if(s2_request_to(dialog, SIP_METHOD_ACK, NULL, TAG_END())); fail_unless(s2_check_event(nua_i_ack, 200)); fail_unless(s2_check_callstate(nua_callstate_ready)); @@ -502,7 +491,6 @@ struct message *bye; struct event *invite; struct message *response; - sip_cseq_t cseq[1]; s2_case("2.1.6", "Basic call", "NUA received INVITE, " @@ -519,11 +507,6 @@ nh = invite->nh; fail_if(!nh); - sip_cseq_init(cseq); - cseq->cs_method = sip_method_ack; - cseq->cs_method_name = "ACK"; - cseq->cs_seq = sip_object(invite->data->e_msg)->sip_cseq->cs_seq; - s2_free_event(invite); response = s2_wait_for_response(100, SIP_METHOD_INVITE); @@ -552,8 +535,7 @@ s2_update_dialog(dialog, response); s2_free_message(response); - fail_if(s2_request_to(dialog, SIP_METHOD_ACK, NULL, - SIPTAG_CSEQ(cseq), TAG_END())); + fail_if(s2_request_to(dialog, SIP_METHOD_ACK, NULL, TAG_END())); fail_unless(s2_check_event(nua_i_ack, 200)); fail_unless(s2_check_callstate(nua_callstate_ready)); @@ -868,10 +850,11 @@ /* ====================================================================== */ /* 2.4 - 100rel */ -START_TEST(call_with_prack_by_nua) +START_TEST(call_2_4_1) { nua_handle_t *nh; struct message *invite, *prack; + int with_sdp; s2_case("2.4.1", "Call with 100rel", "NUA sends INVITE, " @@ -886,16 +869,18 @@ TAG_END()); process_offer(invite); - prack = respond_with_100rel(invite, dialog, 1, + prack = respond_with_100rel(invite, dialog, with_sdp = 1, SIP_183_SESSION_PROGRESS, TAG_END()); + s2_respond_to(prack, dialog, SIP_200_OK, TAG_END()); s2_free_message(prack), prack = NULL; fail_unless(s2_check_callstate(nua_callstate_proceeding)); fail_unless(s2_check_event(nua_r_prack, 200)); - prack = respond_with_100rel(invite, dialog, 0, + prack = respond_with_100rel(invite, dialog, with_sdp = 0, SIP_180_RINGING, TAG_END()); + s2_respond_to(prack, dialog, SIP_200_OK, TAG_END()); s2_free_message(prack), prack = NULL; fail_unless(s2_check_callstate(nua_callstate_proceeding)); fail_unless(s2_check_event(nua_r_prack, 200)); @@ -912,12 +897,13 @@ } END_TEST -START_TEST(call_with_prack_sans_soa) +START_TEST(call_2_4_2) { nua_handle_t *nh; struct message *invite, *prack; + int with_sdp; - s2_case("2.4.1", "Call with 100rel", + s2_case("2.4.2", "Call with 100rel", "NUA sends INVITE, " "receives 183, sends PRACK, receives 200 for it, " "receives 180, sends PRACK, receives 200 for it, " @@ -937,16 +923,18 @@ "m=audio 5004 RTP/AVP 0 8" CRLF), TAG_END()); - prack = respond_with_100rel(invite, dialog, 0, + prack = respond_with_100rel(invite, dialog, with_sdp = 0, SIP_183_SESSION_PROGRESS, TAG_END()); + s2_respond_to(prack, dialog, SIP_200_OK, TAG_END()); s2_free_message(prack), prack = NULL; fail_unless(s2_check_callstate(nua_callstate_proceeding)); fail_unless(s2_check_event(nua_r_prack, 200)); - prack = respond_with_100rel(invite, dialog, 0, + prack = respond_with_100rel(invite, dialog, with_sdp = 0, SIP_180_RINGING, TAG_END()); + s2_respond_to(prack, dialog, SIP_200_OK, TAG_END()); s2_free_message(prack), prack = NULL; fail_unless(s2_check_callstate(nua_callstate_proceeding)); fail_unless(s2_check_event(nua_r_prack, 200)); @@ -968,8 +956,241 @@ TCase *tc = tcase_create("2.4 - INVITE with 100rel"); tcase_add_checked_fixture(tc, call_setup, call_teardown); { - tcase_add_test(tc, call_with_prack_by_nua); - tcase_add_test(tc, call_with_prack_sans_soa); + tcase_add_test(tc, call_2_4_1); + tcase_add_test(tc, call_2_4_2); + } + return tc; +} + +/* ====================================================================== */ +/* 2.5 - Call with preconditions */ + +START_TEST(call_2_5_1) +{ + nua_handle_t *nh; + struct message *invite, *prack, *update; + int with_sdp; + + s2_case("2.5.1", "Call with preconditions", + "NUA sends INVITE, " + "receives 183, sends PRACK, receives 200 for it, " + "sends UPDATE, receives 200 for it, " + "receives 180, sends PRACK, receives 200 for it, " + "receives 200, send ACK."); + + nh = nua_handle(nua, NULL, SIPTAG_TO(s2->local), TAG_END()); + + invite = invite_sent_by_nua( + nh, SOATAG_USER_SDP_STR("m=audio 5004 RTP/AVP 0 8"), + SIPTAG_REQUIRE_STR("precondition"), + TAG_END()); + process_offer(invite); + + prack = respond_with_100rel(invite, dialog, with_sdp = 1, + SIP_183_SESSION_PROGRESS, + TAG_END()); + fail_unless(s2_check_callstate(nua_callstate_proceeding)); + process_offer(prack); + respond_with_sdp( + prack, dialog, SIP_200_OK, + SIPTAG_REQUIRE_STR("100rel"), + TAG_END()); + s2_free_message(prack), prack = NULL; + fail_unless(s2_check_event(nua_r_prack, 200)); + fail_unless(s2_check_callstate(nua_callstate_proceeding)); + + update = s2_wait_for_request(SIP_METHOD_UPDATE); + /* UPDATE sent by stack, stack sends event for it */ + fail_unless(s2_check_callstate(nua_callstate_proceeding)); + + process_offer(update); + respond_with_sdp( + update, dialog, SIP_200_OK, + TAG_END()); + s2_free_message(update), update = NULL; + + fail_unless(s2_check_event(nua_r_update, 200)); + fail_unless(s2_check_callstate(nua_callstate_proceeding)); + + prack = respond_with_100rel(invite, dialog, with_sdp = 0, + SIP_180_RINGING, + TAG_END()); + s2_respond_to(prack, dialog, SIP_200_OK, TAG_END()); + s2_free_message(prack), prack = NULL; + fail_unless(s2_check_callstate(nua_callstate_proceeding)); + fail_unless(s2_check_event(nua_r_prack, 200)); + + s2_respond_to(invite, dialog, SIP_200_OK, TAG_END()); + s2_free_message(invite); + fail_unless(s2_check_event(nua_r_invite, 200)); + fail_unless(s2_check_callstate(nua_callstate_ready)); + fail_unless(s2_check_request(SIP_METHOD_ACK)); + + bye_to_nua(nh, TAG_END()); + + nua_handle_destroy(nh); +} +END_TEST + +START_TEST(call_2_5_2) +{ + nua_handle_t *nh; + struct message *invite, *prack, *update; + sip_rseq_t rs[1]; + sip_rack_t rack[1]; + + s2_case("2.5.2", "Call with preconditions - send 200 w/ ongoing PRACK ", + "NUA sends INVITE, " + "receives 183, sends PRACK, " + "receives 200 to INVITE, " + "receives 200 to PRACK, " + "sends ACK, " + "sends UPDATE, " + "receives 200 to UPDATE."); + + nh = nua_handle(nua, NULL, SIPTAG_TO(s2->local), TAG_END()); + + invite = invite_sent_by_nua( + nh, + SOATAG_USER_SDP_STR("m=audio 5004 RTP/AVP 0 8"), + SIPTAG_REQUIRE_STR("precondition"), + NUTAG_APPL_METHOD("PRACK"), + TAG_END()); + process_offer(invite); + + sip_rseq_init(rs)->rs_response = ++s2_rseq; + respond_with_sdp( + invite, dialog, SIP_183_SESSION_PROGRESS, + SIPTAG_REQUIRE_STR("100rel"), + SIPTAG_RSEQ(rs), + TAG_END()); + fail_unless(s2_check_event(nua_r_invite, 183)); + fail_unless(s2_check_callstate(nua_callstate_proceeding)); + + sip_rack_init(rack)->ra_response = s2_rseq; + rack->ra_cseq = invite->sip->sip_cseq->cs_seq; + rack->ra_method = invite->sip->sip_cseq->cs_method; + rack->ra_method_name = invite->sip->sip_cseq->cs_method_name; + + nua_prack(nh, SIPTAG_RACK(rack), TAG_END()); + prack = s2_wait_for_request(SIP_METHOD_PRACK); + process_offer(prack); + + s2_respond_to(invite, dialog, SIP_200_OK, TAG_END()); + s2_free_message(invite); + fail_unless(s2_check_event(nua_r_invite, 200)); + fail_unless(s2_check_callstate(nua_callstate_completing)); + + respond_with_sdp( + prack, dialog, SIP_200_OK, + TAG_END()); + s2_free_message(prack), prack = NULL; + fail_unless(s2_check_event(nua_r_prack, 200)); + fail_unless(s2_check_callstate(nua_callstate_ready)); + + fail_unless(s2_check_request(SIP_METHOD_ACK)); + + update = s2_wait_for_request(SIP_METHOD_UPDATE); + /* UPDATE sent by stack, stack sends event for it */ + fail_unless(s2_check_callstate(nua_callstate_calling)); + + process_offer(update); + respond_with_sdp( + update, dialog, SIP_200_OK, + TAG_END()); + s2_free_message(update), update = NULL; + + fail_unless(s2_check_event(nua_r_update, 200)); + fail_unless(s2_check_callstate(nua_callstate_ready)); + + bye_to_nua(nh, TAG_END()); + + nua_handle_destroy(nh); +} +END_TEST + +START_TEST(call_2_5_3) +{ + nua_handle_t *nh; + struct message *invite, *prack, *update; + sip_rseq_t rs[1]; + sip_rack_t rack[1]; + + s2_case("2.5.3", "Call with preconditions - send 200 w/ ongoing UPDATE ", + "NUA sends INVITE, " + "receives 183, sends PRACK, receives 200 to PRACK, " + "sends UPDATE, " + "receives 200 to INVITE, " + "receives 200 to UPDATE, " + "sends ACK."); + + nh = nua_handle(nua, NULL, SIPTAG_TO(s2->local), TAG_END()); + + invite = invite_sent_by_nua( + nh, + SOATAG_USER_SDP_STR("m=audio 5004 RTP/AVP 0 8"), + SIPTAG_REQUIRE_STR("precondition"), + NUTAG_APPL_METHOD("PRACK"), + TAG_END()); + process_offer(invite); + + sip_rseq_init(rs)->rs_response = ++s2_rseq; + respond_with_sdp( + invite, dialog, SIP_183_SESSION_PROGRESS, + SIPTAG_REQUIRE_STR("100rel"), + SIPTAG_RSEQ(rs), + TAG_END()); + fail_unless(s2_check_event(nua_r_invite, 183)); + fail_unless(s2_check_callstate(nua_callstate_proceeding)); + + sip_rack_init(rack)->ra_response = s2_rseq; + rack->ra_cseq = invite->sip->sip_cseq->cs_seq; + rack->ra_method = invite->sip->sip_cseq->cs_method; + rack->ra_method_name = invite->sip->sip_cseq->cs_method_name; + + nua_prack(nh, SIPTAG_RACK(rack), TAG_END()); + prack = s2_wait_for_request(SIP_METHOD_PRACK); + process_offer(prack); + respond_with_sdp( + prack, dialog, SIP_200_OK, + TAG_END()); + s2_free_message(prack), prack = NULL; + fail_unless(s2_check_event(nua_r_prack, 200)); + fail_unless(s2_check_callstate(nua_callstate_proceeding)); + + update = s2_wait_for_request(SIP_METHOD_UPDATE); + /* UPDATE sent by stack, stack sends event for it */ + fail_unless(s2_check_callstate(nua_callstate_proceeding)); + + s2_respond_to(invite, dialog, SIP_200_OK, TAG_END()); + s2_free_message(invite); + fail_unless(s2_check_event(nua_r_invite, 200)); + fail_unless(s2_check_callstate(nua_callstate_completing)); + + process_offer(update); + respond_with_sdp( + update, dialog, SIP_200_OK, + TAG_END()); + s2_free_message(update), update = NULL; + + fail_unless(s2_check_event(nua_r_update, 200)); + fail_unless(s2_check_callstate(nua_callstate_ready)); + fail_unless(s2_check_request(SIP_METHOD_ACK)); + + bye_to_nua(nh, TAG_END()); + + nua_handle_destroy(nh); +} +END_TEST + +TCase *invite_precondition_tcase(void) +{ + TCase *tc = tcase_create("2.5 - Call with preconditions"); + tcase_add_checked_fixture(tc, call_setup, call_teardown); + { + tcase_add_test(tc, call_2_5_1); + tcase_add_test(tc, call_2_5_2); + tcase_add_test(tc, call_2_5_3); } return tc; } @@ -1717,6 +1938,7 @@ suite_add_tcase(suite, cancel_tcase()); suite_add_tcase(suite, session_timer_tcase()); suite_add_tcase(suite, invite_100rel_tcase()); + suite_add_tcase(suite, invite_precondition_tcase()); suite_add_tcase(suite, invite_error_tcase()); suite_add_tcase(suite, termination_tcase());

1 0

[commit] r9506 - freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua
by Freeswitch SVN 10 Sep '08

10 Sep '08

Author: mikej Date: Wed Sep 10 12:20:55 2008 New Revision: 9506 Modified: freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/test_s2.c Log: Wed Sep 10 09:29:58 EDT 2008 Pekka Pessi <first.last(a)nokia.com> * test_s2.c: turn on s2 tport log if environment variable S2_TPORT_LOG is set Modified: freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/test_s2.c ============================================================================== --- freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/test_s2.c (original) +++ freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/test_s2.c Wed Sep 10 12:20:55 2008 @@ -785,7 +785,7 @@ void s2_case(char const *number, char const *title, - char const *desciption) + char const *description) { _s2case = number; } @@ -917,7 +917,9 @@ ta_start(ta, tag, value); if (s2->master == NULL) { - s2->master = tport_tcreate(s2, s2_stack, s2->root, ta_tags(ta)); + s2->master = tport_tcreate(s2, s2_stack, s2->root, + TPTAG_LOG(getenv("S2_TPORT_LOG") != NULL), + ta_tags(ta)); if (s2->master == NULL) { assert(s2->master); @@ -1488,7 +1490,7 @@ s2_setup_dns(); s2_setup_logs(0); - s2_setup_tport(NULL, TPTAG_LOG(0), TAG_END()); + s2_setup_tport(NULL, TAG_END()); assert(s2->contact); /* enable/disable multithreading */

1 0

[commit] r9505 - freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua
by Freeswitch SVN 10 Sep '08

10 Sep '08

Author: mikej Date: Wed Sep 10 12:20:25 2008 New Revision: 9505 Modified: freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/test_s2.c Log: Wed Sep 10 09:29:17 EDT 2008 Pekka Pessi <first.last(a)nokia.com> * test_s2.c: allow user-specified VIA in requests from s2 Modified: freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/test_s2.c ============================================================================== --- freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/test_s2.c (original) +++ freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/test_s2.c Wed Sep 10 12:20:25 2008 @@ -230,6 +230,8 @@ *prev = e, e->prev = prev; } +/* ---------------------------------------------------------------------- */ +/* SIP messages sent by nua */ struct message * s2_remove_message(struct message *m) @@ -515,6 +517,7 @@ sip_content_length_t l[1]; tp_name_t tpn[1]; tp_magic_t *magic; + int user_via = 0; ta_start(ta, tag, value); tags = ta_args(ta); @@ -598,7 +601,7 @@ sip_cseq_init(cseq); cseq->cs_method = method; cseq->cs_method_name = name; - + if (d->invite && (method == sip_method_ack || method == sip_method_cancel)) { cseq->cs_seq = sip_object(d->invite)->sip_cseq->cs_seq; } @@ -606,7 +609,10 @@ cseq->cs_seq = ++d->lseq; } - if (d->invite && method == sip_method_cancel) { + if (sip->sip_via) { + user_via = 1; + } + else if (d->invite && method == sip_method_cancel) { *via = *sip_object(d->invite)->sip_via; } else { @@ -626,7 +632,7 @@ TAG_IF(!sip->sip_to, SIPTAG_TO(d->remote)), TAG_IF(!sip->sip_call_id, SIPTAG_CALL_ID(d->call_id)), TAG_IF(!sip->sip_cseq, SIPTAG_CSEQ(cseq)), - SIPTAG_VIA(via), + TAG_IF(!user_via, SIPTAG_VIA(via)), TAG_IF(!sip->sip_content_length, SIPTAG_CONTENT_LENGTH(l)), TAG_IF(!sip->sip_separator, SIPTAG_SEPARATOR_STR("\r\n")), TAG_END());

1 0

[commit] r9504 - in freeswitch/trunk/libs/sofia-sip: . libsofia-sip-ua/nua
by Freeswitch SVN 10 Sep '08

10 Sep '08

Author: mikej Date: Wed Sep 10 12:20:05 2008 New Revision: 9504 Modified: freeswitch/trunk/libs/sofia-sip/.update freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/nua_session.c freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/nua_stack.c Log: Wed Sep 10 09:05:24 EDT 2008 Pekka Pessi <first.last(a)nokia.com> * nua_session.c: fixed client request reference counting in nua_session_usage_remove() Bug reported by Della Betta Filippo. Modified: freeswitch/trunk/libs/sofia-sip/.update ============================================================================== --- freeswitch/trunk/libs/sofia-sip/.update (original) +++ freeswitch/trunk/libs/sofia-sip/.update Wed Sep 10 12:20:05 2008 @@ -1 +1 @@ -Wed Sep 10 12:19:39 EDT 2008 +Wed Sep 10 12:19:57 EDT 2008 Modified: freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/nua_session.c ============================================================================== --- freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/nua_session.c (original) +++ freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/nua_session.c Wed Sep 10 12:20:05 2008 @@ -258,11 +258,12 @@ if (cr == cr0) continue; + nua_client_request_ref(cr); + if (nua_invite_client_should_ack(cr)) { ss->ss_reporting = 1; nua_invite_client_ack(cr, NULL); ss->ss_reporting = 0; - nua_client_request_clean(cr); } if (cr == du->du_cr && cr->cr_orq) @@ -278,6 +279,8 @@ nua_client_request_remove(cr); + nua_client_request_unref(cr); + cr_next = ds->ds_cr; } Modified: freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/nua_stack.c ============================================================================== --- freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/nua_stack.c (original) +++ freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/nua_stack.c Wed Sep 10 12:20:05 2008 @@ -2154,16 +2154,23 @@ int nua_client_request_remove(nua_client_request_t *cr) { - if (cr->cr_prev) + int retval = 0; + int in_queue = cr->cr_prev != NULL; + + if (in_queue) { if ((*cr->cr_prev = cr->cr_next)) cr->cr_next->cr_prev = cr->cr_prev; + } cr->cr_prev = NULL, cr->cr_next = NULL; if (cr->cr_timer) { su_timer_destroy(cr->cr_timer), cr->cr_timer = NULL; - nua_client_request_unref(cr); + retval = nua_client_request_unref(cr); } + if (!in_queue) + return retval; + return nua_client_request_unref(cr); }

1 0

[commit] r9503 - in freeswitch/trunk/libs/sofia-sip: . libsofia-sip-ua/sdp libsofia-sip-ua/sdp/sofia-sip
by Freeswitch SVN 10 Sep '08

10 Sep '08

Author: mikej Date: Wed Sep 10 12:19:45 2008 New Revision: 9503 Modified: freeswitch/trunk/libs/sofia-sip/.update freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sdp/sdp.c freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sdp/sofia-sip/sdp.h Log: Wed Sep 3 14:37:06 EDT 2008 Pekka Pessi <first.last(a)nokia.com> * sdp: updated documentation Modified: freeswitch/trunk/libs/sofia-sip/.update ============================================================================== --- freeswitch/trunk/libs/sofia-sip/.update (original) +++ freeswitch/trunk/libs/sofia-sip/.update Wed Sep 10 12:19:45 2008 @@ -1 +1 @@ -Wed Sep 3 14:31:22 EDT 2008 +Wed Sep 10 12:19:39 EDT 2008 Modified: freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sdp/sdp.c ============================================================================== --- freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sdp/sdp.c (original) +++ freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sdp/sdp.c Wed Sep 10 12:19:45 2008 @@ -174,11 +174,14 @@ /**Duplicate an SDP origin description. * * The function sdp_origin_dup() duplicates (deeply copies) an SDP origin - * description�@a o allocating memory using memory @a home. + * description @a o allocating memory using memory @a home. * * @param h Memory home * @param o SDP origin description to be duplicated * + * @note The duplicated structure is allocated using a single call to + * su_alloc() and it can be freed with su_free(). + * * @return * If successful, a pointer to newly allocated sdp_origin_t structure is * returned, otherwise NULL is returned. @@ -190,12 +193,15 @@ /**Duplicate an SDP connection description. * - * The function sdp_connection_dup() duplicates (deeply copies) an SDP - * connection description�@a c allocating memory using memory @a home. + * The function sdp_connection_dup() duplicates (deeply copies) a list of + * SDP connection description @a c allocating memory using memory @a home. * * @param h Memory home * @param c SDP connection description to be duplicated * + * @note The duplicated list is allocated using a single call to + * su_alloc() and it can be freed with su_free(). + * * @return * If successful, a pointer to newly allocated sdp_connection_t structure is * returned, otherwise NULL is returned. @@ -207,12 +213,15 @@ /**Duplicate an SDP bandwidth description. * - * The function sdp_bandwidth_dup() duplicates (deeply copies) an SDP - * bandwidth description�@a b allocating memory using memory @a home. + * The function sdp_bandwidth_dup() duplicates (deeply copies) a list of SDP + * bandwidth descriptions @a b allocating memory using memory @a home. * * @param h Memory home * @param b SDP bandwidth description to be duplicated * + * @note The duplicated list is allocated using a single call to + * su_alloc() and it can be freed with su_free(). + * * @return * If successful, a pointer to newly allocated sdp_bandwidth_t structure is * returned, otherwise NULL is returned. @@ -224,12 +233,15 @@ /**Duplicate an SDP time description. * - * The function sdp_time_dup() duplicates (deeply copies) an SDP time - * description�@a t allocating memory using memory @a home. + * The function sdp_time_dup() duplicates (deeply copies) a list of SDP time + * descriptions @a t allocating memory using memory @a home. * * @param h Memory home * @param t SDP time description to be duplicated * + * @note The duplicated list is allocated using a single call to + * su_alloc() and it can be freed with su_free(). + * * @return * If successful, a pointer to newly allocated sdp_time_t structure is * returned, otherwise NULL is returned. @@ -242,11 +254,14 @@ /**Duplicate an SDP repeat description. * * The function sdp_repeat_dup() duplicates (deeply copies) an SDP repeat - * description�@a r allocating memory using memory @a home. + * description @a r allocating memory using memory @a home. * * @param h Memory home * @param r SDP repeat description to be duplicated * + * @note The duplicated structure is allocated using a single call to + * su_alloc() and it can be freed with su_free(). + * * @return * If successful, a pointer to newly allocated sdp_repeat_t structure is * returned, otherwise NULL is returned. @@ -259,11 +274,14 @@ /**Duplicate an SDP zone description. * * The function sdp_zone_dup() duplicates (deeply copies) an SDP zone - * description�@a z allocating memory using memory @a home. + * description @a z allocating memory using memory @a home. * * @param h Memory home * @param z SDP zone description to be duplicated * + * @note The duplicated structure is allocated using a single call to + * su_alloc() and it can be freed with su_free(). + * * @return * If successful, a pointer to newly allocated sdp_zone_t structure is * returned, otherwise NULL is returned. @@ -276,11 +294,14 @@ /**Duplicate an SDP key description. * * The function sdp_key_dup() duplicates (deeply copies) an SDP key - * description�@a k allocating memory using memory @a home. + * description @a k allocating memory using memory @a home. * * @param h Memory home * @param k SDP key description to be duplicated * + * @note The duplicated structure is allocated using a single call to + * su_alloc() and it can be freed with su_free(). + * * @return * If successful, a pointer to newly allocated sdp_key_t structure is * returned, otherwise NULL is returned. @@ -298,6 +319,9 @@ * @param h Memory home * @param a SDP attribute description to be duplicated * + * @note The duplicated structure is allocated using a single call to + * su_alloc() and it can be freed with su_free(). + * * @return * If successful, a pointer to newly allocated sdp_attribute_t structure is * returned, otherwise NULL is returned. @@ -315,6 +339,9 @@ * @param h Memory home * @param l SDP list description to be duplicated * + * @note The duplicated structure is allocated using a single call to + * su_alloc() and it can be freed with su_free(). + * * @return * If successful, a pointer to newly allocated sdp_list_t structure is * returned, otherwise NULL is returned. @@ -332,6 +359,9 @@ * @param h Memory home * @param rm SDP rtpmap description to be duplicated * + * @note The duplicated structure is allocated using a single call to + * su_alloc() and it can be freed with su_free(). + * * @return * If successful, a pointer to newly allocated sdp_rtpmap_t structure is * returned, otherwise NULL is returned. @@ -344,13 +374,16 @@ /**Duplicate an SDP media description. * * The function sdp_media_dup() duplicates (deeply copies) an SDP media - * description�@a m allocating memory using memory @a home. + * description @a m allocating memory using memory @a home. * * @param h Memory home * @param m SDP media description to be duplicated * @param sdp SDP session description to which the newly allocated * media description is linked * + * @note The duplicated structure is allocated using a single call to + * su_alloc() and it can be freed with su_free(). + * * @return * If successful, a pointer to newly allocated sdp_media_t structure is * returned, otherwise NULL is returned. @@ -369,13 +402,16 @@ /**Duplicate an SDP media description. * * The function sdp_media_dup_all() duplicates (deeply copies) a list of SDP - * media descriptions�@a m allocating memory using memory @a home. + * media descriptions @a m allocating memory using memory @a home. * * @param h Memory home * @param m list of SDP media descriptions to be duplicated * @param sdp SDP session description to which the newly allocated * media descriptions are linked * + * @note The duplicated list is allocated using a single call to + * su_alloc() and it can be freed with su_free(). + * * @return * If successful, a pointer to a newly allocated list of sdp_media_t * structures is returned, otherwise NULL is returned. @@ -944,11 +980,14 @@ /**Duplicate an SDP session description. * * The function sdp_session_dup() duplicates (deeply copies) an SDP - * session description�@a sdp allocating memory using memory @a home. + * session description @a sdp allocating memory using memory @a home. * * @param h Memory home * @param sdp SDP session description to be duplicated * + * @note The duplicated structure is allocated using a single call to + * su_alloc() and it can be freed with su_free(). + * * @return * If successful, a pointer to newly allocated sdp_session_t structure is * returned, otherwise NULL is returned. @@ -1017,12 +1056,15 @@ /**Duplicate an SDP session description without media descriptions. * * The function sdp_session_dup() duplicates (deeply copies) an SDP session - * description�@a sdp allocating memory using memory @a home. It does not + * description @a sdp allocating memory using memory @a home. It does not * copy the media descriptions, however. * * @param h memory h * @param sdp SDP session description to be duplicated * + * @note The duplicated structure is allocated using a single call to + * su_alloc() and it can be freed with su_free(). + * * @return * If successful, a pointer to newly allocated sdp_session_t structure is * returned, otherwise NULL is returned. Modified: freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sdp/sofia-sip/sdp.h ============================================================================== --- freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sdp/sofia-sip/sdp.h (original) +++ freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sdp/sofia-sip/sdp.h Wed Sep 10 12:19:45 2008 @@ -229,7 +229,8 @@ sdp_media_data, /**< Bulk data transfer */ sdp_media_control, /**< Additional conference control */ sdp_media_message, /**< Messaging sessions*/ - sdp_media_image, /**< Image browsing sessions for JPIP, and T.38 */ + sdp_media_image, /**< Image browsing sessions, + * e.g., JPIP or T.38. */ sdp_media_red /**< Redundancy. @NEW_1_12_4. */ } sdp_media_e; @@ -334,31 +335,31 @@ /** Duplicate an SDP connection structure. */ SOFIAPUBFUN -sdp_connection_t *sdp_connection_dup(su_home_t *home, sdp_connection_t const *); +sdp_connection_t *sdp_connection_dup(su_home_t *, sdp_connection_t const *); /** Duplicate an SDP bandwidth structure. */ SOFIAPUBFUN -sdp_bandwidth_t *sdp_bandwidth_dup(su_home_t *home, sdp_bandwidth_t const *); +sdp_bandwidth_t *sdp_bandwidth_dup(su_home_t *, sdp_bandwidth_t const *); /** Duplicate an SDP time structure. */ SOFIAPUBFUN -sdp_time_t *sdp_time_dup(su_home_t *home, sdp_time_t const *); +sdp_time_t *sdp_time_dup(su_home_t *, sdp_time_t const *); /** Duplicate an SDP repeat structure. */ SOFIAPUBFUN -sdp_repeat_t *sdp_repeat_dup(su_home_t *home, sdp_repeat_t const *); +sdp_repeat_t *sdp_repeat_dup(su_home_t *, sdp_repeat_t const *); /** Duplicate an SDP timezone structure. */ SOFIAPUBFUN -sdp_zone_t *sdp_zone_dup(su_home_t *home, sdp_zone_t const *); +sdp_zone_t *sdp_zone_dup(su_home_t *, sdp_zone_t const *); /** Duplicate an SDP key structure. */ SOFIAPUBFUN -sdp_key_t *sdp_key_dup(su_home_t *home, sdp_key_t const *); +sdp_key_t *sdp_key_dup(su_home_t *, sdp_key_t const *); /** Duplicate an SDP attribute structure. */ SOFIAPUBFUN -sdp_attribute_t *sdp_attribute_dup(su_home_t *home, sdp_attribute_t const *); +sdp_attribute_t *sdp_attribute_dup(su_home_t *, sdp_attribute_t const *); /** Duplicate an SDP media description structure. */ SOFIAPUBFUN @@ -372,11 +373,11 @@ /** Duplicate a list structure. */ SOFIAPUBFUN -sdp_list_t *sdp_list_dup(su_home_t *home, sdp_list_t const *); +sdp_list_t *sdp_list_dup(su_home_t *, sdp_list_t const *); /** Duplicate an rtpmap structure. */ SOFIAPUBFUN -sdp_rtpmap_t *sdp_rtpmap_dup(su_home_t *home, sdp_rtpmap_t const *); +sdp_rtpmap_t *sdp_rtpmap_dup(su_home_t *, sdp_rtpmap_t const *); /** Compare two session descriptions. */ SOFIAPUBFUN int sdp_session_cmp(sdp_session_t const *a, @@ -450,13 +451,13 @@ /** Find a mapped attribute. */ SOFIAPUBFUN -sdp_attribute_t *sdp_attribute_mapped_find(sdp_attribute_t const *a, - char const *name, +sdp_attribute_t *sdp_attribute_mapped_find(sdp_attribute_t const *a, + char const *name, int pt, char **return_result); /** Append a attribute to a list of attributes. */ SOFIAPUBFUN void sdp_attribute_append(sdp_attribute_t **list, - sdp_attribute_t const *a); + sdp_attribute_t const *a); /** Replace a attribute within a list of attributes. */ SOFIAPUBFUN int sdp_attribute_replace(sdp_attribute_t **list, @@ -546,8 +547,9 @@ typedef struct sdp_printer_s sdp_printer_t; typedef sdp_printer_t *sdp_printer; -SOFIAPUBFUN sdp_printer_t *sdp_print(su_home_t *, sdp_session_t const *session, - char msgbuf[], isize_t maxmsgsize, int flags); +SOFIAPUBFUN sdp_printer_t *sdp_print(su_home_t *, sdp_session_t const *, + char msgbuf[], isize_t maxmsgsize, + int flags); SOFIAPUBFUN char const *sdp_printing_error(sdp_printer_t *p); SOFIAPUBFUN char const *sdp_message(sdp_printer_t *p); SOFIAPUBFUN isize_t sdp_message_size(sdp_printer_t *p);

1 0

[commit] r9502 - freeswitch/trunk/src/mod/formats/mod_shout
by Freeswitch SVN 10 Sep '08

10 Sep '08

Author: anthm Date: Wed Sep 10 11:32:35 2008 New Revision: 9502 Modified: freeswitch/trunk/src/mod/formats/mod_shout/mod_shout.c Log: fix MODFORM-12 Modified: freeswitch/trunk/src/mod/formats/mod_shout/mod_shout.c ============================================================================== --- freeswitch/trunk/src/mod/formats/mod_shout/mod_shout.c (original) +++ freeswitch/trunk/src/mod/formats/mod_shout/mod_shout.c Wed Sep 10 11:32:35 2008 @@ -91,6 +91,11 @@ int len; int16_t blank[2048] = {0}, *r = NULL; + + if (context->channels == 2) { + r = blank; + } + len = lame_encode_buffer(context->gfp, blank, r, sizeof(blank) / 2, mp3buffer, sizeof(mp3buffer)); if (len) {

1 0

[commit] r9501 - freeswitch/trunk/scripts/lua
by Freeswitch SVN 10 Sep '08

10 Sep '08

Author: brian Date: Wed Sep 10 10:05:48 2008 New Revision: 9501 Added: freeswitch/trunk/scripts/lua/callback.lua Log: create example of using the inputcallback to influence the playback of a file. Added: freeswitch/trunk/scripts/lua/callback.lua ============================================================================== --- (empty file) +++ freeswitch/trunk/scripts/lua/callback.lua Wed Sep 10 10:05:48 2008 @@ -0,0 +1,57 @@ +function all_done(s, how) + io.write("done: " .. how .. "\n"); +end + +function my_cb(s, type, obj, arg) + if (arg) then + io.write("type: " .. type .. "\n" .. "arg: " .. arg .. "\n"); + else + io.write("type: " .. type .. "\n"); + end + + if (type == "dtmf") then + io.write("digit: [" .. obj['digit'] .. "]\nduration: [" .. obj['duration'] .. "]\n"); + + if (obj['digit'] == "1") then + return "pause"; + end + + if (obj['digit'] == "2") then + return "seek:+3000"; + end + + if (obj['digit'] == "3") then + return "seek:-3000"; + end + + if (obj['digit'] == "4") then + return "seek:+3000"; + end + + if (obj['digit'] == "5") then + return "speed:+1"; + end + if (obj['digit'] == "6") then + return "speed:0"; + end + if (obj['digit'] == "7") then + return "speed:-1"; + end + + if (obj['digit'] == "8") then + return "stop"; + end + + if (obj['digit'] == "9") then + return "break"; + end + else + io.write(obj:serialize("xml")); + + end +end + +blah = "args"; +session:setHangupHook("all_done"); +session:setInputCallback("my_cb", "blah"); +session:streamFile("/tmp/swimp.raw");

1 0

[commit] r9499 - freeswitch/trunk/src
by Freeswitch SVN 09 Sep '08

09 Sep '08

Author: anthm Date: Tue Sep 9 19:14:15 2008 New Revision: 9499 Modified: freeswitch/trunk/src/switch_xml.c Log: declinatio mortuus obfirmo! Modified: freeswitch/trunk/src/switch_xml.c ============================================================================== --- freeswitch/trunk/src/switch_xml.c (original) +++ freeswitch/trunk/src/switch_xml.c Tue Sep 9 19:14:15 2008 @@ -138,9 +138,11 @@ static switch_xml_binding_t *BINDINGS = NULL; static switch_xml_t MAIN_XML_ROOT = NULL; -static switch_memory_pool_t *XML_MEMORY_POOL; -static switch_thread_rwlock_t *RWLOCK; -static switch_thread_rwlock_t *B_RWLOCK; +static switch_memory_pool_t *XML_MEMORY_POOL = NULL; +static switch_thread_rwlock_t *RWLOCK = NULL; +static switch_thread_rwlock_t *B_RWLOCK = NULL; +static switch_mutex_t *XML_LOCK = NULL; +static switch_mutex_t *XML_COUNT_LOCK = NULL; static uint32_t lock_count = 0; struct xml_section_t { @@ -1522,7 +1524,9 @@ SWITCH_DECLARE(switch_xml_t) switch_xml_root(void) { + switch_mutex_lock(XML_COUNT_LOCK); lock_count++; + switch_mutex_unlock(XML_COUNT_LOCK); switch_thread_rwlock_rdlock(RWLOCK); return MAIN_XML_ROOT; } @@ -1572,13 +1576,13 @@ uint8_t hasmain = 0, errcnt = 0; switch_xml_t new_main; - //switch_mutex_lock(XML_LOCK); + switch_mutex_lock(XML_LOCK); if (MAIN_XML_ROOT) { hasmain++; if (!reload) { - //switch_mutex_unlock(XML_LOCK); + switch_mutex_unlock(XML_LOCK); return switch_xml_root(); } switch_thread_rwlock_wrlock(RWLOCK); @@ -1610,7 +1614,8 @@ if (hasmain) { switch_thread_rwlock_unlock(RWLOCK); } - //switch_mutex_unlock(XML_LOCK); + + switch_mutex_unlock(XML_LOCK); if (errcnt == 0) { switch_event_t *event; @@ -1631,7 +1636,8 @@ XML_MEMORY_POOL = pool; *err = "Success"; - //switch_mutex_init(&XML_LOCK, SWITCH_MUTEX_NESTED, XML_MEMORY_POOL); + switch_mutex_init(&XML_LOCK, SWITCH_MUTEX_NESTED, XML_MEMORY_POOL); + switch_mutex_init(&XML_COUNT_LOCK, SWITCH_MUTEX_NESTED, XML_MEMORY_POOL); switch_thread_rwlock_create(&RWLOCK, XML_MEMORY_POOL); switch_thread_rwlock_create(&B_RWLOCK, XML_MEMORY_POOL); @@ -1924,10 +1930,12 @@ return; if (switch_test_flag(xml, SWITCH_XML_ROOT)) { + switch_mutex_lock(XML_COUNT_LOCK); if (lock_count > 0) { switch_thread_rwlock_unlock(RWLOCK); lock_count--; } + switch_mutex_unlock(XML_COUNT_LOCK); } if (xml == MAIN_XML_ROOT) {

1 0

[commit] r9498 - freeswitch/trunk/src
by Freeswitch SVN 09 Sep '08

09 Sep '08

Author: anthm Date: Tue Sep 9 18:47:37 2008 New Revision: 9498 Modified: freeswitch/trunk/src/switch_xml.c Log: change xml hooks to rwlock Modified: freeswitch/trunk/src/switch_xml.c ============================================================================== --- freeswitch/trunk/src/switch_xml.c (original) +++ freeswitch/trunk/src/switch_xml.c Tue Sep 9 18:47:37 2008 @@ -139,8 +139,8 @@ static switch_xml_binding_t *BINDINGS = NULL; static switch_xml_t MAIN_XML_ROOT = NULL; static switch_memory_pool_t *XML_MEMORY_POOL; -static switch_mutex_t *XML_LOCK; static switch_thread_rwlock_t *RWLOCK; +static switch_thread_rwlock_t *B_RWLOCK; static uint32_t lock_count = 0; struct xml_section_t { @@ -186,7 +186,8 @@ switch_xml_binding_t *ptr, *last = NULL; switch_status_t status = SWITCH_STATUS_FALSE; - switch_mutex_lock(XML_LOCK); + + switch_thread_rwlock_wrlock(B_RWLOCK); for (ptr = BINDINGS; ptr; ptr = ptr->next) { if (ptr == *binding) { if (last) { @@ -199,7 +200,7 @@ } last = ptr; } - switch_mutex_unlock(XML_LOCK); + switch_thread_rwlock_unlock(B_RWLOCK); return status; } @@ -209,7 +210,7 @@ switch_xml_binding_t *ptr, *last = NULL; switch_status_t status = SWITCH_STATUS_FALSE; - switch_mutex_lock(XML_LOCK); + switch_thread_rwlock_wrlock(B_RWLOCK); for (ptr = BINDINGS; ptr; ptr = ptr->next) { if (ptr->function == function) { if (last) { @@ -221,7 +222,7 @@ } last = ptr; } - switch_mutex_unlock(XML_LOCK); + switch_thread_rwlock_unlock(B_RWLOCK); return status; } @@ -239,7 +240,7 @@ binding->sections = sections; binding->user_data = user_data; - switch_mutex_lock(XML_LOCK); + switch_thread_rwlock_wrlock(B_RWLOCK); for (ptr = BINDINGS; ptr && ptr->next; ptr = ptr->next); if (ptr) { @@ -247,7 +248,7 @@ } else { BINDINGS = binding; } - switch_mutex_unlock(XML_LOCK); + switch_thread_rwlock_unlock(B_RWLOCK); return SWITCH_STATUS_SUCCESS; } @@ -1363,7 +1364,7 @@ switch_xml_binding_t *binding; uint8_t loops = 0; - switch_mutex_lock(XML_LOCK); + switch_thread_rwlock_rdlock(B_RWLOCK); for (binding = BINDINGS; binding; binding = binding->next) { switch_xml_section_t sections = switch_xml_parse_section_string(section); @@ -1398,7 +1399,7 @@ } } } - switch_mutex_unlock(XML_LOCK); + switch_thread_rwlock_unlock(B_RWLOCK); for (;;) { if (!xml) { @@ -1571,13 +1572,13 @@ uint8_t hasmain = 0, errcnt = 0; switch_xml_t new_main; - switch_mutex_lock(XML_LOCK); + //switch_mutex_lock(XML_LOCK); if (MAIN_XML_ROOT) { hasmain++; if (!reload) { - switch_mutex_unlock(XML_LOCK); + //switch_mutex_unlock(XML_LOCK); return switch_xml_root(); } switch_thread_rwlock_wrlock(RWLOCK); @@ -1609,7 +1610,7 @@ if (hasmain) { switch_thread_rwlock_unlock(RWLOCK); } - switch_mutex_unlock(XML_LOCK); + //switch_mutex_unlock(XML_LOCK); if (errcnt == 0) { switch_event_t *event; @@ -1630,8 +1631,9 @@ XML_MEMORY_POOL = pool; *err = "Success"; - switch_mutex_init(&XML_LOCK, SWITCH_MUTEX_NESTED, XML_MEMORY_POOL); + //switch_mutex_init(&XML_LOCK, SWITCH_MUTEX_NESTED, XML_MEMORY_POOL); switch_thread_rwlock_create(&RWLOCK, XML_MEMORY_POOL); + switch_thread_rwlock_create(&B_RWLOCK, XML_MEMORY_POOL); assert(pool != NULL);

1 0

[commit] r9497 - freeswitch/trunk/src/include
by Freeswitch SVN 09 Sep '08

09 Sep '08

Author: anthm Date: Tue Sep 9 18:47:03 2008 New Revision: 9497 Modified: freeswitch/trunk/src/include/switch_utils.h Log: add switch_safe_strdup Modified: freeswitch/trunk/src/include/switch_utils.h ============================================================================== --- freeswitch/trunk/src/include/switch_utils.h (original) +++ freeswitch/trunk/src/include/switch_utils.h Tue Sep 9 18:47:03 2008 @@ -285,6 +285,15 @@ */ #define switch_safe_free(it) if (it) {free(it);it=NULL;} +static inline char *switch_safe_strdup(const char *it) +{ + if (it) { + return strdup(it); + } + + return NULL; +} + /*! \brief Test if one string is inside another with extra case checking

1 0