- Freeswitch-svn - FreeSWITCH Mailing Lists

[commit] r4068 - freeswitch/trunk/src/mod/endpoints/mod_sofia
by Freeswitch SVN 27 Jan '07

27 Jan '07

Author: anthm Date: Sat Jan 27 13:23:30 2007 New Revision: 4068 Modified: freeswitch/trunk/src/mod/endpoints/mod_sofia/mod_sofia.c Log: fix Modified: freeswitch/trunk/src/mod/endpoints/mod_sofia/mod_sofia.c ============================================================================== --- freeswitch/trunk/src/mod/endpoints/mod_sofia/mod_sofia.c (original) +++ freeswitch/trunk/src/mod/endpoints/mod_sofia/mod_sofia.c Sat Jan 27 13:23:30 2007 @@ -2301,20 +2301,23 @@ } if (mimp) { - char tmp[50]; - tech_pvt->rm_encoding = switch_core_session_strdup(session, (char *)map->rm_encoding); - tech_pvt->pt = (switch_payload_t)map->rm_pt; - tech_pvt->rm_rate = map->rm_rate; - tech_pvt->codec_ms = mimp->microseconds_per_frame / 1000; - tech_pvt->remote_sdp_audio_ip = switch_core_session_strdup(session, (char *)sdp->sdp_connection->c_address); - tech_pvt->rm_fmtp = switch_core_session_strdup(session, (char *)map->rm_fmtp); - tech_pvt->remote_sdp_audio_port = (switch_port_t)m->m_port; - tech_pvt->agreed_pt = (switch_payload_t)map->rm_pt; - snprintf(tmp, sizeof(tmp), "%d", tech_pvt->remote_sdp_audio_port); - switch_channel_set_variable(channel, SWITCH_REMOTE_MEDIA_IP_VARIABLE, tech_pvt->remote_sdp_audio_ip); - switch_channel_set_variable(channel, SWITCH_REMOTE_MEDIA_PORT_VARIABLE, tmp); + if ((tech_pvt->rm_encoding = switch_core_session_strdup(session, (char *)mimp->rm_encoding))) { + char tmp[50]; + tech_pvt->pt = (switch_payload_t)mimp->rm_pt; + tech_pvt->rm_rate = mimp->rm_rate; + tech_pvt->codec_ms = mimp->microseconds_per_frame / 1000; + tech_pvt->remote_sdp_audio_ip = switch_core_session_strdup(session, (char *)sdp->sdp_connection->c_address); + tech_pvt->rm_fmtp = switch_core_session_strdup(session, (char *)mimp->rm_fmtp); + tech_pvt->remote_sdp_audio_port = (switch_port_t)m->m_port; + tech_pvt->agreed_pt = (switch_payload_t)mimp->rm_pt; + snprintf(tmp, sizeof(tmp), "%d", tech_pvt->remote_sdp_audio_port); + switch_channel_set_variable(channel, SWITCH_REMOTE_MEDIA_IP_VARIABLE, tech_pvt->remote_sdp_audio_ip); + switch_channel_set_variable(channel, SWITCH_REMOTE_MEDIA_PORT_VARIABLE, tmp); + } else { + match = 0; + } } - + if (match) { if (tech_set_codec(tech_pvt, 1) != SWITCH_STATUS_SUCCESS) { match = 0;

1 0

[commit] r4067 - freeswitch/trunk/src/mod/applications/mod_conference
by Freeswitch SVN 27 Jan '07

27 Jan '07

Author: anthm Date: Sat Jan 27 11:37:10 2007 New Revision: 4067 Modified: freeswitch/trunk/src/mod/applications/mod_conference/mod_conference.c Log: fix mute Modified: freeswitch/trunk/src/mod/applications/mod_conference/mod_conference.c ============================================================================== --- freeswitch/trunk/src/mod/applications/mod_conference/mod_conference.c (original) +++ freeswitch/trunk/src/mod/applications/mod_conference/mod_conference.c Sat Jan 27 11:37:10 2007 @@ -911,6 +911,9 @@ conf_api_sub_mute(member, NULL, NULL); } else { conf_api_sub_unmute(member, NULL, NULL); + if (!switch_test_flag(member, MFLAG_CAN_HEAR)) { + conf_api_sub_undeaf(member, NULL, NULL); + } } } } @@ -920,10 +923,14 @@ if (member != NULL) { if (switch_test_flag(member, MFLAG_CAN_SPEAK)) { conf_api_sub_mute(member, NULL, NULL); - conf_api_sub_deaf(member, NULL, NULL); + if (switch_test_flag(member, MFLAG_CAN_HEAR)) { + conf_api_sub_deaf(member, NULL, NULL); + } } else { conf_api_sub_unmute(member, NULL, NULL); - conf_api_sub_undeaf(member, NULL, NULL); + if (!switch_test_flag(member, MFLAG_CAN_HEAR)) { + conf_api_sub_undeaf(member, NULL, NULL); + } } } }

1 0

[commit] r4066 - in freeswitch/trunk: conf src src/include src/mod/applications/mod_enum src/mod/dialplans/mod_dialplan_directory src/mod/dialplans/mod_dialplan_xml src/mod/xml_int/mod_xml_curl
by Freeswitch SVN 27 Jan '07

27 Jan '07

Author: anthm Date: Sat Jan 27 11:23:33 2007 New Revision: 4066 Modified: freeswitch/trunk/conf/xml_curl.conf.xml freeswitch/trunk/src/include/switch_types.h freeswitch/trunk/src/include/switch_utils.h freeswitch/trunk/src/include/switch_xml.h freeswitch/trunk/src/mod/applications/mod_enum/mod_enum.c freeswitch/trunk/src/mod/dialplans/mod_dialplan_directory/mod_dialplan_directory.c freeswitch/trunk/src/mod/dialplans/mod_dialplan_xml/mod_dialplan_xml.c freeswitch/trunk/src/mod/xml_int/mod_xml_curl/mod_xml_curl.c freeswitch/trunk/src/switch_core.c freeswitch/trunk/src/switch_xml.c Log: A few changes: 1) The xml_curl now has a more enterprise config where it can have more than 1 url configured so you could have failover. (*note the syntax change*) 2) dialplan modules now take an extra arguement making it possible to pass runtime params to them. This is now used in mod_dialplan_xml to allow an alternate file path to be specified. dialplans were already stackable meaning you can configure a sofia profile, for example, to use enum followed by the default XML dialplan. e.g. <param name="dialplan" value="enum,XML"/> From now on, you can also specify :param after each dialplan name to allow param to be passed to the module. mod_dialplan_xml uses this param as a way to override where it looks for the dialplan making it possible to stack mutiple calls to the XML dialplan. e.g. <param name="dialplan" value="XML:/some/xml/file.xml,XML"/> With this you can search the local file file.xml first and if there is still no match the hunt will move on to the standard XML using the onboard XML registry and or the external gateways. *NOTE* this alternate path does not use the external bindings but it does parse the #includes etc. Modified: freeswitch/trunk/conf/xml_curl.conf.xml ============================================================================== --- freeswitch/trunk/conf/xml_curl.conf.xml (original) +++ freeswitch/trunk/conf/xml_curl.conf.xml Sat Jan 27 11:23:33 2007 @@ -1,11 +1,13 @@ <configuration name="xml_curl.conf" description="cURL XML Gateway"> - <settings> -  -  -  -  -  - </settings> + <bindings> + <binding name="example"> +  +  + <param name="gateway-url" value="http://www.mydomain.com/test.cgi" bindings="dialplan"/> +  +  + </binding> + </bindings> </configuration> Modified: freeswitch/trunk/src/include/switch_types.h ============================================================================== --- freeswitch/trunk/src/include/switch_types.h (original) +++ freeswitch/trunk/src/include/switch_types.h Sat Jan 27 11:23:33 2007 @@ -900,7 +900,7 @@ typedef void (*switch_media_bug_callback_t)(switch_media_bug_t *, void *, switch_abc_type_t); typedef void (*switch_application_function_t)(switch_core_session_t *, char *); typedef void (*switch_event_callback_t)(switch_event_t *); -typedef switch_caller_extension_t *(*switch_dialplan_hunt_function_t)(switch_core_session_t *); +typedef switch_caller_extension_t *(*switch_dialplan_hunt_function_t)(switch_core_session_t *, void *); typedef switch_status_t (*switch_state_handler_t)(switch_core_session_t *); typedef switch_status_t (*switch_outgoing_channel_hook_t)(switch_core_session_t *, switch_caller_profile_t *, switch_core_session_t *); typedef switch_status_t (*switch_answer_channel_hook_t)(switch_core_session_t *); @@ -945,7 +945,8 @@ char *tag_name, char *key_name, char *key_value, - char *params); + char *params, + void *user_data); /* things we don't deserve to know about */ /*! \brief A channel */ Modified: freeswitch/trunk/src/include/switch_utils.h ============================================================================== --- freeswitch/trunk/src/include/switch_utils.h (original) +++ freeswitch/trunk/src/include/switch_utils.h Sat Jan 27 11:23:33 2007 @@ -182,7 +182,7 @@ \param s the string to test \return true value if the string is NULL or zero length */ -#define switch_strlen_zero(s) (s && *s != '\0') ? 0 : 1 +#define switch_strlen_zero(s) (!s || *s == '\0') /*! \brief Wait a desired number of microseconds and yield the CPU Modified: freeswitch/trunk/src/include/switch_xml.h ============================================================================== --- freeswitch/trunk/src/include/switch_xml.h (original) +++ freeswitch/trunk/src/include/switch_xml.h Sat Jan 27 11:23:33 2007 @@ -324,9 +324,10 @@ ///\brief bind a search function to an external gateway ///\param function the search function to bind ///\param sections a bitmask of sections you wil service +///\param user_data a pointer to private data to be used during the callback ///\return SWITCH_STATUS_SUCCESS if successful ///\note gateway functions will be executed in the order they were binded until a success is found else the root registry will be used -SWITCH_DECLARE(switch_status_t) switch_xml_bind_search_function(switch_xml_search_function_t function, switch_xml_section_t sections); +SWITCH_DECLARE(switch_status_t) switch_xml_bind_search_function(switch_xml_search_function_t function, switch_xml_section_t sections, void *user_data); ///\brief parse a string for a list of sections ///\param str a | delimited list of section names Modified: freeswitch/trunk/src/mod/applications/mod_enum/mod_enum.c ============================================================================== --- freeswitch/trunk/src/mod/applications/mod_enum/mod_enum.c (original) +++ freeswitch/trunk/src/mod/applications/mod_enum/mod_enum.c Sat Jan 27 11:23:33 2007 @@ -514,7 +514,7 @@ } -static switch_caller_extension_t *enum_dialplan_hunt(switch_core_session_t *session) +static switch_caller_extension_t *enum_dialplan_hunt(switch_core_session_t *session, void *arg) { switch_caller_extension_t *extension = NULL; switch_caller_profile_t *caller_profile; Modified: freeswitch/trunk/src/mod/dialplans/mod_dialplan_directory/mod_dialplan_directory.c ============================================================================== --- freeswitch/trunk/src/mod/dialplans/mod_dialplan_directory/mod_dialplan_directory.c (original) +++ freeswitch/trunk/src/mod/dialplans/mod_dialplan_directory/mod_dialplan_directory.c Sat Jan 27 11:23:33 2007 @@ -83,7 +83,7 @@ switch_xml_free(xml); } -static switch_caller_extension_t *directory_dialplan_hunt(switch_core_session_t *session) +static switch_caller_extension_t *directory_dialplan_hunt(switch_core_session_t *session, void *arg) { switch_caller_profile_t *caller_profile; switch_caller_extension_t *extension = NULL; Modified: freeswitch/trunk/src/mod/dialplans/mod_dialplan_xml/mod_dialplan_xml.c ============================================================================== --- freeswitch/trunk/src/mod/dialplans/mod_dialplan_xml/mod_dialplan_xml.c (original) +++ freeswitch/trunk/src/mod/dialplans/mod_dialplan_xml/mod_dialplan_xml.c Sat Jan 27 11:23:33 2007 @@ -193,12 +193,12 @@ return proceed; } -static switch_caller_extension_t *dialplan_hunt(switch_core_session_t *session) +static switch_caller_extension_t *dialplan_hunt(switch_core_session_t *session, void *arg) { switch_caller_profile_t *caller_profile; switch_caller_extension_t *extension = NULL; switch_channel_t *channel; - switch_xml_t cfg, xml, xcontext, xexten; + switch_xml_t alt_root = NULL, cfg, xml, xcontext, xexten; char *context = NULL; switch_stream_handle_t stream = {0}; switch_size_t encode_len = 1024, new_len = 0; @@ -206,6 +206,7 @@ char *prof[11] = {0}, *prof_names[11] = {0}, *e = NULL; switch_hash_index_t *hi; uint32_t x = 0; + char *alt_path = (char *) arg; channel = switch_core_session_get_channel(session); if ((caller_profile = switch_channel_get_caller_profile(channel))) { @@ -296,11 +297,28 @@ if (e && *e == '&') { *e = '\0'; } + + if (!switch_strlen_zero(alt_path)) { + switch_xml_t conf = NULL, tag = NULL; + if (!(alt_root = switch_xml_parse_file(alt_path))) { + switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "open of [%s] failed\n", alt_path); + return NULL; + } - if (switch_xml_locate("dialplan", NULL, NULL, NULL, &xml, &cfg, stream.data) != SWITCH_STATUS_SUCCESS) { - switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "open of dialplan failed\n"); - return NULL; - } + if ((conf = switch_xml_find_child(alt_root, "section", "name", "dialplan")) && + (tag = switch_xml_find_child(conf, "dialplan", NULL, NULL))) { + switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_DEBUG, "Getting dialplan from alternate path: %s\n", alt_path); + xml = alt_root; + cfg = tag; + } else { + switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "open of dialplan failed\n"); + return NULL; + } + } else if (switch_xml_locate("dialplan", NULL, NULL, NULL, &xml, &cfg, stream.data) != SWITCH_STATUS_SUCCESS) { + switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "open of dialplan failed\n"); + return NULL; + } + switch_safe_free(stream.data); switch_safe_free(encode_buf); Modified: freeswitch/trunk/src/mod/xml_int/mod_xml_curl/mod_xml_curl.c ============================================================================== --- freeswitch/trunk/src/mod/xml_int/mod_xml_curl/mod_xml_curl.c (original) +++ freeswitch/trunk/src/mod/xml_int/mod_xml_curl/mod_xml_curl.c Sat Jan 27 11:23:33 2007 @@ -33,15 +33,13 @@ static const char modname[] = "mod_xml_curl"; -static struct { +struct xml_binding { char *url; char *bindings; char *cred; -} globals; +}; -SWITCH_DECLARE_GLOBAL_STRING_FUNC(set_global_url, globals.url); -SWITCH_DECLARE_GLOBAL_STRING_FUNC(set_global_bindings, globals.bindings); -SWITCH_DECLARE_GLOBAL_STRING_FUNC(set_global_cred, globals.cred); +typedef struct xml_binding xml_binding_t; struct config_data { char *name; @@ -62,7 +60,8 @@ char *tag_name, char *key_name, char *key_value, - char *params) + char *params, + void *user_data) { char filename[512] = ""; CURL *curl_handle = NULL; @@ -71,6 +70,22 @@ char *data = NULL; switch_uuid_t uuid; char uuid_str[SWITCH_UUID_FORMATTED_LENGTH + 1]; + xml_binding_t *binding = (xml_binding_t *) user_data; + char *file_url; + + if (!binding) { + return NULL; + } + + if (file_url = strstr(binding->url, "file:")) { + file_url += 5; + + if (!(xml = switch_xml_parse_file(file_url))) { + switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "Error Parsing Result!\n"); + } + + return xml; + } if (!(data = switch_mprintf("section=%s&tag_name=%s&key_name=%s&key_value=%s%s%s", section, @@ -88,20 +103,20 @@ snprintf(filename, sizeof(filename), "%s%s.tmp.xml", SWITCH_GLOBAL_dirs.temp_dir, uuid_str); curl_handle = curl_easy_init(); - if (!strncasecmp(globals.url, "https", 5)) { + if (!strncasecmp(binding->url, "https", 5)) { curl_easy_setopt(curl_handle, CURLOPT_SSL_VERIFYPEER, 0); curl_easy_setopt(curl_handle, CURLOPT_SSL_VERIFYHOST, 0); } config_data.name = filename; if ((config_data.fd = open(filename, O_CREAT | O_RDWR | O_TRUNC)) > -1) { - if (!switch_strlen_zero(globals.cred)) { + if (!switch_strlen_zero(binding->cred)) { curl_easy_setopt(curl_handle, CURLOPT_HTTPAUTH, CURLAUTH_ANY); - curl_easy_setopt(curl_handle, CURLOPT_USERPWD, globals.cred); + curl_easy_setopt(curl_handle, CURLOPT_USERPWD, binding->cred); } curl_easy_setopt(curl_handle, CURLOPT_POST, 1); curl_easy_setopt(curl_handle, CURLOPT_POSTFIELDS, data); - curl_easy_setopt(curl_handle, CURLOPT_URL, globals.url); + curl_easy_setopt(curl_handle, CURLOPT_URL, binding->url); curl_easy_setopt(curl_handle, CURLOPT_WRITEFUNCTION, file_callback); curl_easy_setopt(curl_handle, CURLOPT_WRITEDATA, (void *)&config_data); curl_easy_setopt(curl_handle, CURLOPT_USERAGENT, "freeswitch-xml/1.0"); @@ -140,31 +155,71 @@ static switch_status_t do_config(void) { char *cf = "xml_curl.conf"; - switch_xml_t cfg, xml, settings, param; + switch_xml_t cfg, xml, bindings_tag, binding_tag, param; + xml_binding_t *binding = NULL; + int x = 0; if (!(xml = switch_xml_open_cfg(cf, &cfg, NULL))) { switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "open of %s failed\n", cf); return SWITCH_STATUS_TERM; } - if ((settings = switch_xml_child(cfg, "settings"))) { - for (param = switch_xml_child(settings, "param"); param; param = param->next) { + if (!(bindings_tag = switch_xml_child(cfg, "bindings"))) { + switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "Missing <bindings> tag!\n"); + return SWITCH_STATUS_FALSE; + } + + for (binding_tag = switch_xml_child(bindings_tag, "binding"); binding_tag; binding_tag = binding_tag->next) { + char *bname = (char *) switch_xml_attr_soft(binding_tag, "name"); + char *url = NULL; + char *bind_cred = NULL; + char *bind_mask = NULL; + + for (param = switch_xml_child(binding_tag, "param"); param; param = param->next) { char *var = (char *) switch_xml_attr_soft(param, "name"); char *val = (char *) switch_xml_attr_soft(param, "value"); - if (!strcasecmp(var, "gateway-url")) { - char *bindings = (char *) switch_xml_attr_soft(param, "bindings"); - set_global_bindings(bindings); - set_global_url(val); + bind_mask = (char *) switch_xml_attr_soft(param, "bindings"); + if (val) { + url = val; + } } else if (!strcasecmp(var, "gateway-credentials")) { - set_global_cred(val); + bind_cred = var; } } + + if (!url) { + switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "Binding has no url!\n"); + continue; + } + + if (!(binding = malloc(sizeof(*binding)))) { + return SWITCH_STATUS_FALSE; + } + memset(binding, 0, sizeof(*binding)); + + binding->url = strdup(url); + + if (bind_mask) { + binding->bindings = strdup(bind_mask); + } + + if (bind_cred) { + binding->cred = strdup(bind_cred); + } + + switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_NOTICE, "Binding [%s] XML Fetch Function [%s] [%s]\n", + switch_strlen_zero(bname) ? "N/A" : bname, + binding->url, + binding->bindings ? binding->bindings : "all"); + switch_xml_bind_search_function(xml_url_fetch, switch_xml_parse_section_string(binding->bindings), binding); + x++; + binding = NULL; } switch_xml_free(xml); - return globals.url ? SWITCH_STATUS_SUCCESS : SWITCH_STATUS_FALSE; + return x ? SWITCH_STATUS_SUCCESS : SWITCH_STATUS_FALSE; } @@ -175,10 +230,7 @@ if (do_config() == SWITCH_STATUS_SUCCESS) { curl_global_init(CURL_GLOBAL_ALL); - switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_NOTICE, "Binding XML Fetch Function [%s] [%s]\n", - globals.url, globals.bindings ? globals.bindings : "all"); - switch_xml_bind_search_function(xml_url_fetch, switch_xml_parse_section_string(globals.bindings)); - } else { + } else { return SWITCH_STATUS_FALSE; } Modified: freeswitch/trunk/src/switch_core.c ============================================================================== --- freeswitch/trunk/src/switch_core.c (original) +++ freeswitch/trunk/src/switch_core.c Sat Jan 27 11:23:33 2007 @@ -2701,13 +2701,21 @@ if ((dpstr = switch_core_session_strdup(session, caller_profile->dialplan))) { argc = switch_separate_string(dpstr, ',', dp, (sizeof(dp) / sizeof(dp[0]))); for (x = 0; x < argc; x++) { - if (!(dialplan_interface = switch_loadable_module_get_dialplan_interface(dp[x]))) { + char *dpname = dp[x]; + char *dparg = NULL; + + if (dpname) { + if ((dparg = strchr(dpname, ':'))) { + *dparg++ = '\0'; + } + } + if (!(dialplan_interface = switch_loadable_module_get_dialplan_interface(dpname))) { continue; } count++; - if ((extension = dialplan_interface->hunt_function(session)) != 0) { + if ((extension = dialplan_interface->hunt_function(session, dparg)) != 0) { switch_channel_set_caller_extension(session->channel, extension); return; } Modified: freeswitch/trunk/src/switch_xml.c ============================================================================== --- freeswitch/trunk/src/switch_xml.c (original) +++ freeswitch/trunk/src/switch_xml.c Sat Jan 27 11:23:33 2007 @@ -93,6 +93,7 @@ struct switch_xml_binding { switch_xml_search_function_t function; switch_xml_section_t sections; + void *user_data; struct switch_xml_binding *next; }; @@ -141,7 +142,7 @@ return sections; } -SWITCH_DECLARE(switch_status_t) switch_xml_bind_search_function(switch_xml_search_function_t function, switch_xml_section_t sections) +SWITCH_DECLARE(switch_status_t) switch_xml_bind_search_function(switch_xml_search_function_t function, switch_xml_section_t sections, void *user_data) { switch_xml_binding_t *binding = NULL, *ptr = NULL; assert(function != NULL); @@ -152,6 +153,7 @@ binding->function = function; binding->sections = sections; + binding->user_data = user_data; switch_mutex_lock(XML_LOCK); for (ptr = BINDINGS; ptr && ptr->next; ptr = ptr->next); @@ -1020,7 +1022,7 @@ continue; } - if ((xml = binding->function(section, tag_name, key_name, key_value, params))) { + if ((xml = binding->function(section, tag_name, key_name, key_value, params, binding->user_data))) { const char *err = NULL; err = switch_xml_error(xml);

1 0

[commit] r4065 - freeswitch/trunk/src/mod/endpoints/mod_sofia
by Freeswitch SVN 27 Jan '07

27 Jan '07

Author: mikej Date: Fri Jan 26 23:45:54 2007 New Revision: 4065 Modified: freeswitch/trunk/src/mod/endpoints/mod_sofia/mod_sofia.c Log: fail the call when the best match is a codec with no name. Modified: freeswitch/trunk/src/mod/endpoints/mod_sofia/mod_sofia.c ============================================================================== --- freeswitch/trunk/src/mod/endpoints/mod_sofia/mod_sofia.c (original) +++ freeswitch/trunk/src/mod/endpoints/mod_sofia/mod_sofia.c Fri Jan 26 23:45:54 2007 @@ -1348,6 +1348,12 @@ channel = switch_core_session_get_channel(tech_pvt->session); assert(channel != NULL); + if (!tech_pvt->rm_encoding) { + switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "Can't load codec with no name?\n"); + terminate_session(&tech_pvt->session, SWITCH_CAUSE_DESTINATION_OUT_OF_ORDER, __LINE__); + return SWITCH_STATUS_FALSE; + } + if (switch_core_codec_init(&tech_pvt->read_codec, tech_pvt->rm_encoding, tech_pvt->rm_fmtp,

1 0

[commit] r4064 - freeswitch/trunk/src
by Freeswitch SVN 27 Jan '07

27 Jan '07

Author: mikej Date: Fri Jan 26 23:44:47 2007 New Revision: 4064 Modified: freeswitch/trunk/src/switch_xml.c Log: differing const qualifiers. Modified: freeswitch/trunk/src/switch_xml.c ============================================================================== --- freeswitch/trunk/src/switch_xml.c (original) +++ freeswitch/trunk/src/switch_xml.c Fri Jan 26 23:44:47 2007 @@ -961,7 +961,7 @@ if ((abs = strrchr(file, '/')) || (abs = strrchr(file, '\\'))) { abs++; } else { - abs = file; + abs = (char *)file; } if (!(new_file = switch_mprintf("%s%s%s.fsxml", SWITCH_GLOBAL_dirs.log_dir, SWITCH_PATH_SEPARATOR, abs))) {

1 0

[commit] r4063 - freeswitch/branches/cparker
by Freeswitch SVN 27 Jan '07

27 Jan '07

Author: sphere Date: Fri Jan 26 20:43:21 2007 New Revision: 4063 Added: freeswitch/branches/cparker/ Log: Creating empty folder for cparker

1 0

[commit] r4062 - freeswitch/trunk/src/mod/endpoints/mod_sofia
by Freeswitch SVN 26 Jan '07

26 Jan '07

Author: anthm Date: Fri Jan 26 16:12:19 2007 New Revision: 4062 Modified: freeswitch/trunk/src/mod/endpoints/mod_sofia/mod_sofia.c Log: add sip_call_id variable to sofia Modified: freeswitch/trunk/src/mod/endpoints/mod_sofia/mod_sofia.c ============================================================================== --- freeswitch/trunk/src/mod/endpoints/mod_sofia/mod_sofia.c (original) +++ freeswitch/trunk/src/mod/endpoints/mod_sofia/mod_sofia.c Fri Jan 26 16:12:19 2007 @@ -306,6 +306,7 @@ char *chat_from; char *chat_to; char *e_dest; + char *call_id; unsigned long rm_rate; switch_payload_t pt; switch_mutex_t *flag_mutex; @@ -800,6 +801,7 @@ } } + static void attach_private(switch_core_session_t *session, sofia_profile_t *profile, private_object_t *tech_pvt, @@ -829,6 +831,7 @@ tech_set_codecs(tech_pvt); snprintf(name, sizeof(name), "sofia/%s/%s", profile->name, channame); switch_channel_set_name(channel, name); + } static void terminate_session(switch_core_session_t **session, switch_call_cause_t cause, int line) @@ -2632,9 +2635,8 @@ tech_pvt = switch_core_session_get_private(session); assert(tech_pvt != NULL); - - tech_pvt->nh = nh; - + assert(tech_pvt->nh != NULL); + if (switch_channel_test_flag(channel, CF_NOMEDIA)) { switch_set_flag(tech_pvt, TFLAG_NOMEDIA); } @@ -4223,6 +4225,11 @@ switch_channel_set_variable(channel, "sip_contact_host", contact_host); switch_channel_set_variable(channel, "sip_contact_port", contact_port); + if (!tech_pvt->call_id && sip && sip->sip_call_id && sip->sip_call_id->i_id) { + tech_pvt->call_id = switch_core_session_strdup(session, (char *)sip->sip_call_id->i_id); + switch_channel_set_variable(channel, "sip_call_id", tech_pvt->call_id); + } + via_host = (char *) sip->sip_via->v_host; if (!(via_port = (char *) sip->sip_via->v_port)) { via_port = "5060"; @@ -4324,7 +4331,7 @@ memset(tech_pvt->sofia_private, 0, sizeof(*tech_pvt->sofia_private)); switch_copy_string(tech_pvt->sofia_private->uuid, switch_core_session_get_uuid(session), sizeof(tech_pvt->sofia_private->uuid)); nua_handle_bind(nh, tech_pvt->sofia_private); - + tech_pvt->nh = nh; } static void sip_i_register(nua_t *nua, @@ -4500,7 +4507,10 @@ if (switch_channel_test_flag(channel, CF_NOMEDIA)) { switch_set_flag(tech_pvt, TFLAG_NOMEDIA); } - + if (!tech_pvt->call_id && sip && sip->sip_call_id && sip->sip_call_id->i_id) { + tech_pvt->call_id = switch_core_session_strdup(session, (char *)sip->sip_call_id->i_id); + switch_channel_set_variable(channel, "sip_call_id", tech_pvt->call_id); + } } else { /* too late */ return;

1 0

[commit] r4061 - in freeswitch/trunk/src: . include mod/endpoints/mod_sofia
by Freeswitch SVN 26 Jan '07

26 Jan '07

Author: anthm Date: Fri Jan 26 15:39:45 2007 New Revision: 4061 Modified: freeswitch/trunk/src/include/switch_types.h freeswitch/trunk/src/mod/endpoints/mod_sofia/mod_sofia.c freeswitch/trunk/src/switch_channel.c freeswitch/trunk/src/switch_ivr.c Log: fix cause code passthrough Modified: freeswitch/trunk/src/include/switch_types.h ============================================================================== --- freeswitch/trunk/src/include/switch_types.h (original) +++ freeswitch/trunk/src/include/switch_types.h Fri Jan 26 15:39:45 2007 @@ -779,7 +779,7 @@ } switch_input_type_t; typedef enum { - SWITCH_CAUSE_UNALLOCATED = 1, + SWITCH_CAUSE_UNALLOCATED = 0, SWITCH_CAUSE_NO_ROUTE_TRANSIT_NET = 2, SWITCH_CAUSE_NO_ROUTE_DESTINATION = 3, SWITCH_CAUSE_CHANNEL_UNACCEPTABLE = 6, Modified: freeswitch/trunk/src/mod/endpoints/mod_sofia/mod_sofia.c ============================================================================== --- freeswitch/trunk/src/mod/endpoints/mod_sofia/mod_sofia.c (original) +++ freeswitch/trunk/src/mod/endpoints/mod_sofia/mod_sofia.c Fri Jan 26 15:39:45 2007 @@ -1175,7 +1175,6 @@ // map QSIG cause codes to SIP from RFC4497 section 8.4.1 static int hangup_cause_to_sip(switch_call_cause_t cause) { switch (cause) { - case SWITCH_CAUSE_UNALLOCATED: case SWITCH_CAUSE_NO_ROUTE_TRANSIT_NET: case SWITCH_CAUSE_NO_ROUTE_DESTINATION: return 404; @@ -2334,7 +2333,7 @@ case 404: case 485: case 604: - return SWITCH_CAUSE_UNALLOCATED; + return SWITCH_CAUSE_NO_ROUTE_DESTINATION; case 408: case 504: return SWITCH_CAUSE_RECOVERY_ON_TIMER_EXPIRE; Modified: freeswitch/trunk/src/switch_channel.c ============================================================================== --- freeswitch/trunk/src/switch_channel.c (original) +++ freeswitch/trunk/src/switch_channel.c Fri Jan 26 15:39:45 2007 @@ -120,7 +120,7 @@ SWITCH_DECLARE(char *) switch_channel_cause2str(switch_call_cause_t cause) { uint8_t x; - char *str = "UNALLOCATED"; + char *str = "UNKNOWN"; for(x = 0; CAUSE_CHART[x].name; x++) { if (CAUSE_CHART[x].cause == cause) { @@ -620,7 +620,7 @@ channel->state = state; switch_mutex_unlock(channel->flag_mutex); - if (state == CS_HANGUP && channel->hangup_cause == SWITCH_CAUSE_UNALLOCATED) { + if (state == CS_HANGUP && !channel->hangup_cause) { channel->hangup_cause = SWITCH_CAUSE_NORMAL_CLEARING; } if (state < CS_HANGUP) { Modified: freeswitch/trunk/src/switch_ivr.c ============================================================================== --- freeswitch/trunk/src/switch_ivr.c (original) +++ freeswitch/trunk/src/switch_ivr.c Fri Jan 26 15:39:45 2007 @@ -2881,8 +2881,8 @@ } done: - *cause = SWITCH_CAUSE_DESTINATION_OUT_OF_ORDER; - + *cause = SWITCH_CAUSE_UNALLOCATED; + if (var_event) { switch_event_destroy(&var_event); } @@ -2900,18 +2900,19 @@ if (!peer_channels[i]) { continue; } - - *cause = switch_channel_get_cause(peer_channels[i]); + *cause = switch_channel_get_cause(peer_channels[i]); break; } } - if (reason != SWITCH_CAUSE_UNALLOCATED) { - *cause = reason; - } else if (caller_channel) { - *cause = switch_channel_get_cause(caller_channel); - } else { - *cause = SWITCH_CAUSE_DESTINATION_OUT_OF_ORDER; + if (!*cause) { + if (reason) { + *cause = reason; + } else if (caller_channel) { + *cause = switch_channel_get_cause(caller_channel); + } else { + *cause = SWITCH_CAUSE_DESTINATION_OUT_OF_ORDER; + } } if (idx == IDX_CANCEL) {

1 0

[commit] r4060 - in freeswitch/trunk/src: . include
by Freeswitch SVN 26 Jan '07

26 Jan '07

Author: anthm Date: Fri Jan 26 12:52:22 2007 New Revision: 4060 Modified: freeswitch/trunk/src/include/switch_xml.h freeswitch/trunk/src/switch_xml.c Log: fix horrible evil bug update to this revision at once and do a "make sure" Modified: freeswitch/trunk/src/include/switch_xml.h ============================================================================== --- freeswitch/trunk/src/include/switch_xml.h (original) +++ freeswitch/trunk/src/include/switch_xml.h Fri Jan 26 12:52:22 2007 @@ -84,6 +84,8 @@ char **attr; /*! tag character content, empty string if none */ char *txt; + /*! path to free on destroy*/ + char *free_path; /*! tag offset from start of parent tag character content */ switch_size_t off; /*! next tag with same name in this section at this depth */ Modified: freeswitch/trunk/src/switch_xml.c ============================================================================== --- freeswitch/trunk/src/switch_xml.c (original) +++ freeswitch/trunk/src/switch_xml.c Fri Jan 26 12:52:22 2007 @@ -848,33 +848,21 @@ } -static int preprocess(const char *file, int new_fd, int rlevel) +static int preprocess(const char *file, int write_fd, int rlevel) { - int old_fd, close_fd = -1; - char *new_file = NULL; + int read_fd = -1; switch_size_t cur = 0, ml = 0; char *q, *cmd, buf[2048], ebuf[8192]; - if ((old_fd = open(file, O_RDONLY, 0)) < 0) { - return old_fd; + if ((read_fd = open(file, O_RDONLY, 0)) < 0) { + return read_fd; } if (rlevel > 100) { return -1; } - if (new_fd < 0) { - if (!(new_file = switch_mprintf("%s%sfreeswitch.registry", SWITCH_GLOBAL_dirs.log_dir, SWITCH_PATH_SEPARATOR))) { - goto done; - } - - if ((new_fd = open(new_file, O_WRONLY | O_CREAT | O_TRUNC, S_IRUSR | S_IWUSR)) < 0) { - goto done; - } - close_fd = new_fd; - } - - while((cur = read_line(old_fd, buf, sizeof(buf))) > 0) { + while((cur = read_line(read_fd, buf, sizeof(buf))) > 0) { char *arg, *e; char *bp = expand_vars(buf, ebuf, sizeof(ebuf), &cur); @@ -894,11 +882,11 @@ } if ((cmd = strstr(bp, ""))) { *e = '\0'; e += 3; - write(new_fd, e, (unsigned)strlen(e)); + write(write_fd, e, (unsigned)strlen(e)); } else { ml++; } @@ -945,7 +933,7 @@ fme = switch_mprintf("%s%s%s", SWITCH_GLOBAL_dirs.conf_dir, SWITCH_PATH_SEPARATOR, arg); ifile = fme; } - if (preprocess(ifile, new_fd, rlevel + 1) < 0) { + if (preprocess(ifile, write_fd, rlevel + 1) < 0) { fprintf(stderr, "Error including %s (%s)\n", ifile, strerror(errno)); } switch_safe_free(fme); @@ -955,38 +943,56 @@ continue; } - write(new_fd, bp, (unsigned)cur); - } - - close(old_fd); - - if (close_fd > -1) { - close(close_fd); - new_fd = open(new_file, O_RDONLY, 0); - } - - done: - - switch_safe_free(new_file); - - if (new_fd < 0) { - return old_fd; + write(write_fd, bp, (unsigned)cur); } - return new_fd; + close(read_fd); + return write_fd; } // a wrapper for switch_xml_parse_fd that accepts a file name SWITCH_DECLARE(switch_xml_t) switch_xml_parse_file(const char *file) { - int fd = -1; + int fd = -1, write_fd = -1; switch_xml_t xml = NULL; + char *new_file = NULL; + char *abs; - if ((fd = preprocess(file, -1, 0)) > -1) { - xml = switch_xml_parse_fd(fd); - close(fd); + if ((abs = strrchr(file, '/')) || (abs = strrchr(file, '\\'))) { + abs++; + } else { + abs = file; } + if (!(new_file = switch_mprintf("%s%s%s.fsxml", SWITCH_GLOBAL_dirs.log_dir, SWITCH_PATH_SEPARATOR, abs))) { + return NULL; + } + + if ((write_fd = open(new_file, O_WRONLY | O_CREAT | O_TRUNC, S_IRUSR | S_IWUSR)) < 0) { + goto done; + } + + if (preprocess(file, write_fd, 0) > -1) { + close(write_fd); + write_fd = -1; + if ((fd = open(new_file, O_RDONLY, 0)) > -1) { + if ((xml = switch_xml_parse_fd(fd))) { + xml->free_path = new_file; + new_file = NULL; + } + close(fd); + fd = -1; + } + } + + done: + if (write_fd > -1) { + close(write_fd); + } + if (fd > -1) { + close(fd); + } + switch_safe_free(new_file); return xml; } @@ -1340,6 +1346,11 @@ return; } + if (xml->free_path) { + unlink(xml->free_path); + switch_safe_free(xml->free_path); + } + switch_xml_free(xml->child); switch_xml_free(xml->ordered);

1 0

[commit] r4059 - freeswitch/trunk/src/mod/applications/mod_conference
by Freeswitch SVN 26 Jan '07

26 Jan '07

Author: anthm Date: Fri Jan 26 10:58:35 2007 New Revision: 4059 Modified: freeswitch/trunk/src/mod/applications/mod_conference/mod_conference.c Log: add more hint info to conference xml open Modified: freeswitch/trunk/src/mod/applications/mod_conference/mod_conference.c ============================================================================== --- freeswitch/trunk/src/mod/applications/mod_conference/mod_conference.c (original) +++ freeswitch/trunk/src/mod/applications/mod_conference/mod_conference.c Fri Jan 26 10:58:35 2007 @@ -2966,7 +2966,7 @@ } else { profile_name = "default"; } - params = switch_mprintf("conf_name=%s&profile_name=%s"); + params = switch_mprintf("conf_name=%s&profile_name=%s", conf_name, profile_name); /* Open the config from the xml registry */ if (!(cxml = switch_xml_open_cfg(global_cf_name, &cfg, params))) { switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "open of %s failed\n", global_cf_name); @@ -3525,7 +3525,7 @@ profile_name = "default"; } - params = switch_mprintf("conf_name=%s&profile_name=%s"); + params = switch_mprintf("conf_name=%s&profile_name=%s", conf_name, profile_name); /* Open the config from the xml registry */ if (!(cxml = switch_xml_open_cfg(global_cf_name, &cfg, params))) {

1 0