May 2008 - Freeswitch-svn - FreeSWITCH Mailing Lists

[commit] r8616 - in freeswitch/trunk/libs/sofia-sip: . libsofia-sip-ua/sip
by Freeswitch SVN 25 May '08

25 May '08

Author: mikej Date: Sun May 25 11:03:51 2008 New Revision: 8616 Modified: freeswitch/trunk/libs/sofia-sip/.update freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sip/torture_sip.c Log: Tue May 20 09:33:08 EDT 2008 Pekka.Pessi(a)nokia.com * torture_sip.c: added test for Content-Type Modified: freeswitch/trunk/libs/sofia-sip/.update ============================================================================== --- freeswitch/trunk/libs/sofia-sip/.update (original) +++ freeswitch/trunk/libs/sofia-sip/.update Sun May 25 11:03:51 2008 @@ -1 +1 @@ -Sun May 25 10:58:52 EDT 2008 +Sun May 25 11:03:45 EDT 2008 Modified: freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sip/torture_sip.c ============================================================================== --- freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sip/torture_sip.c (original) +++ freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sip/torture_sip.c Sun May 25 11:03:51 2008 @@ -2227,7 +2227,6 @@ static int test_content_disposition(void) { - /* Test Accept header */ sip_content_disposition_t *cd, *cd0; su_home_t *home; @@ -2247,6 +2246,38 @@ END(); } + +static int test_content_type(void) +{ + sip_content_type_t *c; + sip_content_type_t c0[1]; + su_home_t *home; + + BEGIN(); + + TEST_1(home = su_home_create()); + TEST_1(c = sip_content_type_make(home, "application/sdp ; charset = utf-8")); + TEST_S(c->c_type, "application/sdp"); + TEST_S(c->c_subtype, "sdp"); + TEST_1(c->c_params && c->c_params[0] && !c->c_params[1]); + TEST_S(c->c_params[0], "charset=utf-8"); + TEST_P(c->c_params[1], NULL); + + sip_content_type_init(c0); + c = sip_content_type_dup(home, c0); + TEST_P(c->c_type, NULL); + TEST_P(c->c_subtype, NULL); + + c0->c_type = "text"; + c = sip_content_type_dup(home, c0); + TEST_S(c->c_type, "text"); + TEST_P(c->c_subtype, NULL); + + su_home_unref(home); + END(); +} + + static int test_www_authenticate(void) { sip_www_authenticate_t *www; @@ -3570,6 +3601,7 @@ retval |= test_refer(); fflush(stdout); retval |= test_route(); fflush(stdout); retval |= test_request_disposition(); fflush(stdout); + retval |= test_content_type(); fflush(stdout); retval |= test_caller_prefs(); fflush(stdout); retval |= test_callerpref_scoring(); fflush(stdout); retval |= test_warning(); fflush(stdout);

1 0

[commit] r8615 - in freeswitch/trunk/libs/sofia-sip: . libsofia-sip-ua/sip
by Freeswitch SVN 25 May '08

25 May '08

Author: mikej Date: Sun May 25 10:58:59 2008 New Revision: 8615 Modified: freeswitch/trunk/libs/sofia-sip/.update freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sip/sip_util.c Log: Tue May 20 09:32:50 EDT 2008 Pekka.Pessi(a)nokia.com * sip_util.c: fixed klocwork issues Modified: freeswitch/trunk/libs/sofia-sip/.update ============================================================================== --- freeswitch/trunk/libs/sofia-sip/.update (original) +++ freeswitch/trunk/libs/sofia-sip/.update Sun May 25 10:58:59 2008 @@ -1 +1 @@ -Sun May 25 10:57:08 EDT 2008 +Sun May 25 10:58:52 EDT 2008 Modified: freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sip/sip_util.c ============================================================================== --- freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sip/sip_util.c (original) +++ freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sip/sip_util.c Sun May 25 10:58:59 2008 @@ -364,17 +364,17 @@ */ issize_t sip_header_field_d(su_home_t *home, sip_header_t *h, char *s, isize_t slen) { - assert(SIP_HDR_TEST(h)); - if (h && s && s[slen] == '\0') { size_t n = span_lws(s); s += n; slen -= n; - + for (n = slen; n >= 1 && IS_LWS(s[n - 1]); n--) ; s[n] = '\0'; + assert(SIP_HDR_TEST(h)); + return h->sh_class->hc_parse(home, h, s, slen); } else

1 0

[commit] r8614 - in freeswitch/trunk/libs/sofia-sip: . libsofia-sip-ua/sip
by Freeswitch SVN 25 May '08

25 May '08

Author: mikej Date: Sun May 25 10:57:14 2008 New Revision: 8614 Modified: freeswitch/trunk/libs/sofia-sip/.update freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sip/sip_tag_class.c Log: Tue May 20 09:32:30 EDT 2008 Pekka.Pessi(a)nokia.com * sip_tag_class.c: fixed klocwork issues Modified: freeswitch/trunk/libs/sofia-sip/.update ============================================================================== --- freeswitch/trunk/libs/sofia-sip/.update (original) +++ freeswitch/trunk/libs/sofia-sip/.update Sun May 25 10:57:14 2008 @@ -1 +1 @@ -Sun May 25 09:56:21 EDT 2008 +Sun May 25 10:57:08 EDT 2008 Modified: freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sip/sip_tag_class.c ============================================================================== --- freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sip/sip_tag_class.c (original) +++ freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sip/sip_tag_class.c Sun May 25 10:57:14 2008 @@ -158,7 +158,8 @@ (msg_pub_t *)sip, hc); /* Is header present in the SIP message? */ - if ((char *)hh >= ((char *)sip + sip->sip_size) || + if (hh == NULL || + (char *)hh >= ((char *)sip + sip->sip_size) || (char *)hh < (char *)&sip->sip_request) return dst; @@ -234,8 +235,12 @@ if (h == SIP_NONE) { /* Remove header */ hh = msg_hclass_offset(msg_mclass(msg), (msg_pub_t *)sip, hc); - while (*hh) - msg_header_remove(msg, (msg_pub_t *)sip, *hh); + if (hh != NULL && + (char *)hh < ((char *)sip + sip->sip_size) && + (char *)hh >= (char *)&sip->sip_request) { + while (*hh) + msg_header_remove(msg, (msg_pub_t *)sip, *hh); + } continue; } @@ -441,18 +446,21 @@ msg_hclass_t *hc = NULL; hnv = su_strlst_item(l, i); - n = strcspn(hnv, "="); + n = hnv ? strcspn(hnv, "=") : 0; if (n == 0) break; if (n == 4 && strncasecmp(hnv, "body", 4) == 0) t = siptag_payload, hc = sip_payload_class; - else for (j = 0; (t = sip_tag_list[j]); j++) { - hc = (msg_hclass_t *)sip_tag_list[j]->tt_magic; - if (n == 1 && strncasecmp(hnv, hc->hc_short, 1) == 0) - break; - else if (n == (size_t)hc->hc_len && strncasecmp(hnv, hc->hc_name, n) == 0) - break; + else { + for (j = 0; (t = sip_tag_list[j]); j++) { + hc = (msg_hclass_t *)sip_tag_list[j]->tt_magic; + if (n == 1 && strncasecmp(hnv, hc->hc_short, 1) == 0) + break; + else if (n == (size_t)hc->hc_len && + strncasecmp(hnv, hc->hc_name, n) == 0) + break; + } } value = (char *)hnv + n;

1 0

[commit] r8613 - in freeswitch/trunk/libs/sofia-sip: . libsofia-sip-ua/sip
by Freeswitch SVN 25 May '08

25 May '08

Author: mikej Date: Sun May 25 09:56:27 2008 New Revision: 8613 Modified: freeswitch/trunk/libs/sofia-sip/.update freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sip/sip_mime.c Log: Tue May 20 09:32:10 EDT 2008 Pekka.Pessi(a)nokia.com * sip_mime.c: use msg_content_type functions with sip_content_type Modified: freeswitch/trunk/libs/sofia-sip/.update ============================================================================== --- freeswitch/trunk/libs/sofia-sip/.update (original) +++ freeswitch/trunk/libs/sofia-sip/.update Sun May 25 09:56:27 2008 @@ -1 +1 @@ -Sun May 25 09:55:22 EDT 2008 +Sun May 25 09:56:21 EDT 2008 Modified: freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sip/sip_mime.c ============================================================================== --- freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sip/sip_mime.c (original) +++ freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sip/sip_mime.c Sun May 25 09:56:27 2008 @@ -554,46 +554,18 @@ issize_t sip_content_type_d(su_home_t *home, sip_header_t *h, char *s, isize_t slen) { - sip_content_type_t *c; - - assert(h); - - c = h->sh_content_type; - - /* "Content-type:" type/subtyp *(; parameter))) */ - if (/* Parse protocol */ - sip_version_d(&s, &c->c_type) == -1 || /* compacts token / token */ - (c->c_subtype = strchr(c->c_type, '/')) == NULL || - (*s == ';' && msg_params_d(home, &s, &c->c_params) == -1) || - (*s != '\0')) - return -1; - - c->c_subtype++; - - return 0; + return msg_content_type_d(home, (msg_header_t *)h, s, slen); } issize_t sip_content_type_e(char b[], isize_t bsiz, sip_header_t const *h, int flags) { - char *b0 = b, *end = b + bsiz; - sip_content_type_t const *c = h->sh_content_type; - - MSG_STRING_E(b, end, c->c_type); - MSG_PARAMS_E(b, end, c->c_params, flags); - MSG_TERM_E(b, end); - - return b - b0; + return msg_content_type_e(b, bsiz, (msg_header_t const *)h, flags); } static isize_t sip_content_type_dup_xtra(sip_header_t const *h, isize_t offset) { - sip_content_type_t const *c = h->sh_content_type; - - MSG_PARAMS_SIZE(offset, c->c_params); - offset += MSG_STRING_SIZE(c->c_type); - - return offset; + return msg_content_type_dup_xtra((msg_header_t *)h, offset); } /** Duplicate one #sip_content_type_t object */ @@ -601,18 +573,9 @@ char *sip_content_type_dup_one(sip_header_t *dst, sip_header_t const *src, char *b, isize_t xtra) { - sip_content_type_t *c = dst->sh_content_type; - sip_content_type_t const *o = src->sh_content_type; - char *end = b + xtra; - - b = msg_params_dup(&c->c_params, o->c_params, b, xtra); - MSG_STRING_DUP(b, c->c_type, o->c_type); - c->c_subtype = strchr(c->c_type, '/'); - c->c_subtype++; - - assert(b <= end); (void)end; - - return b; + return msg_content_type_dup_one((msg_header_t *)dst, + (msg_header_t const *)src, + b, xtra); } /* ====================================================================== */

1 0

[commit] r8612 - in freeswitch/trunk/libs/sofia-sip: . libsofia-sip-ua/msg
by Freeswitch SVN 25 May '08

25 May '08

Author: mikej Date: Sun May 25 09:55:30 2008 New Revision: 8612 Modified: freeswitch/trunk/libs/sofia-sip/.update freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/msg/msg_basic.c Log: Tue May 20 09:30:24 EDT 2008 Pekka.Pessi(a)nokia.com * msg_basic.c: fixed klocwork issues Modified: freeswitch/trunk/libs/sofia-sip/.update ============================================================================== --- freeswitch/trunk/libs/sofia-sip/.update (original) +++ freeswitch/trunk/libs/sofia-sip/.update Sun May 25 09:55:30 2008 @@ -1 +1 @@ -Sun May 25 09:54:31 EDT 2008 +Sun May 25 09:55:22 EDT 2008 Modified: freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/msg/msg_basic.c ============================================================================== --- freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/msg/msg_basic.c (original) +++ freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/msg/msg_basic.c Sun May 25 09:55:30 2008 @@ -212,10 +212,11 @@ msg_payload_t *msg_payload_create(su_home_t *home, void const *data, usize_t len) { msg_header_t *h = msg_header_alloc(home, msg_payload_class, len + 1); - msg_payload_t *pl = h->sh_payload; - if (pl) { + if (h) { + msg_payload_t *pl = (msg_payload_t *)h; char *b = msg_header_data(h->sh_common); + if (data) memcpy(b, data, len); else @@ -227,6 +228,7 @@ return pl; } + return NULL; }

1 0

[commit] r8611 - in freeswitch/trunk/libs/sofia-sip: . libsofia-sip-ua/msg
by Freeswitch SVN 25 May '08

25 May '08

Author: mikej Date: Sun May 25 09:54:56 2008 New Revision: 8611 Modified: freeswitch/trunk/libs/sofia-sip/.update freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/msg/msg_mime.c Log: Tue May 20 09:30:06 EDT 2008 Pekka.Pessi(a)nokia.com * msg_mime.c: fixed klocwork issues Modified: freeswitch/trunk/libs/sofia-sip/.update ============================================================================== --- freeswitch/trunk/libs/sofia-sip/.update (original) +++ freeswitch/trunk/libs/sofia-sip/.update Sun May 25 09:54:56 2008 @@ -1 +1 @@ -Sun May 25 09:53:58 EDT 2008 +Sun May 25 09:54:31 EDT 2008 Modified: freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/msg/msg_mime.c ============================================================================== --- freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/msg/msg_mime.c (original) +++ freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/msg/msg_mime.c Sun May 25 09:54:56 2008 @@ -1871,8 +1871,10 @@ b = msg_params_dup(&c->c_params, o->c_params, b, xtra); MSG_STRING_DUP(b, c->c_type, o->c_type); - c->c_subtype = strchr(c->c_type, '/'); - c->c_subtype++; + + c->c_subtype = c->c_type ? strchr(c->c_type, '/') : NULL; + if (c->c_subtype) + c->c_subtype++; assert(b <= end); (void)end;

1 0

[commit] r8610 - in freeswitch/trunk/libs/sofia-sip: . libsofia-sip-ua/sdp
by Freeswitch SVN 25 May '08

25 May '08

Author: mikej Date: Sun May 25 09:54:06 2008 New Revision: 8610 Modified: freeswitch/trunk/libs/sofia-sip/.update freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sdp/sdp_parse.c freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sdp/sdp_print.c Log: Tue May 20 09:29:34 EDT 2008 Pekka.Pessi(a)nokia.com * sdp: Fixed klocwork issues. Modified: freeswitch/trunk/libs/sofia-sip/.update ============================================================================== --- freeswitch/trunk/libs/sofia-sip/.update (original) +++ freeswitch/trunk/libs/sofia-sip/.update Sun May 25 09:54:06 2008 @@ -1 +1 @@ -Sun May 25 09:52:56 EDT 2008 +Sun May 25 09:53:58 EDT 2008 Modified: freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sdp/sdp_parse.c ============================================================================== --- freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sdp/sdp_parse.c (original) +++ freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sdp/sdp_parse.c Sun May 25 09:54:06 2008 @@ -98,7 +98,7 @@ /* Internal prototypes */ static void parse_message(sdp_parser_t *p); -static void parsing_error(sdp_parser_t *p, char const *fmt, ...); +static int parsing_error(sdp_parser_t *p, char const *fmt, ...); /** Parse an SDP message. * @@ -357,7 +357,7 @@ if (!STRICT(p)) strip = SPACE TAB; /* skip initial whitespace */ else - strip = NULL; + strip = ""; p->pr_ok = 1; p->pr_session->sdp_size = sizeof(p->pr_session); @@ -550,18 +550,15 @@ sdp_media_t *m; if (!p || !p->pr_ok) - ; + return -1; else if (sdp->sdp_version[0] != 0) - parsing_error(p, "Incorrect version"); + return parsing_error(p, "Incorrect version"); else if (!sdp->sdp_origin) - parsing_error(p, "No o= present"); + return parsing_error(p, "No o= present"); else if (p->pr_strict && !sdp->sdp_subject) - parsing_error(p, "No s= present"); + return parsing_error(p, "No s= present"); else if (p->pr_strict && !sdp->sdp_time) - parsing_error(p, "No t= present"); - - if (!p->pr_ok) - return -1; + return parsing_error(p, "No t= present"); /* If there is no session level c= check that one exists for all media */ /* c= line may be missing if this is a RTSP description */ @@ -1707,7 +1704,7 @@ if (!STRICT(p)) strip = SPACE TAB; /* skip initial whitespace */ else - strip = NULL; + strip = ""; for (; record && p->pr_ok; @@ -1846,7 +1843,7 @@ size_t n; char *retval = *message; - if (strip) + if (strip[0]) retval += strspn(retval, strip); n = strcspn(retval, sep); @@ -1867,7 +1864,7 @@ return retval; } -static void parsing_error(sdp_parser_t *p, char const *fmt, ...) +static int parsing_error(sdp_parser_t *p, char const *fmt, ...) { int n; va_list ap; @@ -1878,6 +1875,8 @@ va_end(ap); p->pr_ok = 0; + + return -1; } static void parse_alloc_error(sdp_parser_t *p, const char *typename) Modified: freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sdp/sdp_print.c ============================================================================== --- freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sdp/sdp_print.c (original) +++ freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/sdp/sdp_print.c Sun May 25 09:54:06 2008 @@ -681,17 +681,15 @@ static void printing_error(sdp_printer_t *p, const char *fmt, ...) { va_list ap; - va_start(ap, fmt); - + if (p->pr_ok) { int n; - + va_start(ap, fmt); n = vsnprintf(p->pr_buffer, p->pr_bsiz, fmt, ap); - - p->pr_ok = 0; + va_end(ap); } - va_end(ap); + p->pr_ok = 0; } static void sdp_printf(sdp_printer_t *p, const char *fmt, ...)

1 0

[commit] r8609 - in freeswitch/trunk/libs/sofia-sip: . libsofia-sip-ua/nua
by Freeswitch SVN 25 May '08

25 May '08

Author: mikej Date: Sun May 25 09:53:04 2008 New Revision: 8609 Modified: freeswitch/trunk/libs/sofia-sip/.update freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/nua_session.c Log: Tue May 20 07:51:51 EDT 2008 Pekka.Pessi(a)nokia.com * nua_session.c: fixed klocwork issues Modified: freeswitch/trunk/libs/sofia-sip/.update ============================================================================== --- freeswitch/trunk/libs/sofia-sip/.update (original) +++ freeswitch/trunk/libs/sofia-sip/.update Sun May 25 09:53:04 2008 @@ -1 +1 @@ -Sun May 25 09:52:17 EDT 2008 +Sun May 25 09:52:56 EDT 2008 Modified: freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/nua_session.c ============================================================================== --- freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/nua_session.c (original) +++ freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/nua_session.c Sun May 25 09:53:04 2008 @@ -223,7 +223,7 @@ nua_dialog_state_t *ds, nua_dialog_usage_t *du) { - nua_session_usage_t *ss = nua_dialog_usage_private(du); + nua_session_usage_t *ss = NUA_DIALOG_USAGE_PRIVATE(du); if (ds->ds_has_session) return -1; @@ -243,7 +243,7 @@ nua_client_request_t *cr0, nua_server_request_t *sr0) { - nua_session_usage_t *ss = nua_dialog_usage_private(du); + nua_session_usage_t *ss = NUA_DIALOG_USAGE_PRIVATE(du); nua_client_request_t *cr, *cr_next; nua_server_request_t *sr; @@ -1478,7 +1478,7 @@ nua_dialog_usage_t *du, sip_time_t now) { - nua_session_usage_t *ss = nua_dialog_usage_private(du); + nua_session_usage_t *ss = NUA_DIALOG_USAGE_PRIVATE(du); nua_client_request_t const *cr = du->du_cr; nua_server_request_t const *sr; @@ -1525,7 +1525,7 @@ nua_dialog_state_t *ds, nua_dialog_usage_t *du) { - nua_session_usage_t *ss = nua_dialog_usage_private(du); + nua_session_usage_t *ss = NUA_DIALOG_USAGE_PRIVATE(du); nua_server_request_t *sr, *sr_next; nua_client_request_t *cri; @@ -2729,7 +2729,7 @@ if (nh->nh_soa == NULL) { if (sr->sr_offer_recv && session_get_description(sip, NULL, NULL)) - sr->sr_answer_sent = 1, ss->ss_oa_sent = Answer; + sr->sr_answer_sent = 1, ss ? ss->ss_oa_sent = Answer : Answer; } else if ((sr->sr_offer_recv && soa_generate_answer(nh->nh_soa, NULL) < 0) || (sr->sr_answer_recv && soa_process_answer(nh->nh_soa, NULL) < 0)) { @@ -2743,7 +2743,7 @@ if (session_include_description(nh->nh_soa, 1, msg, sip) < 0) sr_status(sr, SIP_500_INTERNAL_SERVER_ERROR); else - sr->sr_answer_sent = 1, ss->ss_oa_sent = Answer; + sr->sr_answer_sent = 1, ss ? ss->ss_oa_sent = Answer : Answer; } } @@ -3398,7 +3398,7 @@ } sr->sr_offer_recv = 1; - ss->ss_oa_recv = Offer; + ss ? ss->ss_oa_recv = Offer : Offer; } return 0; @@ -3416,7 +3416,7 @@ if (200 <= sr->sr_status && sr->sr_status < 300 && sr->sr_sdp) { if (nh->nh_soa == NULL) { - sr->sr_answer_sent = 1, ss->ss_oa_sent = Answer; + sr->sr_answer_sent = 1, ss ? ss->ss_oa_sent = Answer : Answer; } else if (soa_generate_answer(nh->nh_soa, NULL) < 0) { SU_DEBUG_5(("nua(%p): %s server: %s %s\n",

1 0

[commit] r8608 - in freeswitch/trunk/libs/sofia-sip: . libsofia-sip-ua/nua
by Freeswitch SVN 25 May '08

25 May '08

Author: mikej Date: Sun May 25 09:52:27 2008 New Revision: 8608 Modified: freeswitch/trunk/libs/sofia-sip/.update freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/nua_publish.c Log: Tue May 20 07:46:57 EDT 2008 Pekka.Pessi(a)nokia.com * nua_publish.c: fixed klocwork issue Modified: freeswitch/trunk/libs/sofia-sip/.update ============================================================================== --- freeswitch/trunk/libs/sofia-sip/.update (original) +++ freeswitch/trunk/libs/sofia-sip/.update Sun May 25 09:52:27 2008 @@ -1 +1 @@ -Sun May 25 09:51:44 EDT 2008 +Sun May 25 09:52:17 EDT 2008 Modified: freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/nua_publish.c ============================================================================== --- freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/nua_publish.c (original) +++ freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/nua_publish.c Sun May 25 09:52:27 2008 @@ -110,7 +110,7 @@ nua_server_request_t *sr ) { - struct publish_usage *pu = nua_dialog_usage_private(du); + struct publish_usage *pu = NUA_DIALOG_USAGE_PRIVATE(du); su_free(nh->nh_home, pu->pu_etag);

1 0

[commit] r8607 - in freeswitch/trunk/libs/sofia-sip: . libsofia-sip-ua/nua
by Freeswitch SVN 25 May '08

25 May '08

Author: mikej Date: Sun May 25 09:51:51 2008 New Revision: 8607 Modified: freeswitch/trunk/libs/sofia-sip/.update freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/nua_params.c Log: Tue May 20 07:46:20 EDT 2008 Pekka.Pessi(a)nokia.com * nua_params.c: fixed klocwork issue Modified: freeswitch/trunk/libs/sofia-sip/.update ============================================================================== --- freeswitch/trunk/libs/sofia-sip/.update (original) +++ freeswitch/trunk/libs/sofia-sip/.update Sun May 25 09:51:51 2008 @@ -1 +1 @@ -Sun May 25 09:51:04 EDT 2008 +Sun May 25 09:51:44 EDT 2008 Modified: freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/nua_params.c ============================================================================== --- freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/nua_params.c (original) +++ freeswitch/trunk/libs/sofia-sip/libsofia-sip-ua/nua/nua_params.c Sun May 25 09:51:51 2008 @@ -1103,7 +1103,6 @@ if (nh == dnh || nh->nh_prefs != dnh->nh_prefs) { dst = nh->nh_prefs, *old = *dst; - assert(dst); } else { dst = su_zalloc(home, sizeof *dst), memset(old, 0, sizeof *old);

1 0