February 2007 - Freeswitch-svn - FreeSWITCH Mailing Lists

[commit] r4212 - in freeswitch/trunk/src: . include mod/formats/mod_native_file
by Freeswitch SVN 12 Feb '07

12 Feb '07

Author: anthm Date: Mon Feb 12 17:56:08 2007 New Revision: 4212 Modified: freeswitch/trunk/src/include/switch_types.h freeswitch/trunk/src/mod/formats/mod_native_file/mod_native_file.c freeswitch/trunk/src/switch_ivr.c Log: fix mod_native_file extension thingy Modified: freeswitch/trunk/src/include/switch_types.h ============================================================================== --- freeswitch/trunk/src/include/switch_types.h (original) +++ freeswitch/trunk/src/include/switch_types.h Mon Feb 12 17:56:08 2007 @@ -682,6 +682,7 @@ SWITCH_FILE_DATA_DOUBLE = (1 << 6) - Read data in doubles SWITCH_FILE_DATA_RAW = (1 << 7) - Read data as is SWITCH_FILE_PAUSE = (1 << 8) - Pause +SWITCH_FILE_NATIVE = (1 << 8) - File is in native format (no transcoding) </pre> */ typedef enum { @@ -693,7 +694,8 @@ SWITCH_FILE_DATA_FLOAT = (1 << 5), SWITCH_FILE_DATA_DOUBLE = (1 << 6), SWITCH_FILE_DATA_RAW = (1 << 7), - SWITCH_FILE_PAUSE = (1 << 8) + SWITCH_FILE_PAUSE = (1 << 8), + SWITCH_FILE_NATIVE = (1 << 9) } switch_file_flag_t; typedef enum { Modified: freeswitch/trunk/src/mod/formats/mod_native_file/mod_native_file.c ============================================================================== --- freeswitch/trunk/src/mod/formats/mod_native_file/mod_native_file.c (original) +++ freeswitch/trunk/src/mod/formats/mod_native_file/mod_native_file.c Mon Feb 12 17:56:08 2007 @@ -78,6 +78,7 @@ handle->seekable = 1; handle->speed = 0; handle->private_info = context; + handle->flags |= SWITCH_FILE_NATIVE; switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_INFO, "Opening File [%s] %dhz\n", path, handle->samplerate); Modified: freeswitch/trunk/src/switch_ivr.c ============================================================================== --- freeswitch/trunk/src/switch_ivr.c (original) +++ freeswitch/trunk/src/switch_ivr.c Mon Feb 12 17:56:08 2007 @@ -1142,6 +1142,9 @@ switch_core_session_reset(session); return SWITCH_STATUS_NOTFOUND; } + if (switch_test_flag(fh, SWITCH_FILE_NATIVE)) { + asis = 1; + } write_frame.data = abuf;

1 0

[commit] r4211 - freeswitch/trunk/src/mod/formats/mod_sndfile
by Freeswitch SVN 12 Feb '07

12 Feb '07

Author: anthm Date: Mon Feb 12 17:42:22 2007 New Revision: 4211 Modified: freeswitch/trunk/src/mod/formats/mod_sndfile/mod_sndfile.c Log: sndfile tweaks (add ul and al files and more record formats) Modified: freeswitch/trunk/src/mod/formats/mod_sndfile/mod_sndfile.c ============================================================================== --- freeswitch/trunk/src/mod/formats/mod_sndfile/mod_sndfile.c (original) +++ freeswitch/trunk/src/mod/formats/mod_sndfile/mod_sndfile.c Mon Feb 12 17:42:22 2007 @@ -34,6 +34,18 @@ static const char modname[] = "mod_sndfile"; +static switch_memory_pool_t *module_pool = NULL; + +static struct { + switch_hash_t *format_hash; +} globals; + +struct format_map { + char *ext; + char *uext; + uint32_t format; +}; + struct sndfile_context { SF_INFO sfinfo; SNDFILE *handle; @@ -46,8 +58,9 @@ sndfile_context *context; int mode = 0; char *ext; - int ready = 1; - + int ready = 0; + struct format_map *map = NULL; + if ((ext = strrchr(path, '.')) == 0) { switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "Invalid Format\n"); return SWITCH_STATUS_GENERR; @@ -72,9 +85,11 @@ return SWITCH_STATUS_MEMERR; } + map = switch_core_hash_find(globals.format_hash, ext); + if (mode & SFM_WRITE) { sf_count_t frames = 0 ; - + context->sfinfo.channels = handle->channels; context->sfinfo.samplerate = handle->samplerate; if (handle->samplerate == 8000 || handle->samplerate == 16000) { @@ -85,20 +100,19 @@ context->sfinfo.format |= SF_FORMAT_PCM_32; } - sf_command (context->handle, SFC_FILE_TRUNCATE, &frames, sizeof (frames)) ; + sf_command (context->handle, SFC_FILE_TRUNCATE, &frames, sizeof (frames)); - /* Could add more else if() but i am too lazy atm.. */ - if (!strcasecmp(ext, "wav")) { - context->sfinfo.format |= SF_FORMAT_WAV; - } else { - ready = 0; + if (map) { + context->sfinfo.format |= map->format; + ready = 1; } - } else { - ready = 0; + } else if (map) { + ready = 1; } if (!ready) { + ready = 1; if (!strcmp(ext, "r8") || !strcmp(ext, "raw")) { context->sfinfo.format = SF_FORMAT_RAW | SF_FORMAT_PCM_16; context->sfinfo.channels = 1; @@ -119,16 +133,29 @@ context->sfinfo.format = SF_FORMAT_RAW | SF_FORMAT_GSM610; context->sfinfo.channels = 1; context->sfinfo.samplerate = 8000; + } else if (!strcmp(ext, "ul")) { + context->sfinfo.format = SF_FORMAT_RAW | SF_FORMAT_ULAW; + context->sfinfo.channels = 1; + context->sfinfo.samplerate = 8000; + } else if (!strcmp(ext, "al")) { + context->sfinfo.format = SF_FORMAT_RAW | SF_FORMAT_ALAW; + context->sfinfo.channels = 1; + context->sfinfo.samplerate = 8000; + } else { + ready = 0; } } - + if (!ready) { + switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "Error Opening File [%s] [%s]\n", path); + return SWITCH_STATUS_GENERR; + } + if ((mode & SFM_WRITE) && sf_format_check (&context->sfinfo) == 0) { switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "Error : file format is invalid (0x%08X).\n", context->sfinfo.format); return SWITCH_STATUS_GENERR; }; - - + if ((context->handle = sf_open(path, mode, &context->sfinfo)) == 0) { switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "Error Opening File [%s] [%s]\n", path, sf_strerror(context->handle)); @@ -272,7 +299,7 @@ char buffer[128]; int format, major_count, subtype_count, m, s; int len, x, skip; - char *extras[] = { "r8", "r16", "r24", "r32", "gsm", NULL }; + char *extras[] = { "r8", "r16", "r24", "r32", "gsm", "ul", "al", NULL }; int exlen = (sizeof(extras) / sizeof(extras[0])); buffer[0] = 0; @@ -306,11 +333,28 @@ } } if (!skip) { + char *p; + struct format_map *map = switch_core_permanent_alloc(sizeof(*map)); + if (!map) { + abort(); + } + + map->ext = switch_core_permanent_strdup(info.extension); + map->uext = switch_core_permanent_strdup(info.extension); + map->format = info.format; + for(p = map->ext; *p; p++) { + *p = tolower(*p); + } + for(p = map->uext; *p; p++) { + *p = toupper(*p); + } + switch_core_hash_insert(globals.format_hash, map->ext, map); + switch_core_hash_insert(globals.format_hash, map->uext, map); supported_formats[len++] = (char *) info.extension; } format = info.format; - for (s = 0; s < subtype_count; s++) { + for (s = 0; s < subtype_count; s++) { info.format = s; sf_command(NULL, SFC_GET_FORMAT_SUBTYPE, &info, sizeof(info)); format = (format & SF_FORMAT_TYPEMASK) | info.format; @@ -338,7 +382,13 @@ SWITCH_MOD_DECLARE(switch_status_t) switch_module_load(const switch_loadable_module_interface_t **module_interface, char *filename) { + if (switch_core_new_memory_pool(&module_pool) != SWITCH_STATUS_SUCCESS) { + switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_CRIT, "OH OH no pool\n"); + return SWITCH_STATUS_TERM; + } + switch_core_hash_init(&globals.format_hash, module_pool); + if (setup_formats() != SWITCH_STATUS_SUCCESS) { return SWITCH_STATUS_FALSE; }

1 0

[commit] r4210 - freeswitch/trunk/src/mod/endpoints/mod_wanpipe
by Freeswitch SVN 12 Feb '07

12 Feb '07

Author: anthm Date: Mon Feb 12 16:08:57 2007 New Revision: 4210 Modified: freeswitch/trunk/src/mod/endpoints/mod_wanpipe/mod_wanpipe.c Log: simplify wanpipe write method Modified: freeswitch/trunk/src/mod/endpoints/mod_wanpipe/mod_wanpipe.c ============================================================================== --- freeswitch/trunk/src/mod/endpoints/mod_wanpipe/mod_wanpipe.c (original) +++ freeswitch/trunk/src/mod/endpoints/mod_wanpipe/mod_wanpipe.c Mon Feb 12 16:08:57 2007 @@ -119,6 +119,7 @@ switch_codec_t read_codec; switch_codec_t write_codec; unsigned char databuf[SWITCH_RECCOMMENDED_BUFFER_SIZE]; + unsigned char auxbuf[SWITCH_RECCOMMENDED_BUFFER_SIZE]; struct sangoma_pri *spri; sangoma_api_hdr_t hdrframe; switch_caller_profile_t *caller_profile; @@ -554,14 +555,14 @@ teletone_dtmf_detect (&tech_pvt->dtmf_detect, tech_pvt->read_frame.data, tech_pvt->read_frame.samples); teletone_dtmf_get(&tech_pvt->dtmf_detect, digit_str, sizeof(digit_str)); - + if(digit_str[0]) { switch_channel_queue_dtmf(channel, digit_str); if (globals.debug) { switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_DEBUG, "DTMF DETECTED: [%s]\n", digit_str); } if (globals.supress_dtmf_tone) { - memset(tech_pvt->read_frame.data, 0, tech_pvt->read_frame.datalen); + tech_pvt->skip_read_frames = 20; } } @@ -582,110 +583,43 @@ switch_io_flag_t flags, int stream_id) { private_object_t *tech_pvt; - switch_channel_t *channel = NULL; - uint32_t result = 0; - uint32_t bytes = frame->datalen; - uint8_t *bp = frame->data; - unsigned char dtmf[1024]; - uint32_t bwrote = 0; - size_t bread; - switch_status_t status = SWITCH_STATUS_SUCCESS; - - channel = switch_core_session_get_channel(session); - assert(channel != NULL); + uint32_t dtmf_blen; + void *data = frame->data; + int result = 0; tech_pvt = switch_core_session_get_private(session); assert(tech_pvt != NULL); - - while (tech_pvt->dtmf_buffer && bwrote < frame->datalen && bytes > 0 && switch_buffer_inuse(tech_pvt->dtmf_buffer) > 0) { - if (switch_test_flag(tech_pvt, TFLAG_BYE) || tech_pvt->wpsock->fd < 0) { - return SWITCH_STATUS_GENERR; - } - - if ((bread = switch_buffer_read(tech_pvt->dtmf_buffer, dtmf, tech_pvt->frame_size)) < tech_pvt->frame_size) { - while (bread < tech_pvt->frame_size) { - dtmf[bread++] = 0; - } - } - - if (sangoma_socket_waitfor(tech_pvt->wpsock->fd, 1000, POLLOUT | POLLERR | POLLHUP) <= 0) { - return SWITCH_STATUS_GENERR; - } - -#ifdef DOTRACE - write(tech_pvt->fd, dtmf, (int) bread); -#endif - result = sangoma_sendmsg_socket(tech_pvt->wpsock->fd, - &tech_pvt->hdrframe, sizeof(tech_pvt->hdrframe), dtmf, (unsigned short)bread, 0); - if (result < 0) { - switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, - "Bad Write %d bytes returned %d (%s)!\n", bread, - result, strerror(errno)); - if (errno == EBUSY) { - continue; - } - switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "Write Failed!\n"); - status = SWITCH_STATUS_GENERR; - break; - } else { - bytes -= result; - bwrote += result; - bp += result; - result = 0; - } - } - if (switch_test_flag(tech_pvt, TFLAG_BYE) || tech_pvt->wpsock->fd < 0) { return SWITCH_STATUS_GENERR; } + if (tech_pvt->dtmf_buffer && (dtmf_blen = switch_buffer_inuse(tech_pvt->dtmf_buffer))) { + uint32_t len = dtmf_blen > frame->datalen ? frame->datalen : dtmf_blen; + + switch_buffer_read(tech_pvt->dtmf_buffer, tech_pvt->auxbuf, len); + if (len < frame->datalen) { + memcpy(frame->data + len, tech_pvt->auxbuf + len, frame->datalen - len); + } + data= tech_pvt->auxbuf; + } + if (tech_pvt->skip_write_frames) { tech_pvt->skip_write_frames--; return SWITCH_STATUS_SUCCESS; } - while (bytes > 0) { - uint32_t towrite; - -#if 1 - if (sangoma_socket_waitfor(tech_pvt->wpsock->fd, 1000, POLLOUT | POLLERR | POLLHUP) <= 0) { - return SWITCH_STATUS_GENERR; - } -#endif - -#ifdef DOTRACE - write(tech_pvt->fd, bp, (int) tech_pvt->frame_size); +#ifdef DOTRACE + write(tech_pvt->fd, data, frame->datalen); #endif - towrite = bytes >= tech_pvt->frame_size ? tech_pvt->frame_size : bytes; - if (towrite < tech_pvt->frame_size) { - int diff = tech_pvt->frame_size - towrite; - memset(bp + towrite, 0, diff); - towrite = tech_pvt->frame_size; - } - - result = sangoma_sendmsg_socket(tech_pvt->wpsock->fd, - &tech_pvt->hdrframe, sizeof(tech_pvt->hdrframe), bp, (unsigned short)towrite, 0); - if (result < 0) { - switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, - "Bad Write frame len %u write %d bytes returned %d (%s)!\n", towrite, - tech_pvt->frame_size, result, strerror(errno)); - if (errno == EBUSY) { - continue; - } - switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "Write Failed!\n"); - status = SWITCH_STATUS_GENERR; - break; - } else { - bytes -= result; - bp += result; - result = 0; - } - } + result = sangoma_sendmsg_socket(tech_pvt->wpsock->fd, &tech_pvt->hdrframe, sizeof(tech_pvt->hdrframe), data, frame->datalen, 0); - //printf("write %d %d\n", frame->datalen, status); - return status; + if (result < 0 && errno != EBUSY) { + return SWITCH_STATUS_GENERR; + } + + return SWITCH_STATUS_SUCCESS; } static switch_status_t wanpipe_send_dtmf(switch_core_session_t *session, char *digits)

1 0

[commit] r4209 - freeswitch/trunk/src/mod/applications/mod_conference
by Freeswitch SVN 12 Feb '07

12 Feb '07

Author: mikej Date: Mon Feb 12 15:30:13 2007 New Revision: 4209 Modified: freeswitch/trunk/src/mod/applications/mod_conference/mod_conference.c Log: data pulled from xml needs to be duped in order for it to stay around for sure. Modified: freeswitch/trunk/src/mod/applications/mod_conference/mod_conference.c ============================================================================== --- freeswitch/trunk/src/mod/applications/mod_conference/mod_conference.c (original) +++ freeswitch/trunk/src/mod/applications/mod_conference/mod_conference.c Mon Feb 12 15:30:13 2007 @@ -4357,7 +4357,7 @@ action = (caller_control_action_t *)switch_core_alloc(conference->pool, sizeof(caller_control_action_t)); if (action != NULL) { action->fndesc = &ccfntbl[i]; - action->data = (void *)data; + action->data = (void *)switch_core_strdup(conference->pool, data); status = switch_ivr_digit_stream_parser_set_event(conference->dtmf_parser, val, action); } else { switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "unable to alloc memory for caller control binding '%s' to '%s'\n", ccfntbl[i].key, ccfntbl[i].digits);

1 0

[commit] r4208 - in freeswitch/trunk/src: include mod/applications/mod_dptools
by Freeswitch SVN 12 Feb '07

12 Feb '07

Author: anthm Date: Mon Feb 12 15:03:29 2007 New Revision: 4208 Modified: freeswitch/trunk/src/include/switch_types.h freeswitch/trunk/src/mod/applications/mod_dptools/mod_dptools.c Log: tweaks Modified: freeswitch/trunk/src/include/switch_types.h ============================================================================== --- freeswitch/trunk/src/include/switch_types.h (original) +++ freeswitch/trunk/src/include/switch_types.h Mon Feb 12 15:03:29 2007 @@ -35,7 +35,7 @@ #define SWITCH_TYPES_H #include <switch.h> - +#include <ctype.h> SWITCH_BEGIN_EXTERN_C #ifdef WIN32 Modified: freeswitch/trunk/src/mod/applications/mod_dptools/mod_dptools.c ============================================================================== --- freeswitch/trunk/src/mod/applications/mod_dptools/mod_dptools.c (original) +++ freeswitch/trunk/src/mod/applications/mod_dptools/mod_dptools.c Mon Feb 12 15:03:29 2007 @@ -610,7 +610,7 @@ /* long_desc */ "Pre-Answer the call for a channel.", /* short_desc */ "Pre-Answer the call", /* syntax */ "", - /*.next */ &hangup_application_interface + /*.next */ &answer_application_interface };

1 0

[commit] r4207 - freeswitch/trunk/src/mod/dialplans/mod_dialplan_xml
by Freeswitch SVN 12 Feb '07

12 Feb '07

Author: mikej Date: Mon Feb 12 14:55:12 2007 New Revision: 4207 Modified: freeswitch/trunk/src/mod/dialplans/mod_dialplan_xml/mod_dialplan_xml.c Log: avoid array out of bounds. Modified: freeswitch/trunk/src/mod/dialplans/mod_dialplan_xml/mod_dialplan_xml.c ============================================================================== --- freeswitch/trunk/src/mod/dialplans/mod_dialplan_xml/mod_dialplan_xml.c (original) +++ freeswitch/trunk/src/mod/dialplans/mod_dialplan_xml/mod_dialplan_xml.c Mon Feb 12 14:55:12 2007 @@ -203,7 +203,7 @@ switch_stream_handle_t stream = {0}; switch_size_t encode_len = 1024, new_len = 0; char *encode_buf = NULL; - char *prof[11] = {0}, *prof_names[11] = {0}, *e = NULL; + char *prof[12] = {0}, *prof_names[12] = {0}, *e = NULL; switch_hash_index_t *hi; uint32_t x = 0; char *alt_path = (char *) arg;

1 0

[commit] r4206 - freeswitch/trunk/src
by Freeswitch SVN 12 Feb '07

12 Feb '07

Author: mikej Date: Mon Feb 12 14:35:09 2007 New Revision: 4206 Modified: freeswitch/trunk/src/switch_rtp.c Log: ntohs takes u_short, and we are in a 16 bit bitfield, so we can cast this. Modified: freeswitch/trunk/src/switch_rtp.c ============================================================================== --- freeswitch/trunk/src/switch_rtp.c (original) +++ freeswitch/trunk/src/switch_rtp.c Mon Feb 12 14:35:09 2007 @@ -1194,7 +1194,7 @@ } rtp_session->last_write_ts = ntohl(send_msg->header.ts); - rtp_session->last_write_seq = ntohs(send_msg->header.seq); + rtp_session->last_write_seq = ntohs((u_short)send_msg->header.seq); if (send) { switch_socket_sendto(rtp_session->sock, rtp_session->remote_addr, 0, (void*)send_msg, &bytes);

1 0

[commit] r4205 - freeswitch/trunk/libs/sofia-sip/packages
by Freeswitch SVN 12 Feb '07

12 Feb '07

Author: mikej Date: Mon Feb 12 13:29:52 2007 New Revision: 4205 Modified: freeswitch/trunk/libs/sofia-sip/packages/sofia-sip-1.12.5.spec Log: add missing spec file updates Modified: freeswitch/trunk/libs/sofia-sip/packages/sofia-sip-1.12.5.spec ============================================================================== --- freeswitch/trunk/libs/sofia-sip/packages/sofia-sip-1.12.5.spec (original) +++ freeswitch/trunk/libs/sofia-sip/packages/sofia-sip-1.12.5.spec Mon Feb 12 13:29:52 2007 @@ -12,15 +12,15 @@ BuildRequires: pkgconfig -%{!?bcond_with:%define bcond_with() %{expand:%%{?_with_%{1}:%%global with_%{1} 1}}} -%{!?bcond_without:%define bcond_without() %{expand:%%{!?_without_%{1}:%%global with_%{1} 1}}} +%define opt_with() %{expand:%%global with_%{1} %%{?_with_%{1}:1}%%{?!_with_%{1}:0}} +%define opt_without() %{expand:%%global with_%{1} %%{!?_without_%{1}:1}%%{?_without_%{1}:0}} # Options: -%bcond_with doxygen - Generate documents using doxygen and dot -%bcond_with check - Run tests -%bcond_with openssl - Always use OpenSSL (TLS) -%bcond_with glib - Always use glib-2.0 (>= 2.2) -%bcond_with sctp - Include SCTP transport +%opt_with doxygen - Generate documents using doxygen and dot +%opt_with check - Run tests +%opt_with openssl - Always use OpenSSL (TLS) +%opt_with glib - Always use glib-2.0 (>= 2.2) +%opt_with sctp - Include SCTP transport %define have_doxygen %{?_with_doxygen:1}%{!?_with_doxygen:0} %define have_openssl %(%{?!_with_openssl:pkg-config 'openssl >= 0.9.7'&&}echo 1||echo 0) @@ -49,7 +49,7 @@ %if !%{have_glib} options="$options --without-glib" %endif -%if %{with sctp} +%if %{with_sctp} options="$options --enable-sctp" %endif @@ -62,7 +62,7 @@ # XXX comment next line to build with non-check aware rpmbuild. %check -%if %{with check} +%if %{with_check} make check %endif @@ -126,7 +126,7 @@ Development package for Sofia SIP UA library. This package includes static libraries and include files. -%if %{without doxygen} +%if !%{with_doxygen} The reference documentation for Sofia SIP UA library is available at <http://sofia-sip.sourceforge.net/development.html> %endif

1 0

[commit] r4204 - freeswitch/trunk/src
by Freeswitch SVN 12 Feb '07

12 Feb '07

Author: anthm Date: Mon Feb 12 13:22:30 2007 New Revision: 4204 Modified: freeswitch/trunk/src/switch_rtp.c Log: alternate which devices we support with the ones we don't using rfc2833 Modified: freeswitch/trunk/src/switch_rtp.c ============================================================================== --- freeswitch/trunk/src/switch_rtp.c (original) +++ freeswitch/trunk/src/switch_rtp.c Mon Feb 12 13:22:30 2007 @@ -135,6 +135,8 @@ void *private_data; uint32_t ts; + uint32_t last_write_ts; + uint16_t last_write_seq; uint32_t flags; switch_memory_pool_t *pool; switch_sockaddr_t *from_addr; @@ -655,13 +657,16 @@ for (x = 0; x < loops; x++) { switch_rtp_write_manual(rtp_session, rtp_session->dtmf_data.out_digit_packet, 4, 0, rtp_session->te, rtp_session->dtmf_data.timestamp_dtmf, - rtp_session->dtmf_data.out_digit_seq++, &flags); - switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_DEBUG, "Send %s packet for [%c] ts=%d sofar=%u dur=%d\n", + rtp_session->dtmf_data.out_digit_seq, &flags); + switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_DEBUG, "Send %s packet for [%c] ts=%d sofar=%u dur=%d seq=%d\n", loops == 1 ? "middle" : "end", rtp_session->dtmf_data.out_digit, rtp_session->dtmf_data.timestamp_dtmf, rtp_session->dtmf_data.out_digit_sofar, - duration); + duration, + rtp_session->dtmf_data.out_digit_seq); + + rtp_session->dtmf_data.out_digit_seq++; } } @@ -680,8 +685,11 @@ rtp_session->dtmf_data.out_digit_packet[1] = 7; //ts = rtp_session->dtmf_data.timestamp_dtmf += samples; - rtp_session->dtmf_data.timestamp_dtmf++; + //rtp_session->dtmf_data.timestamp_dtmf++; + rtp_session->dtmf_data.timestamp_dtmf = rtp_session->last_write_ts; + rtp_session->dtmf_data.out_digit_seq = rtp_session->last_write_seq; + for (x = 0; x < 3; x++) { switch_rtp_write_manual(rtp_session, @@ -690,15 +698,17 @@ switch_test_flag(rtp_session, SWITCH_RTP_FLAG_BUGGY_2833) ? 0 : 1, rtp_session->te, rtp_session->dtmf_data.timestamp_dtmf, - rtp_session->dtmf_data.out_digit_seq++, + rtp_session->dtmf_data.out_digit_seq, &flags); switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_DEBUG, - "Send start packet for [%c] ts=%d sofar=%u dur=%d\n", + "Send start packet for [%c] ts=%d sofar=%u dur=%d seq=%d\n", rtp_session->dtmf_data.out_digit, rtp_session->dtmf_data.timestamp_dtmf, rtp_session->dtmf_data.out_digit_sofar, - 0); + 0, + rtp_session->dtmf_data.out_digit_seq); + rtp_session->dtmf_data.out_digit_seq++; } free(rdigit); @@ -1183,6 +1193,9 @@ } } + rtp_session->last_write_ts = ntohl(send_msg->header.ts); + rtp_session->last_write_seq = ntohs(send_msg->header.seq); + if (send) { switch_socket_sendto(rtp_session->sock, rtp_session->remote_addr, 0, (void*)send_msg, &bytes); } @@ -1299,7 +1312,6 @@ return -1; } - rtp_session->ts += ts; rtp_session->send_msg.header.seq = htons(mseq); rtp_session->send_msg.header.ts = htonl(ts);

1 0

[commit] r4203 - in freeswitch/trunk/src: . include mod/endpoints/mod_portaudio
by Freeswitch SVN 12 Feb '07

12 Feb '07

Author: mikej Date: Mon Feb 12 13:13:14 2007 New Revision: 4203 Modified: freeswitch/trunk/src/include/switch_utils.h freeswitch/trunk/src/mod/endpoints/mod_portaudio/mod_portaudio.c freeswitch/trunk/src/switch_caller.c freeswitch/trunk/src/switch_ivr.c Log: some more protection from passing around and printing null values, we are now initializing null's passed to switch_caller_profile_new as blank strings in the caller profile, if your using any caller profile values in if's, please use !switch_strlen_zero() in your check. Modified: freeswitch/trunk/src/include/switch_utils.h ============================================================================== --- freeswitch/trunk/src/include/switch_utils.h (original) +++ freeswitch/trunk/src/include/switch_utils.h Mon Feb 12 13:13:14 2007 @@ -200,6 +200,13 @@ #define switch_strlen_zero(s) (!s || *s == '\0') /*! + \brief Make a null string a blank string instead + \param s the string to test + \return the original string or blank string. +*/ +#define switch_str_nil(s) (s ? s : "") + +/*! \brief Wait a desired number of microseconds and yield the CPU */ #if defined(HAVE_USLEEP) Modified: freeswitch/trunk/src/mod/endpoints/mod_portaudio/mod_portaudio.c ============================================================================== --- freeswitch/trunk/src/mod/endpoints/mod_portaudio/mod_portaudio.c (original) +++ freeswitch/trunk/src/mod/endpoints/mod_portaudio/mod_portaudio.c Mon Feb 12 13:13:14 2007 @@ -849,7 +849,7 @@ if (outbound_profile) { char name[128]; - char *id = outbound_profile->caller_id_number ? outbound_profile->caller_id_number : "na"; + char *id = !switch_strlen_zero(outbound_profile->caller_id_number) ? outbound_profile->caller_id_number : "na"; snprintf(name, sizeof(name), "PortAudio/%s", id); switch_channel_set_name(channel, name); Modified: freeswitch/trunk/src/switch_caller.c ============================================================================== --- freeswitch/trunk/src/switch_caller.c (original) +++ freeswitch/trunk/src/switch_caller.c Mon Feb 12 13:13:14 2007 @@ -53,17 +53,17 @@ if (!context) { context = "default"; } - profile->username = switch_core_strdup(pool, username); - profile->dialplan = switch_core_strdup(pool, dialplan); - profile->caller_id_name = switch_core_strdup(pool, caller_id_name); - profile->caller_id_number = switch_core_strdup(pool, caller_id_number); - profile->network_addr = switch_core_strdup(pool, network_addr); - profile->ani = switch_core_strdup(pool, ani); - profile->aniii = switch_core_strdup(pool, aniii); - profile->rdnis = switch_core_strdup(pool, rdnis); - profile->source = switch_core_strdup(pool, source); - profile->context = switch_core_strdup(pool, context); - profile->destination_number = switch_core_strdup(pool, destination_number); + profile->username = switch_core_strdup(pool, switch_str_nil(username)); + profile->dialplan = switch_core_strdup(pool, switch_str_nil(dialplan)); + profile->caller_id_name = switch_core_strdup(pool, switch_str_nil(caller_id_name)); + profile->caller_id_number = switch_core_strdup(pool, switch_str_nil(caller_id_number)); + profile->network_addr = switch_core_strdup(pool, switch_str_nil(network_addr)); + profile->ani = switch_core_strdup(pool, switch_str_nil(ani)); + profile->aniii = switch_core_strdup(pool, switch_str_nil(aniii)); + profile->rdnis = switch_core_strdup(pool, switch_str_nil(rdnis)); + profile->source = switch_core_strdup(pool, switch_str_nil(source)); + profile->context = switch_core_strdup(pool, switch_str_nil(context)); + profile->destination_number = switch_core_strdup(pool, switch_str_nil(destination_number)); switch_set_flag(profile, SWITCH_CPF_SCREEN); } @@ -145,55 +145,55 @@ char header_name[1024]; - if (caller_profile->username) { + if (!switch_strlen_zero(caller_profile->username)) { snprintf(header_name, sizeof(header_name), "%s-Username", prefix); switch_event_add_header(event, SWITCH_STACK_BOTTOM, header_name, "%s", caller_profile->username); } - if (caller_profile->dialplan) { + if (!switch_strlen_zero(caller_profile->dialplan)) { snprintf(header_name, sizeof(header_name), "%s-Dialplan", prefix); switch_event_add_header(event, SWITCH_STACK_BOTTOM, header_name, "%s", caller_profile->dialplan); } - if (caller_profile->caller_id_name) { + if (!switch_strlen_zero(caller_profile->caller_id_name)) { snprintf(header_name, sizeof(header_name), "%s-Caller-ID-Name", prefix); switch_event_add_header(event, SWITCH_STACK_BOTTOM, header_name, "%s", caller_profile->caller_id_name); } - if (caller_profile->caller_id_number) { + if (!switch_strlen_zero(caller_profile->caller_id_number)) { snprintf(header_name, sizeof(header_name), "%s-Caller-ID-Number", prefix); switch_event_add_header(event, SWITCH_STACK_BOTTOM, header_name, "%s", caller_profile->caller_id_number); } - if (caller_profile->network_addr) { + if (!switch_strlen_zero(caller_profile->network_addr)) { snprintf(header_name, sizeof(header_name), "%s-Network-Addr", prefix); switch_event_add_header(event, SWITCH_STACK_BOTTOM, header_name, "%s", caller_profile->network_addr); } - if (caller_profile->ani) { + if (!switch_strlen_zero(caller_profile->ani)) { snprintf(header_name, sizeof(header_name), "%s-ANI", prefix); switch_event_add_header(event, SWITCH_STACK_BOTTOM, header_name, "%s", caller_profile->ani); } - if (caller_profile->aniii) { + if (!switch_strlen_zero(caller_profile->aniii)) { snprintf(header_name, sizeof(header_name), "%s-ANI-II", prefix); switch_event_add_header(event, SWITCH_STACK_BOTTOM, header_name, "%s", caller_profile->aniii); } - if (caller_profile->destination_number) { + if (!switch_strlen_zero(caller_profile->destination_number)) { snprintf(header_name, sizeof(header_name), "%s-Destination-Number", prefix); switch_event_add_header(event, SWITCH_STACK_BOTTOM, header_name, "%s", caller_profile->destination_number); } - if (caller_profile->uuid) { + if (!switch_strlen_zero(caller_profile->uuid)) { snprintf(header_name, sizeof(header_name), "%s-Unique-ID", prefix); switch_event_add_header(event, SWITCH_STACK_BOTTOM, header_name, "%s", caller_profile->uuid); } - if (caller_profile->source) { + if (!switch_strlen_zero(caller_profile->source)) { snprintf(header_name, sizeof(header_name), "%s-Source", prefix); switch_event_add_header(event, SWITCH_STACK_BOTTOM, header_name, "%s", caller_profile->source); } - if (caller_profile->context) { + if (!switch_strlen_zero(caller_profile->context)) { snprintf(header_name, sizeof(header_name), "%s-Context", prefix); switch_event_add_header(event, SWITCH_STACK_BOTTOM, header_name, "%s", caller_profile->context); } - if (caller_profile->rdnis) { + if (!switch_strlen_zero(caller_profile->rdnis)) { snprintf(header_name, sizeof(header_name), "%s-RDNIS", prefix); switch_event_add_header(event, SWITCH_STACK_BOTTOM, header_name, "%s", caller_profile->rdnis); } - if (caller_profile->chan_name) { + if (!switch_strlen_zero(caller_profile->chan_name)) { snprintf(header_name, sizeof(header_name), "%s-Channel-Name", prefix); switch_event_add_header(event, SWITCH_STACK_BOTTOM, header_name, "%s", caller_profile->chan_name); } Modified: freeswitch/trunk/src/switch_ivr.c ============================================================================== --- freeswitch/trunk/src/switch_ivr.c (original) +++ freeswitch/trunk/src/switch_ivr.c Mon Feb 12 13:13:14 2007 @@ -3642,13 +3642,13 @@ new_profile = switch_caller_profile_clone(session, profile); new_profile->destination_number = switch_core_session_strdup(session, extension); - if (dialplan) { + if (!switch_strlen_zero(dialplan)) { new_profile->dialplan = switch_core_session_strdup(session, dialplan); } else { dialplan = new_profile->dialplan; } - if (context) { + if (!switch_strlen_zero(context)) { new_profile->context = switch_core_session_strdup(session, context); } else { context = new_profile->context;

1 0