[Freeswitch-dev] Removing SDP from 183/180
Hi All. I just wrote this patch. It ads 'sip_remove_183sdp' flag, which removes SDP from 183 and returns 180 (it also removes SDP from 180, because FS changes 180 with SDP to 183). To turn it on add {sip_remove_183sdp=true} to the dial string. Why? Because in some situations we don't want to transfer voice between clients before a real call establishment (and yes, I know that early media in this stage is allowed by RFC). Real case: Try to setup two clients, one of them using Sipdroid. Turn on bypass mode. Try to call to Sipdroid client, you will hear caller voice together with the ring (because Sipdroid sends 180 with SDP, and puts voice on the speaker). Patch attached. -- Artur Cichocki
this functionality is already implemented with {ignore_early_media=ring_ready} On Fri, May 27, 2011 at 3:12 AM, Artur Cichocki <acichocki@supermedia.pl> wrote:
Hi All.
I just wrote this patch. It ads 'sip_remove_183sdp' flag, which removes SDP from 183 and returns 180 (it also removes SDP from 180, because FS changes 180 with SDP to 183).
To turn it on add {sip_remove_183sdp=true} to the dial string.
Why? Because in some situations we don't want to transfer voice between clients before a real call establishment (and yes, I know that early media in this stage is allowed by RFC).
Real case: Try to setup two clients, one of them using Sipdroid. Turn on bypass mode. Try to call to Sipdroid client, you will hear caller voice together with the ring (because Sipdroid sends 180 with SDP, and puts voice on the speaker).
Patch attached.
-- Artur Cichocki
_______________________________________________ Join us at ClueCon 2011, Aug 9-11, Chicago http://www.cluecon.com 877-7-4ACLUE
FreeSWITCH-dev mailing list FreeSWITCH-dev@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev http://www.freeswitch.org
-- Anthony Minessale II FreeSWITCH http://www.freeswitch.org/ ClueCon http://www.cluecon.com/ Twitter: http://twitter.com/FreeSWITCH_wire AIM: anthm MSN:anthony_minessale@hotmail.com GTALK/JABBER/PAYPAL:anthony.minessale@gmail.com IRC: irc.freenode.net #freeswitch FreeSWITCH Developer Conference sip:888@conference.freeswitch.org googletalk:conf+888@conference.freeswitch.org pstn:+19193869900
W dniu 27.06.2011 21:58, Anthony Minessale pisze:
this functionality is already implemented with {ignore_early_media=ring_ready}
I tried all combinations of ignore_early_media with bybass-media, it didn't work. According to http://wiki.freeswitch.org/wiki/Early_Media: " Troubleshooting * Be certain that you have inbound-bypass-media turned off " And I want to have it turned on. -- Artur Cichocki
* Be certain that you have inbound-bypass-media turned off " And I want to have it turned on. If you need to not send 183, then you MUST have bypass_media enabled. I have tested it and it works. Just so you know, if FS is not doing media, that means its not sending 183, hence someone (other app) needs to do it. Hence bypass_media need to be true Prashant Lamba Phonologies On Wed, Jun 29, 2011 at 5:37 PM, Artur Cichocki <acichocki@supermedia.pl>wrote:
W dniu 27.06.2011 21:58, Anthony Minessale pisze:
this functionality is already implemented with {ignore_early_media=ring_ready}
I tried all combinations of ignore_early_media with bybass-media, it didn't work.
According to http://wiki.freeswitch.org/wiki/Early_Media: " Troubleshooting
* Be certain that you have inbound-bypass-media turned off "
And I want to have it turned on.
-- Artur Cichocki
_______________________________________________ Join us at ClueCon 2011, Aug 9-11, Chicago http://www.cluecon.com 877-7-4ACLUE
FreeSWITCH-dev mailing list FreeSWITCH-dev@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev http://www.freeswitch.org
W dniu 02.07.2011 13:16, Prashant Lamba pisze:
* Be certain that you have inbound-bypass-media turned off " And I want to have it turned on.
If you need to not send 183, then you MUST have bypass_media enabled. I have tested it and it works. Just so you know, if FS is not doing media, that means its not sending 183, hence someone (other app) needs to do it. Hence bypass_media need to be true
That's not the point. Check my original mail please. The patch is to deny media before real connection establishment with bypas_media on. And that functionality doesn't exist in current FS code. -- Artur Cichocki
And I want to have it turned on.
Be aware then that if FS were to ignore the 180 and not pass it along to the caller, then the callee would already be sending the early media directly to the caller. They'll ignore it sure but it'll still be consuming their bandwidth and be visible to the user if they wanted to use something like Wireshark. -Steve On 29 June 2011 13:07, Artur Cichocki <acichocki@supermedia.pl> wrote:
W dniu 27.06.2011 21:58, Anthony Minessale pisze:
this functionality is already implemented with {ignore_early_media=ring_ready}
I tried all combinations of ignore_early_media with bybass-media, it didn't work.
According to http://wiki.freeswitch.org/wiki/Early_Media: " Troubleshooting
* Be certain that you have inbound-bypass-media turned off "
And I want to have it turned on.
-- Artur Cichocki
_______________________________________________ Join us at ClueCon 2011, Aug 9-11, Chicago http://www.cluecon.com 877-7-4ACLUE
FreeSWITCH-dev mailing list FreeSWITCH-dev@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev http://www.freeswitch.org
participants (4)
-
Anthony Minessale
-
Artur Cichocki
-
Prashant Lamba
-
Steven Ayre