[Freeswitch-dev] Mod conference, dial commad dont work without default profile + patch
Hello, I deleted default profile from conference.conf.xml and from that time I could not connect second outgoing channel to conference. I located problem in searching for conference with 'switch_core_hash_find' function. Only name of conference is stored in hash so looking for something like 'name@profile' did not find any. In my opinion it always used second attempt to dial when conference was not found, and it successes only if default profile is available. There is also bgdial problem which do not allow to call to not existing conference, but in function conf_api_sub_bgdial it looks like it was meant to work. I have to know freeswitch code better to fix it. I created patch to solve first problem. This is my first patch so please give me comments so next time I do it better. I choose this way to learn how freeswitch modules are made. I would also like if someone could review my patch and tell me if this is a way mod_conference should work. I assumed that looking for conference is for connecting members to existing conference, and that it's should work like that. Previously it did not find conference if profile was given in command. Szymon Olko
The best way to submit patches is to file it on jia so it gets a ticket number and is properly reviewed. http://jira.freeswitch.org 2009/3/25 Szymon Olko <solko@gcdf.pl>
Hello,
I deleted default profile from conference.conf.xml and from that time I could not connect second outgoing channel to conference.
I located problem in searching for conference with 'switch_core_hash_find' function. Only name of conference is stored in hash so looking for something like 'name@profile' did not find any. In my opinion it always used second attempt to dial when conference was not found, and it successes only if default profile is available.
There is also bgdial problem which do not allow to call to not existing conference, but in function conf_api_sub_bgdial it looks like it was meant to work. I have to know freeswitch code better to fix it.
I created patch to solve first problem. This is my first patch so please give me comments so next time I do it better. I choose this way to learn how freeswitch modules are made. I would also like if someone could review my patch and tell me if this is a way mod_conference should work. I assumed that looking for conference is for connecting members to existing conference, and that it's should work like that. Previously it did not find conference if profile was given in command.
Szymon Olko
_______________________________________________ Freeswitch-dev mailing list Freeswitch-dev@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev http://www.freeswitch.org
-- Anthony Minessale II FreeSWITCH http://www.freeswitch.org/ ClueCon http://www.cluecon.com/ AIM: anthm MSN:anthony_minessale@hotmail.com <MSN%3Aanthony_minessale@hotmail.com> GTALK/JABBER/PAYPAL:anthony.minessale@gmail.com<PAYPAL%3Aanthony.minessale@gmail.com> IRC: irc.freenode.net #freeswitch FreeSWITCH Developer Conference sip:888@conference.freeswitch.org <sip%3A888@conference.freeswitch.org> iax:guest@conference.freeswitch.org/888 googletalk:conf+888@conference.freeswitch.org<googletalk%3Aconf%2B888@conference.freeswitch.org> pstn:213-799-1400
Anthony Minessale pisze:
The best way to submit patches is to file it on jia so it gets a ticket number and is properly reviewed. http://jira.freeswitch.org
I did it as you proposed. You fixed that your way, which of course is better. I know You are busy so no time to educate me, but I would be very graceful for short comment to my patch. Changing subject... I really like FS idea and design. I would like to make some code for FS in my free time. I know I have to learn a lot, I looked at FS code but the best to know it is to make real development. Is there any TODO list with modules that are requested/needed to be done? I could start with simple not urgent module and this way get knowledge to make more advanced things. Regards Szymon Olko
2009/3/25 Szymon Olko <solko@gcdf.pl>
Hello,
I deleted default profile from conference.conf.xml and from that time I could not connect second outgoing channel to conference.
I located problem in searching for conference with 'switch_core_hash_find' function. Only name of conference is stored in hash so looking for something like 'name@profile' did not find any. In my opinion it always used second attempt to dial when conference was not found, and it successes only if default profile is available.
There is also bgdial problem which do not allow to call to not existing conference, but in function conf_api_sub_bgdial it looks like it was meant to work. I have to know freeswitch code better to fix it.
I created patch to solve first problem. This is my first patch so please give me comments so next time I do it better. I choose this way to learn how freeswitch modules are made. I would also like if someone could review my patch and tell me if this is a way mod_conference should work. I assumed that looking for conference is for connecting members to existing conference, and that it's should work like that. Previously it did not find conference if profile was given in command.
Szymon Olko
_______________________________________________ Freeswitch-dev mailing list Freeswitch-dev@lists.freeswitch.org <mailto:Freeswitch-dev@lists.freeswitch.org> http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev http://www.freeswitch.org
-- Anthony Minessale II
FreeSWITCH http://www.freeswitch.org/ ClueCon http://www.cluecon.com/
AIM: anthm MSN:anthony_minessale@hotmail.com <mailto:MSN%3Aanthony_minessale@hotmail.com> GTALK/JABBER/PAYPAL:anthony.minessale@gmail.com <mailto:PAYPAL%3Aanthony.minessale@gmail.com> IRC: irc.freenode.net <http://irc.freenode.net> #freeswitch
FreeSWITCH Developer Conference sip:888@conference.freeswitch.org <mailto:sip%3A888@conference.freeswitch.org> iax:guest@conference.freeswitch.org/888 <http://iax:guest@conference.freeswitch.org/888> googletalk:conf+888@conference.freeswitch.org <mailto:googletalk%3Aconf%2B888@conference.freeswitch.org> pstn:213-799-1400
------------------------------------------------------------------------
_______________________________________________ Freeswitch-dev mailing list Freeswitch-dev@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev http://www.freeswitch.org
The best way would be to join the #freeswitch-dev irc channel and discuss your skill level and interest with us so we can give some real time direction on things you could handle. Mike On Apr 1, 2009, at 6:23 AM, Szymon Olko <solko@gcdf.pl> wrote:
Anthony Minessale pisze:
The best way to submit patches is to file it on jia so it gets a ticket number and is properly reviewed. http://jira.freeswitch.org
I did it as you proposed. You fixed that your way, which of course is better. I know You are busy so no time to educate me, but I would be very graceful for short comment to my patch.
Changing subject... I really like FS idea and design. I would like to make some code for FS in my free time. I know I have to learn a lot, I looked at FS code but the best to know it is to make real development. Is there any TODO list with modules that are requested/needed to be done? I could start with simple not urgent module and this way get knowledge to make more advanced things.
Regards Szymon Olko
2009/3/25 Szymon Olko <solko@gcdf.pl>
Hello,
I deleted default profile from conference.conf.xml and from that time I could not connect second outgoing channel to conference.
I located problem in searching for conference with 'switch_core_hash_find' function. Only name of conference is stored in hash so looking for something like 'name@profile' did not find any. In my opinion it always used second attempt to dial when conference was not found, and it successes only if default profile is available.
There is also bgdial problem which do not allow to call to not existing conference, but in function conf_api_sub_bgdial it looks like it was meant to work. I have to know freeswitch code better to fix it.
I created patch to solve first problem. This is my first patch so please give me comments so next time I do it better. I choose this way to learn how freeswitch modules are made. I would also like if someone could review my patch and tell me if this is a way mod_conference should work. I assumed that looking for conference is for connecting members to existing conference, and that it's should work like that. Previously it did not find conference if profile was given in command.
Szymon Olko
_______________________________________________ Freeswitch-dev mailing list Freeswitch-dev@lists.freeswitch.org <mailto:Freeswitch-dev@lists.freeswitch.org> http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev http://www.freeswitch.org
-- Anthony Minessale II
FreeSWITCH http://www.freeswitch.org/ ClueCon http://www.cluecon.com/
AIM: anthm MSN:anthony_minessale@hotmail.com <mailto:MSN%3Aanthony_minessale@hotmail.com> GTALK/JABBER/PAYPAL:anthony.minessale@gmail.com <mailto:PAYPAL%3Aanthony.minessale@gmail.com> IRC: irc.freenode.net <http://irc.freenode.net> #freeswitch
FreeSWITCH Developer Conference sip:888@conference.freeswitch.org <mailto:sip%3A888@conference.freeswitch.org> iax:guest@conference.freeswitch.org/888 <http://iax:guest@conference.freeswitch.org/888> googletalk:conf+888@conference.freeswitch.org <mailto:googletalk%3Aconf%2B888@conference.freeswitch.org> pstn:213-799-1400
--- ---------------------------------------------------------------------
_______________________________________________ Freeswitch-dev mailing list Freeswitch-dev@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch- dev http://www.freeswitch.org
_______________________________________________ Freeswitch-dev mailing list Freeswitch-dev@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev http://www.freeswitch.org
I examined your patch and then learned we can survive with no profile so i changed the code around. Then i found the real issue with the bgapi and fixed that too. Your patch still was very useful to help demonstrate the problem. Thank you. On Wed, Apr 1, 2009 at 5:23 AM, Szymon Olko <solko@gcdf.pl> wrote:
Anthony Minessale pisze:
The best way to submit patches is to file it on jia so it gets a ticket number and is properly reviewed. http://jira.freeswitch.org
I did it as you proposed. You fixed that your way, which of course is better. I know You are busy so no time to educate me, but I would be very graceful for short comment to my patch.
Changing subject... I really like FS idea and design. I would like to make some code for FS in my free time. I know I have to learn a lot, I looked at FS code but the best to know it is to make real development. Is there any TODO list with modules that are requested/needed to be done? I could start with simple not urgent module and this way get knowledge to make more advanced things.
Regards Szymon Olko
2009/3/25 Szymon Olko <solko@gcdf.pl>
Hello,
I deleted default profile from conference.conf.xml and from that time I could not connect second outgoing channel to conference.
I located problem in searching for conference with 'switch_core_hash_find' function. Only name of conference is stored in hash so looking for something like 'name@profile' did not find any. In my opinion it always used second attempt to dial when conference was not found, and it successes only if default profile is available.
There is also bgdial problem which do not allow to call to not existing conference, but in function conf_api_sub_bgdial it looks like it was meant to work. I have to know freeswitch code better to fix it.
I created patch to solve first problem. This is my first patch so please give me comments so next time I do it better. I choose this way to learn how freeswitch modules are made. I would also like if someone could review my patch and tell me if this is a way mod_conference should work. I assumed that looking for conference is for connecting members to existing conference, and that it's should work like that. Previously it did not find conference if profile was given in command.
Szymon Olko
_______________________________________________ Freeswitch-dev mailing list Freeswitch-dev@lists.freeswitch.org <mailto:Freeswitch-dev@lists.freeswitch.org> http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:
http://lists.freeswitch.org/mailman/options/freeswitch-dev
-- Anthony Minessale II
FreeSWITCH http://www.freeswitch.org/ ClueCon http://www.cluecon.com/
AIM: anthm MSN:anthony_minessale@hotmail.com <MSN%3Aanthony_minessale@hotmail.com> <mailto:MSN%3Aanthony_minessale@hotmail.com<MSN%253Aanthony_minessale@hotmail.com>
GTALK/JABBER/PAYPAL:anthony.minessale@gmail.com<PAYPAL%3Aanthony.minessale@gmail.com> <mailto:PAYPAL%3Aanthony.minessale@gmail.com<PAYPAL%253Aanthony.minessale@gmail.com>
IRC: irc.freenode.net <http://irc.freenode.net> #freeswitch
FreeSWITCH Developer Conference sip:888@conference.freeswitch.org <sip%3A888@conference.freeswitch.org> <mailto:sip%3A888@conference.freeswitch.org<sip%253A888@conference.freeswitch.org>
iax:guest@conference.freeswitch.org/888 <http://iax:guest@conference.freeswitch.org/888> googletalk:conf+888@conference.freeswitch.org<googletalk%3Aconf%2B888@conference.freeswitch.org> <mailto:googletalk%3Aconf%2B888@conference.freeswitch.org<googletalk%253Aconf%252B888@conference.freeswitch.org>
pstn:213-799-1400
------------------------------------------------------------------------
_______________________________________________ Freeswitch-dev mailing list Freeswitch-dev@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev http://www.freeswitch.org
_______________________________________________ Freeswitch-dev mailing list Freeswitch-dev@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev http://www.freeswitch.org
-- Anthony Minessale II FreeSWITCH http://www.freeswitch.org/ ClueCon http://www.cluecon.com/ AIM: anthm MSN:anthony_minessale@hotmail.com <MSN%3Aanthony_minessale@hotmail.com> GTALK/JABBER/PAYPAL:anthony.minessale@gmail.com<PAYPAL%3Aanthony.minessale@gmail.com> IRC: irc.freenode.net #freeswitch FreeSWITCH Developer Conference sip:888@conference.freeswitch.org <sip%3A888@conference.freeswitch.org> iax:guest@conference.freeswitch.org/888 googletalk:conf+888@conference.freeswitch.org<googletalk%3Aconf%2B888@conference.freeswitch.org> pstn:213-799-1400
participants (3)
-
Anthony Minessale
-
Michael Jerris
-
Szymon Olko