Minor suggestion: s/depricate/deprecate/g
FYI, Just to add a little professional polish we might want to replace "depricate" with "deprecate" since the former is a misspelling. Before I make a patch I wanted to know about stuff like this: [root@freeswitch2 include]# grep -rin "depricate" *h switch_config.h:41: * This module implements a basic interface and file format parser it may be depricated in favor of database entries switch_core.h:973:SWITCH_DECLARE(switch_hash_index_t *) switch_hash_first(char *depricate_me, _In_ switch_hash_t *hash); I don't favor mass-replacing variable names when I'm not the author. If someone out there is capable then here's a list of source files that have "depricate" in them: grep -ir "depricate" * |grep -v "Binary" src/include/switch_config.h: * This module implements a basic interface and file format parser it may be depricated in favor of database entries src/include/.svn/text-base/switch_core.h.svn-base:SWITCH_DECLARE(switch_ hash_index_t *) switch_hash_first(char *depricate_me, _In_ switch_hash_t *hash); src/include/.svn/text-base/switch_config.h.svn-base: * This module implements a basic interface and file format parser it may be depricated in favor of database entries src/include/switch_core.h:SWITCH_DECLARE(switch_hash_index_t *) switch_hash_first(char *depricate_me, _In_ switch_hash_t *hash); src/mod/applications/mod_commands/mod_commands.c: SWITCH_ADD_API(commands_api_interface, "killchan", "Kill Channel (depricated)", kill_function, KILL_SYNTAX); src/mod/applications/mod_commands/mod_commands.c: SWITCH_ADD_API(commands_api_interface, "transfer", "Transfer (depricated)", transfer_function, TRANSFER_SYNTAX); src/mod/applications/mod_commands/mod_commands.c: SWITCH_ADD_API(commands_api_interface, "session_displace", "session displace (depricated)", session_displace_function, DISPLACE_SYNTAX); src/mod/applications/mod_commands/mod_commands.c: SWITCH_ADD_API(commands_api_interface, "session_record", "session record (depricated)", session_record_function, SESS_REC_SYNTAX); src/mod/applications/mod_commands/mod_commands.c: SWITCH_ADD_API(commands_api_interface, "broadcast", "broadcast (depricated)", uuid_broadcast_function, BROADCAST_SYNTAX); src/mod/applications/mod_commands/mod_commands.c: SWITCH_ADD_API(commands_api_interface, "hold", "hold (depricated)", uuid_hold_function, HOLD_SYNTAX); src/mod/applications/mod_commands/mod_commands.c: SWITCH_ADD_API(commands_api_interface, "media", "media (depricated)", uuid_media_function, MEDIA_SYNTAX); src/mod/applications/mod_commands/.svn/text-base/mod_commands.c.svn-base : SWITCH_ADD_API(commands_api_interface, "killchan", "Kill Channel (depricated)", kill_function, KILL_SYNTAX); src/mod/applications/mod_commands/.svn/text-base/mod_commands.c.svn-base : SWITCH_ADD_API(commands_api_interface, "transfer", "Transfer (depricated)", transfer_function, TRANSFER_SYNTAX); src/mod/applications/mod_commands/.svn/text-base/mod_commands.c.svn-base : SWITCH_ADD_API(commands_api_interface, "session_displace", "session displace (depricated)", session_displace_function, DISPLACE_SYNTAX); src/mod/applications/mod_commands/.svn/text-base/mod_commands.c.svn-base : SWITCH_ADD_API(commands_api_interface, "session_record", "session record (depricated)", session_record_function, SESS_REC_SYNTAX); src/mod/applications/mod_commands/.svn/text-base/mod_commands.c.svn-base : SWITCH_ADD_API(commands_api_interface, "broadcast", "broadcast (depricated)", uuid_broadcast_function, BROADCAST_SYNTAX); src/mod/applications/mod_commands/.svn/text-base/mod_commands.c.svn-base : SWITCH_ADD_API(commands_api_interface, "hold", "hold (depricated)", uuid_hold_function, HOLD_SYNTAX); src/mod/applications/mod_commands/.svn/text-base/mod_commands.c.svn-base : SWITCH_ADD_API(commands_api_interface, "media", "media (depricated)", uuid_media_function, MEDIA_SYNTAX); src/mod/applications/mod_dptools/.svn/text-base/mod_dptools.c.svn-base: SWITCH_ADD_APP(app_interface, "reject", "Send session reject (depricated)", "Send a respond message to a session.", respond_function, "<respond_data>", SAF_SUPPORT_NOMEDIA); src/mod/applications/mod_dptools/mod_dptools.c: SWITCH_ADD_APP(app_interface, "reject", "Send session reject (depricated)", "Send a respond message to a session.", respond_function, "<respond_data>", SAF_SUPPORT_NOMEDIA); src/mod/languages/mod_mono_managed/swig/.svn/text-base/freeswitch.cs.svn -base: public static SWIGTYPE_p_HashElem switch_hash_first(string depricate_me, SWIGTYPE_p_switch_hash hash) { src/mod/languages/mod_mono_managed/swig/.svn/text-base/freeswitch.cs.svn -base: IntPtr cPtr = freeswitchPINVOKE.switch_hash_first(depricate_me, SWIGTYPE_p_switch_hash.getCPtr(hash)); src/mod/languages/mod_mono_managed/swig/freeswitch.cs: public static SWIGTYPE_p_HashElem switch_hash_first(string depricate_me, SWIGTYPE_p_switch_hash hash) { src/mod/languages/mod_mono_managed/swig/freeswitch.cs: IntPtr cPtr = freeswitchPINVOKE.switch_hash_first(depricate_me, SWIGTYPE_p_switch_hash.getCPtr(hash)); src/.svn/text-base/switch_core_hash.c.svn-base:SWITCH_DECLARE(switch_has h_index_t *) switch_hash_first(char *depricate_me, switch_hash_t *hash) src/switch_core_hash.c:SWITCH_DECLARE(switch_hash_index_t *) switch_hash_first(char *depricate_me, switch_hash_t *hash) My wife says I have to go spend time with the family now so I'll catch you guys later... -MC
or we could just remove them all. Thoughts? On May 26, 2008, at 2:30 PM, Michael Collins wrote:
FYI,
Just to add a little professional polish we might want to replace “depricate” with “deprecate” since the former is a misspelling. Before I make a patch I wanted to know about stuff like this: [root@freeswitch2 include]# grep -rin "depricate" *h switch_config.h:41: * This module implements a basic interface and file format parser it may be depricated in favor of database entries switch_core.h:973:SWITCH_DECLARE(switch_hash_index_t *) switch_hash_first(char *depricate_me, _In_ switch_hash_t *hash);
I don’t favor mass-replacing variable names when I’m not the author. If someone out there is capable then here’s a list of source files that have “depricate” in them: grep -ir "depricate" * |grep -v "Binary" src/include/switch_config.h: * This module implements a basic interface and file format parser it may be depricated in favor of database entries src/include/.svn/text-base/switch_core.h.svn- base:SWITCH_DECLARE(switch_hash_index_t *) switch_hash_first(char *depricate_me, _In_ switch_hash_t *hash); src/include/.svn/text-base/switch_config.h.svn-base: * This module implements a basic interface and file format parser it may be depricated in favor of database entries src/include/switch_core.h:SWITCH_DECLARE(switch_hash_index_t *) switch_hash_first(char *depricate_me, _In_ switch_hash_t *hash); src/mod/applications/mod_commands/mod_commands.c: SWITCH_ADD_API(commands_api_interface, "killchan", "Kill Channel (depricated)", kill_function, KILL_SYNTAX); src/mod/applications/mod_commands/mod_commands.c: SWITCH_ADD_API(commands_api_interface, "transfer", "Transfer (depricated)", transfer_function, TRANSFER_SYNTAX); src/mod/applications/mod_commands/mod_commands.c: SWITCH_ADD_API(commands_api_interface, "session_displace", "session displace (depricated)", session_displace_function, DISPLACE_SYNTAX); src/mod/applications/mod_commands/mod_commands.c: SWITCH_ADD_API(commands_api_interface, "session_record", "session record (depricated)", session_record_function, SESS_REC_SYNTAX); src/mod/applications/mod_commands/mod_commands.c: SWITCH_ADD_API(commands_api_interface, "broadcast", "broadcast (depricated)", uuid_broadcast_function, BROADCAST_SYNTAX); src/mod/applications/mod_commands/mod_commands.c: SWITCH_ADD_API(commands_api_interface, "hold", "hold (depricated)", uuid_hold_function, HOLD_SYNTAX); src/mod/applications/mod_commands/mod_commands.c: SWITCH_ADD_API(commands_api_interface, "media", "media (depricated)", uuid_media_function, MEDIA_SYNTAX); src/mod/applications/mod_commands/.svn/text-base/mod_commands.c.svn- base: SWITCH_ADD_API(commands_api_interface, "killchan", "Kill Channel (depricated)", kill_function, KILL_SYNTAX); src/mod/applications/mod_commands/.svn/text-base/mod_commands.c.svn- base: SWITCH_ADD_API(commands_api_interface, "transfer", "Transfer (depricated)", transfer_function, TRANSFER_SYNTAX); src/mod/applications/mod_commands/.svn/text-base/mod_commands.c.svn- base: SWITCH_ADD_API(commands_api_interface, "session_displace", "session displace (depricated)", session_displace_function, DISPLACE_SYNTAX); src/mod/applications/mod_commands/.svn/text-base/mod_commands.c.svn- base: SWITCH_ADD_API(commands_api_interface, "session_record", "session record (depricated)", session_record_function, SESS_REC_SYNTAX); src/mod/applications/mod_commands/.svn/text-base/mod_commands.c.svn- base: SWITCH_ADD_API(commands_api_interface, "broadcast", "broadcast (depricated)", uuid_broadcast_function, BROADCAST_SYNTAX); src/mod/applications/mod_commands/.svn/text-base/mod_commands.c.svn- base: SWITCH_ADD_API(commands_api_interface, "hold", "hold (depricated)", uuid_hold_function, HOLD_SYNTAX); src/mod/applications/mod_commands/.svn/text-base/mod_commands.c.svn- base: SWITCH_ADD_API(commands_api_interface, "media", "media (depricated)", uuid_media_function, MEDIA_SYNTAX); src/mod/applications/mod_dptools/.svn/text-base/mod_dptools.c.svn- base: SWITCH_ADD_APP(app_interface, "reject", "Send session reject (depricated)", "Send a respond message to a session.", respond_function, "<respond_data>", SAF_SUPPORT_NOMEDIA); src/mod/applications/mod_dptools/mod_dptools.c: SWITCH_ADD_APP(app_interface, "reject", "Send session reject (depricated)", "Send a respond message to a session.", respond_function, "<respond_data>", SAF_SUPPORT_NOMEDIA); src/mod/languages/mod_mono_managed/swig/.svn/text-base/ freeswitch.cs.svn-base: public static SWIGTYPE_p_HashElem switch_hash_first(string depricate_me, SWIGTYPE_p_switch_hash hash) { src/mod/languages/mod_mono_managed/swig/.svn/text-base/ freeswitch.cs.svn-base: IntPtr cPtr = freeswitchPINVOKE.switch_hash_first(depricate_me, SWIGTYPE_p_switch_hash.getCPtr(hash)); src/mod/languages/mod_mono_managed/swig/freeswitch.cs: public static SWIGTYPE_p_HashElem switch_hash_first(string depricate_me, SWIGTYPE_p_switch_hash hash) { src/mod/languages/mod_mono_managed/swig/freeswitch.cs: IntPtr cPtr = freeswitchPINVOKE.switch_hash_first(depricate_me, SWIGTYPE_p_switch_hash.getCPtr(hash)); src/.svn/text-base/switch_core_hash.c.svn- base:SWITCH_DECLARE(switch_hash_index_t *) switch_hash_first(char *depricate_me, switch_hash_t *hash) src/switch_core_hash.c:SWITCH_DECLARE(switch_hash_index_t *) switch_hash_first(char *depricate_me, switch_hash_t *hash)
My wife says I have to go spend time with the family now so I’ll catch you guys later… -MC _______________________________________________ Freeswitch-dev mailing list Freeswitch-dev@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev http://www.freeswitch.org
they are already gone =D On Tue, May 27, 2008 at 4:55 PM, Michael Collins <mcollins@fcnetwork.com> wrote:
or we could just remove them all. Thoughts?
Actually, that's a good idea. Since all these "depricated" items are holdovers from the pre-1.0.0 it seems logical to remove them altogether. No need to hang on to the past as far as I'm concerned.
-MC
_______________________________________________ Freeswitch-dev mailing list Freeswitch-dev@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev http://www.freeswitch.org
-- Anthony Minessale II FreeSWITCH http://www.freeswitch.org/ ClueCon http://www.cluecon.com/ AIM: anthm MSN:anthony_minessale@hotmail.com <MSN%3Aanthony_minessale@hotmail.com> GTALK/JABBER/PAYPAL:anthony.minessale@gmail.com<PAYPAL%3Aanthony.minessale@gmail.com> IRC: irc.freenode.net #freeswitch FreeSWITCH Developer Conference sip:888@conference.freeswitch.org <sip%3A888@conference.freeswitch.org> iax:guest@conference.freeswitch.org/888 googletalk:conf+888@conference.freeswitch.org<googletalk%3Aconf%2B888@conference.freeswitch.org> pstn:213-799-1400
Woohoo! FWIW, I approve of the decision to remove them! :-) ________________________________ From: freeswitch-dev-bounces@lists.freeswitch.org [mailto:freeswitch-dev-bounces@lists.freeswitch.org] On Behalf Of Anthony Minessale Sent: Tuesday, May 27, 2008 2:53 PM To: freeswitch-dev@lists.freeswitch.org Subject: Re: [Freeswitch-dev] Minor suggestion: s/depricate/deprecate/g they are already gone =D On Tue, May 27, 2008 at 4:55 PM, Michael Collins <mcollins@fcnetwork.com> wrote:
or we could just remove them all. Thoughts?
Actually, that's a good idea. Since all these "depricated" items are holdovers from the pre-1.0.0 it seems logical to remove them altogether. No need to hang on to the past as far as I'm concerned. -MC _______________________________________________ Freeswitch-dev mailing list Freeswitch-dev@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev http://www.freeswitch.org -- Anthony Minessale II FreeSWITCH http://www.freeswitch.org/ ClueCon http://www.cluecon.com/ AIM: anthm MSN:anthony_minessale@hotmail.com <mailto:MSN%3Aanthony_minessale@hotmail.com> GTALK/JABBER/PAYPAL:anthony.minessale@gmail.com <mailto:PAYPAL%3Aanthony.minessale@gmail.com> IRC: irc.freenode.net #freeswitch FreeSWITCH Developer Conference sip:888@conference.freeswitch.org <mailto:sip%3A888@conference.freeswitch.org> iax:guest@conference.freeswitch.org/888 googletalk:conf+888@conference.freeswitch.org <mailto:googletalk%3Aconf%2B888@conference.freeswitch.org> pstn:213-799-1400
or we could just remove them all. Thoughts? On May 26, 2008, at 2:30 PM, Michael Collins wrote:
FYI,
Just to add a little professional polish we might want to replace “depricate” with “deprecate” since the former is a misspelling. Before I make a patch I wanted to know about stuff like this: [root@freeswitch2 include]# grep -rin "depricate" *h switch_config.h:41: * This module implements a basic interface and file format parser it may be depricated in favor of database entries switch_core.h:973:SWITCH_DECLARE(switch_hash_index_t *) switch_hash_first(char *depricate_me, _In_ switch_hash_t *hash);
I don’t favor mass-replacing variable names when I’m not the author. If someone out there is capable then here’s a list of source files that have “depricate” in them: grep -ir "depricate" * |grep -v "Binary" src/include/switch_config.h: * This module implements a basic interface and file format parser it may be depricated in favor of database entries src/include/.svn/text-base/switch_core.h.svn- base:SWITCH_DECLARE(switch_hash_index_t *) switch_hash_first(char *depricate_me, _In_ switch_hash_t *hash); src/include/.svn/text-base/switch_config.h.svn-base: * This module implements a basic interface and file format parser it may be depricated in favor of database entries src/include/switch_core.h:SWITCH_DECLARE(switch_hash_index_t *) switch_hash_first(char *depricate_me, _In_ switch_hash_t *hash); src/mod/applications/mod_commands/mod_commands.c: SWITCH_ADD_API(commands_api_interface, "killchan", "Kill Channel (depricated)", kill_function, KILL_SYNTAX); src/mod/applications/mod_commands/mod_commands.c: SWITCH_ADD_API(commands_api_interface, "transfer", "Transfer (depricated)", transfer_function, TRANSFER_SYNTAX); src/mod/applications/mod_commands/mod_commands.c: SWITCH_ADD_API(commands_api_interface, "session_displace", "session displace (depricated)", session_displace_function, DISPLACE_SYNTAX); src/mod/applications/mod_commands/mod_commands.c: SWITCH_ADD_API(commands_api_interface, "session_record", "session record (depricated)", session_record_function, SESS_REC_SYNTAX); src/mod/applications/mod_commands/mod_commands.c: SWITCH_ADD_API(commands_api_interface, "broadcast", "broadcast (depricated)", uuid_broadcast_function, BROADCAST_SYNTAX); src/mod/applications/mod_commands/mod_commands.c: SWITCH_ADD_API(commands_api_interface, "hold", "hold (depricated)", uuid_hold_function, HOLD_SYNTAX); src/mod/applications/mod_commands/mod_commands.c: SWITCH_ADD_API(commands_api_interface, "media", "media (depricated)", uuid_media_function, MEDIA_SYNTAX); src/mod/applications/mod_commands/.svn/text-base/mod_commands.c.svn- base: SWITCH_ADD_API(commands_api_interface, "killchan", "Kill Channel (depricated)", kill_function, KILL_SYNTAX); src/mod/applications/mod_commands/.svn/text-base/mod_commands.c.svn- base: SWITCH_ADD_API(commands_api_interface, "transfer", "Transfer (depricated)", transfer_function, TRANSFER_SYNTAX); src/mod/applications/mod_commands/.svn/text-base/mod_commands.c.svn- base: SWITCH_ADD_API(commands_api_interface, "session_displace", "session displace (depricated)", session_displace_function, DISPLACE_SYNTAX); src/mod/applications/mod_commands/.svn/text-base/mod_commands.c.svn- base: SWITCH_ADD_API(commands_api_interface, "session_record", "session record (depricated)", session_record_function, SESS_REC_SYNTAX); src/mod/applications/mod_commands/.svn/text-base/mod_commands.c.svn- base: SWITCH_ADD_API(commands_api_interface, "broadcast", "broadcast (depricated)", uuid_broadcast_function, BROADCAST_SYNTAX); src/mod/applications/mod_commands/.svn/text-base/mod_commands.c.svn- base: SWITCH_ADD_API(commands_api_interface, "hold", "hold (depricated)", uuid_hold_function, HOLD_SYNTAX); src/mod/applications/mod_commands/.svn/text-base/mod_commands.c.svn- base: SWITCH_ADD_API(commands_api_interface, "media", "media (depricated)", uuid_media_function, MEDIA_SYNTAX); src/mod/applications/mod_dptools/.svn/text-base/mod_dptools.c.svn- base: SWITCH_ADD_APP(app_interface, "reject", "Send session reject (depricated)", "Send a respond message to a session.", respond_function, "<respond_data>", SAF_SUPPORT_NOMEDIA); src/mod/applications/mod_dptools/mod_dptools.c: SWITCH_ADD_APP(app_interface, "reject", "Send session reject (depricated)", "Send a respond message to a session.", respond_function, "<respond_data>", SAF_SUPPORT_NOMEDIA); src/mod/languages/mod_mono_managed/swig/.svn/text-base/ freeswitch.cs.svn-base: public static SWIGTYPE_p_HashElem switch_hash_first(string depricate_me, SWIGTYPE_p_switch_hash hash) { src/mod/languages/mod_mono_managed/swig/.svn/text-base/ freeswitch.cs.svn-base: IntPtr cPtr = freeswitchPINVOKE.switch_hash_first(depricate_me, SWIGTYPE_p_switch_hash.getCPtr(hash)); src/mod/languages/mod_mono_managed/swig/freeswitch.cs: public static SWIGTYPE_p_HashElem switch_hash_first(string depricate_me, SWIGTYPE_p_switch_hash hash) { src/mod/languages/mod_mono_managed/swig/freeswitch.cs: IntPtr cPtr = freeswitchPINVOKE.switch_hash_first(depricate_me, SWIGTYPE_p_switch_hash.getCPtr(hash)); src/.svn/text-base/switch_core_hash.c.svn- base:SWITCH_DECLARE(switch_hash_index_t *) switch_hash_first(char *depricate_me, switch_hash_t *hash) src/switch_core_hash.c:SWITCH_DECLARE(switch_hash_index_t *) switch_hash_first(char *depricate_me, switch_hash_t *hash)
My wife says I have to go spend time with the family now so I’ll catch you guys later… -MC _______________________________________________ Freeswitch-dev mailing list Freeswitch-dev@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev http://www.freeswitch.org
participants (3)
-
Anthony Minessale
-
Michael Collins
-
Michael Jerris