Conference recording pause/resume problem
Hi, I try to prepare a patch which allows to pause/resume a given recording. I'm in the middle of the road: pause is working, by resume - not :(. I'd like to ask for your help in finding a problem. I'm not sure if I handle member and file flags in the thread sub correctly. BTW. I lost some time playing with member-fnode until found fh in conference_record_thread_run is a proper handler. What is the conference_file_node_t member->fnode used for, if not for handling a recording file? Regards, Mariusz
member->fnode is for playing files in the confrence not recording. Instead of passing the flag to the fh, maybe try just testing the flag on each write to the file in mod conference and skip doing it while the pause flag is set.... 2011/12/20 Mariusz Czulada <manieq@wp.eu>
Hi,
I try to prepare a patch which allows to pause/resume a given recording. I'm in the middle of the road: pause is working, by resume - not :(. I'd like to ask for your help in finding a problem. I'm not sure if I handle member and file flags in the thread sub correctly.
BTW. I lost some time playing with member-fnode until found fh in conference_record_thread_run is a proper handler. What is the conference_file_node_t member->fnode used for, if not for handling a recording file?
Regards,
Mariusz
_________________________________________________________________________ Professional FreeSWITCH Consulting Services: consulting@freeswitch.org http://www.freeswitchsolutions.com
FreeSWITCH-powered IP PBX: The CudaTel Communication Server http://www.cudatel.com
Official FreeSWITCH Sites http://www.freeswitch.org http://wiki.freeswitch.org http://www.cluecon.com
FreeSWITCH-dev mailing list FreeSWITCH-dev@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev http://www.freeswitch.org
-- Anthony Minessale II FreeSWITCH http://www.freeswitch.org/ ClueCon http://www.cluecon.com/ Twitter: http://twitter.com/FreeSWITCH_wire AIM: anthm MSN:anthony_minessale@hotmail.com GTALK/JABBER/PAYPAL:anthony.minessale@gmail.com IRC: irc.freenode.net #freeswitch FreeSWITCH Developer Conference sip:888@conference.freeswitch.org googletalk:conf+888@conference.freeswitch.org pstn:+19193869900
I'm ok with that idea as long as its done cleanly. 2011/12/20 Mariusz Czulada <manieq@wp.eu>
I see. Here is another approach.
There is one more thing before puting it on Jira. Now we have 5 conference functions related to recoding (including new ones):
record <filename> chkrecord <confname> norecord <[filename|all]> pause <filename> resume <filename>
All these require just one parameter - file name. What do you think about adding alternative syntax:
record start <filename> record check <confname> record stop <[filename|all]> record pause <filename> record resume <filename>
I said "alternative" because it will require 2 params (action + file name) so both ways can easily coexist (ordinary record needs only one param) but the second one IMHO is better because of grouping recording functions together.
Regards,
Mariusz
Dnia 20-12-2011 o godz. 20:55 Anthony Minessale napisał(a):
member->fnode is for playing files in the confrence not recording.
Instead of passing the flag to the fh, maybe try just testing the flag on each write to the file in mod conference and skip doing it while the pause flag is set....
2011/12/20 Mariusz Czulada <manieq@wp.eu>
Hi,
I try to prepare a patch which allows to pause/resume a given recording. I'm in the middle of the road: pause is working, by resume - not :(. I'd like to ask for your help in finding a problem. I'm not sure if I handle member and file flags in the thread sub correctly.
BTW. I lost some time playing with member-fnode until found fh in conference_record_thread_run is a proper handler. What is the conference_file_node_t member->fnode used for, if not for handling a recording file?
Regards,
Mariusz
_________________________________________________________________________ Professional FreeSWITCH Consulting Services: consulting@freeswitch.org http://www.freeswitchsolutions.com
FreeSWITCH-powered IP PBX: The CudaTel Communication Server http://www.cudatel.com
Official FreeSWITCH Sites http://www.freeswitch.org http://wiki.freeswitch.org http://www.cluecon.com
FreeSWITCH-dev mailing list FreeSWITCH-dev@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev http://www.freeswitch.org
-- Anthony Minessale II
FreeSWITCH http://www.freeswitch.org/ ClueCon http://www.cluecon.com/ Twitter: http://twitter.com/FreeSWITCH_wire
AIM: anthm MSN:anthony_minessale@hotmail.com GTALK/JABBER/PAYPAL:anthony.minessale@gmail.com IRC: irc.freenode.net #freeswitch
FreeSWITCH Developer Conference sip:888@conference.freeswitch.org googletalk:conf+888@conference.freeswitch.org pstn:+19193869900
_________________________________________________________________________ Professional FreeSWITCH Consulting Services: consulting@freeswitch.org http://www.freeswitchsolutions.com
FreeSWITCH-powered IP PBX: The CudaTel Communication Server http://www.cudatel.com
Official FreeSWITCH Sites http://www.freeswitch.org http://wiki.freeswitch.org http://www.cluecon.com
FreeSWITCH-dev mailing list FreeSWITCH-dev@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev http://www.freeswitch.org
-- Anthony Minessale II FreeSWITCH http://www.freeswitch.org/ ClueCon http://www.cluecon.com/ Twitter: http://twitter.com/FreeSWITCH_wire AIM: anthm MSN:anthony_minessale@hotmail.com GTALK/JABBER/PAYPAL:anthony.minessale@gmail.com IRC: irc.freenode.net #freeswitch FreeSWITCH Developer Conference sip:888@conference.freeswitch.org googletalk:conf+888@conference.freeswitch.org pstn:+19193869900
participants (2)
-
Anthony Minessale
-
Mariusz Czulada