Re: [Freeswitch-dev] mod_skypiax inching forward
hi Giovanni, I just made some improve on skypiax, so you can call skypiax/ANY/ another_skypename, it will automatically chose an available channel. not good, but it works. put the following code directly before the following line: for (i = 0; i < SKYPIAX_MAX_INTERFACES; i++) { And change the above line to for (i = 0; !found && i < SKYPIAX_MAX_INTERFACES; i++) { It should be like: if (strncmp("ANY", interface_name, strlen(interface_name)) == 0) { //find an available one, allowing call like originate skypiax/ ANY/another_skypename DEBUGA_SKYPE("Finding one available skype interface\n", SKYPIAX_P_LOG); for (i = 0; !found && i < SKYPIAX_MAX_INTERFACES; i++) { if (strlen(globals.SKYPIAX_INTERFACES[i].name)) { int skype_state = 0; tech_pvt = &globals.SKYPIAX_INTERFACES[i]; skype_state = tech_pvt->interface_state; DEBUGA_SKYPE("skype interface: %d, name: %s, state: %d\n", SKYPIAX_P_LOG, i, globals.SKYPIAX_INTERFACES[i].name, skype_state); if (SKYPIAX_STATE_DOWN == skype_state || 0 == skype_state) { found=1; break; } } } } for (i = 0; !found && i < SKYPIAX_MAX_INTERFACES; i++) { Regards, Seven
seven du wrote:
hi Giovanni,
I just made some improve on skypiax, so you can call skypiax/ANY/ another_skypename, it will automatically chose an available channel. not good, but it works.
put the following code directly before the following line:
the best way to submit improvements is to post a patch on jira. if you haven't yet, create an account there. svn diff > /tmp/my.patch should give you a nice patch to post on the tracker -Ray
Don't forget that all patches are text files and should have a .txt ending and that diffs should always be done from the root of the source tree. :) -MC On Fri, Jan 23, 2009 at 7:42 AM, Raymond Chandler <intralanman@freeswitch.org> wrote:
seven du wrote:
hi Giovanni,
I just made some improve on skypiax, so you can call skypiax/ANY/ another_skypename, it will automatically chose an available channel. not good, but it works.
put the following code directly before the following line:
the best way to submit improvements is to post a patch on jira. if you haven't yet, create an account there. svn diff > /tmp/my.patch should give you a nice patch to post on the tracker
-Ray
_______________________________________________ Freeswitch-dev mailing list Freeswitch-dev@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev http://www.freeswitch.org
Thanks. I only had experience on post issues to jira. how to post a patch? also create an issure? And, the skypiax stuff is not in the trunk but a branch, is it also proper? And I know the best way to make a patch is run svn diff in the root directory, but I only checked out the mod, but not the whole branch, so I think the best way to make a patch is run svn diff from the mod's root directory, is that right? On Jan 23, 2009, at 11:42 PM, Raymond Chandler wrote:
seven du wrote:
hi Giovanni,
I just made some improve on skypiax, so you can call skypiax/ANY/ another_skypename, it will automatically chose an available channel. not good, but it works.
put the following code directly before the following line:
the best way to submit improvements is to post a patch on jira. if you haven't yet, create an account there. svn diff > /tmp/my.patch should give you a nice patch to post on the tracker
-Ray
_______________________________________________ Freeswitch-dev mailing list Freeswitch-dev@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev http://www.freeswitch.org
I have added mod_skypiax to Jira under endpoint modules and assigned the mod to Giovanni. Please open a jira and attach any patches there. Thanks, /b On Jan 25, 2009, at 4:05 AM, seven du wrote:
Thanks. I only had experience on post issues to jira. how to post a patch? also create an issure? And, the skypiax stuff is not in the trunk but a branch, is it also proper?
And I know the best way to make a patch is run svn diff in the root directory, but I only checked out the mod, but not the whole branch, so I think the best way to make a patch is run svn diff from the mod's root directory, is that right?
Hi Brian and Seven, nice to be in Jira, thanks Brian. I'll be on call :-)! Sincerely, Giovanni Maruzzelli ========================================= www.celliax.org via Pierlombardo 9, 20135 Milano Italy gmaruzz at celliax dot org Cell : +39-347-2665618 Fax : +39-02-87390039 On Sun, Jan 25, 2009 at 11:12 AM, Brian West <brian@freeswitch.org> wrote:
I have added mod_skypiax to Jira under endpoint modules and assigned the mod to Giovanni. Please open a jira and attach any patches there.
Thanks, /b
On Jan 25, 2009, at 4:05 AM, seven du wrote:
Thanks. I only had experience on post issues to jira. how to post a patch? also create an issure? And, the skypiax stuff is not in the trunk but a branch, is it also proper?
And I know the best way to make a patch is run svn diff in the root directory, but I only checked out the mod, but not the whole branch, so I think the best way to make a patch is run svn diff from the mod's root directory, is that right?
_______________________________________________ Freeswitch-dev mailing list Freeswitch-dev@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev http://www.freeswitch.org
participants (5)
-
Brian West
-
Giovanni Maruzzelli
-
Michael Collins
-
Raymond Chandler
-
seven du