[Freeswitch-dev] switch_ivr_bridge.c question
Re-worded my original post a bit, sorry if it becomes a new thread...having Nabble issues. In switch_ivr_bridge.c on line 1474, we have the following lines of code: 1474 switch_channel_clear_state_handler(originator_channel, NULL); 1475 switch_channel_clear_state_handler(originatee_channel, NULL); 1476 switch_channel_set_state_flag(originator_channel, CF_BRIDGE_ORIGINATOR); 1477 switch_channel_clear_flag_recursive(originatee_channel, CF_BRIDGE_ORIGINATOR); 1478 switch_channel_add_state_handler(originator_channel, &uuid_bridge_state_handlers); 1479 switch_channel_add_state_handler(originatee_channel, &uuid_bridge_state_handlers); Is the call to “switch_channel_set_state_flag” a typo? Since line 1476 triggers an asynchronous flag change, and line 1477 changes the same flag synchronously, on line 1478 the value of the flag becomes unpredictable since the asynchronous change from line 1476 can happen before or after line 1477 (mostly after, of course). Thanks again. -- View this message in context: http://freeswitch-dev.4355.n6.nabble.com/switch-ivr-bridge-c-question-tp4359... Sent from the FreeSWITCH-dev mailing list archive at Nabble.com.
The code is not the same on the latest. Look closer ;) You should probably keep yourself on the latest for this deep of an examination. On Thu, Feb 2, 2012 at 11:43 AM, teldev <ustcorporation@yahoo.com> wrote:
Re-worded my original post a bit, sorry if it becomes a new thread...having Nabble issues.
In switch_ivr_bridge.c on line 1474, we have the following lines of code:
1474 switch_channel_clear_state_handler(originator_channel, NULL); 1475 switch_channel_clear_state_handler(originatee_channel, NULL); 1476 switch_channel_set_state_flag(originator_channel, CF_BRIDGE_ORIGINATOR); 1477 switch_channel_clear_flag_recursive(originatee_channel, CF_BRIDGE_ORIGINATOR); 1478 switch_channel_add_state_handler(originator_channel, &uuid_bridge_state_handlers); 1479 switch_channel_add_state_handler(originatee_channel, &uuid_bridge_state_handlers);
Is the call to “switch_channel_set_state_flag” a typo? Since line 1476 triggers an asynchronous flag change, and line 1477 changes the same flag synchronously, on line 1478 the value of the flag becomes unpredictable since the asynchronous change from line 1476 can happen before or after line 1477 (mostly after, of course).
Thanks again.
-- View this message in context: http://freeswitch-dev.4355.n6.nabble.com/switch-ivr-bridge-c-question-tp4359... Sent from the FreeSWITCH-dev mailing list archive at Nabble.com.
_________________________________________________________________________ Professional FreeSWITCH Consulting Services: consulting@freeswitch.org http://www.freeswitchsolutions.com
FreeSWITCH-powered IP PBX: The CudaTel Communication Server http://www.cudatel.com
Official FreeSWITCH Sites http://www.freeswitch.org http://wiki.freeswitch.org http://www.cluecon.com
FreeSWITCH-dev mailing list FreeSWITCH-dev@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev http://www.freeswitch.org
-- Anthony Minessale II FreeSWITCH http://www.freeswitch.org/ ClueCon http://www.cluecon.com/ Twitter: http://twitter.com/FreeSWITCH_wire AIM: anthm MSN:anthony_minessale@hotmail.com GTALK/JABBER/PAYPAL:anthony.minessale@gmail.com IRC: irc.freenode.net #freeswitch FreeSWITCH Developer Conference sip:888@conference.freeswitch.org googletalk:conf+888@conference.freeswitch.org pstn:+19193869900
Hello Anthony, Yes, my line numbers were off by 4 after getting latest GIT from the master branch. The code is the same there. If you can take a look at it now, here is the refreshed version with correct line numbers: 1470 switch_channel_clear_state_handler(originator_channel, NULL); 1471 switch_channel_clear_state_handler(originatee_channel, NULL); 1472 switch_channel_set_state_flag(originator_channel, CF_BRIDGE_ORIGINATOR); 1473 switch_channel_clear_flag_recursive(originatee_channel, CF_BRIDGE_ORIGINATOR); 1474 switch_channel_add_state_handler(originator_channel, &uuid_bridge_state_handlers); 1475 switch_channel_add_state_handler(originatee_channel, &uuid_bridge_state_handlers); Thanks in advance. -- View this message in context: http://freeswitch-dev.4355.n6.nabble.com/switch-ivr-bridge-c-question-tp4359... Sent from the FreeSWITCH-dev mailing list archive at Nabble.com.
not even close? Where are you getting this from? you need GIT HEAD from our standard git repo. On Thu, Feb 2, 2012 at 4:08 PM, teldev <ustcorporation@yahoo.com> wrote:
Hello Anthony,
Yes, my line numbers were off by 4 after getting latest GIT from the master branch. The code is the same there. If you can take a look at it now, here is the refreshed version with correct line numbers:
1470 switch_channel_clear_state_handler(originator_channel, NULL); 1471 switch_channel_clear_state_handler(originatee_channel, NULL); 1472 switch_channel_set_state_flag(originator_channel, CF_BRIDGE_ORIGINATOR); 1473 switch_channel_clear_flag_recursive(originatee_channel, CF_BRIDGE_ORIGINATOR); 1474 switch_channel_add_state_handler(originator_channel, &uuid_bridge_state_handlers); 1475 switch_channel_add_state_handler(originatee_channel, &uuid_bridge_state_handlers);
Thanks in advance.
-- View this message in context: http://freeswitch-dev.4355.n6.nabble.com/switch-ivr-bridge-c-question-tp4359... Sent from the FreeSWITCH-dev mailing list archive at Nabble.com.
_________________________________________________________________________ Professional FreeSWITCH Consulting Services: consulting@freeswitch.org http://www.freeswitchsolutions.com
FreeSWITCH-powered IP PBX: The CudaTel Communication Server http://www.cudatel.com
Official FreeSWITCH Sites http://www.freeswitch.org http://wiki.freeswitch.org http://www.cluecon.com
FreeSWITCH-dev mailing list FreeSWITCH-dev@lists.freeswitch.org http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev http://www.freeswitch.org
-- Anthony Minessale II FreeSWITCH http://www.freeswitch.org/ ClueCon http://www.cluecon.com/ Twitter: http://twitter.com/FreeSWITCH_wire AIM: anthm MSN:anthony_minessale@hotmail.com GTALK/JABBER/PAYPAL:anthony.minessale@gmail.com IRC: irc.freenode.net #freeswitch FreeSWITCH Developer Conference sip:888@conference.freeswitch.org googletalk:conf+888@conference.freeswitch.org pstn:+19193869900
Anthony, Sorry, I have several versions and I was indeed looking at the wrong one! Thanks for pointing this out. -- View this message in context: http://freeswitch-dev.4355.n6.nabble.com/switch-ivr-bridge-c-question-tp4359... Sent from the FreeSWITCH-dev mailing list archive at Nabble.com.
participants (2)
-
Anthony Minessale
-
teldev