François,
<br>

<br>
Thanks for the great work on this.
<br>

<br>
Could you git clone FreeSWITCH and update your patch to latest freetdm?
<br>

<br>
This patch is outdated ( I am not sure what the latest snapshot of
freetdm is? who make those? ). The API has changed to NOT expose
internal details to users of FreeTDM ( ie: internal channel states and
members ). Therefore things like:
<br>

<br>
while (span-&gt;channels[chan_no]-&gt;state != FTDM_CHANNEL_STATE_DOWN);
<br>

<br>
Do not work nor compile in mod_freetdm.c ( since mod_freetdm is a user of FreeTDM does not have access to the state member ).
<br>

<br>
Ping me on IRC or google talk (moy and moises.silva respectively) to discuss. <br><br clear="all">Moises Silva<br>Senior Software Engineer<br>Sangoma Technologies Inc. | 50 McIntosh Drive, Suite 120, Markham ON L3R 9T3 Canada<br>
t. 1 905 474 1990 x 128 | e. <a href="mailto:moy@sangoma.com">moy@sangoma.com</a><br>
<br><br><div class="gmail_quote">On Tue, Jun 1, 2010 at 3:45 PM,  <span dir="ltr">&lt;<a href="mailto:devel@thom.fr.eu.org">devel@thom.fr.eu.org</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">









<div link="blue" vlink="purple" lang="FR">

<div>

<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);" lang="EN-US">Done.</span></p>

<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);" lang="EN-US"> </span></p>

<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);" lang="EN-US">The patch I attached to OPENZAP-100 includes the lines
corresponding to OPENZAP-101.</span></p>

<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);" lang="EN-US"> </span></p>

<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);" lang="EN-US">François</span></p>

<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);" lang="EN-US"> </span></p>

<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> </span></p>

<p class="MsoNormal"><span style="font-size: 11pt; color: rgb(31, 73, 125);"> </span></p>

<div style="border-style: solid none none; border-color: rgb(181, 196, 223) -moz-use-text-color -moz-use-text-color; border-width: 1pt medium medium; padding: 3pt 0cm 0cm;">

<p class="MsoNormal"><b><span style="font-size: 10pt;">De :</span></b><span style="font-size: 10pt;">
<a href="mailto:freeswitch-dev-bounces@lists.freeswitch.org" target="_blank">freeswitch-dev-bounces@lists.freeswitch.org</a>
[mailto:<a href="mailto:freeswitch-dev-bounces@lists.freeswitch.org" target="_blank">freeswitch-dev-bounces@lists.freeswitch.org</a>] <b>De la part de</b>
Moises Silva<br>
<b>Envoyé :</b> mardi 1 juin 2010 18:20<br>
<b>À :</b> <a href="mailto:freeswitch-dev@lists.freeswitch.org" target="_blank">freeswitch-dev@lists.freeswitch.org</a><br>
<b>Objet :</b> Re: [Freeswitch-dev] Small error in mod_freetdm</span></p>

</div>

<p class="MsoNormal"> </p>

<p class="MsoNormal">As of your patches for CID.</p>

<div>

<p class="MsoNormal"> </p>

</div>

<div>

<p class="MsoNormal">Put them on JIRA as openzap bug and assign it to me.</p>

</div>

<div>

<p class="MsoNormal" style="margin-bottom: 12pt;"><br clear="all">
Moises Silva<br>
Senior Software Engineer<br>
Sangoma Technologies Inc. | 50 McIntosh Drive, Suite 120, Markham ON L3R 9T3
Canada<br>
t. 1 905 474 1990 x 128 | e. <a href="mailto:moy@sangoma.com" target="_blank">moy@sangoma.com</a><br>
<br>
</p>

<div>

<p class="MsoNormal">On Tue, Jun 1, 2010 at 11:51 AM, Moises Silva &lt;<a href="mailto:moises.silva@gmail.com" target="_blank">moises.silva@gmail.com</a>&gt; wrote:</p>

<p class="MsoNormal" style="margin-bottom: 12pt;">Good catch, thanks, is fixed
now.<br>
<span style="color: rgb(136, 136, 136);"><br clear="all">
Moises Silva<br>
Senior Software Engineer<br>
Sangoma Technologies Inc. | 50 McIntosh Drive, Suite 120, Markham ON L3R 9T3
Canada<br>
t. 1 905 474 1990 x 128 | e. <a href="mailto:moy@sangoma.com" target="_blank">moy@sangoma.com</a><br>
<br>
</span></p>

<div>

<div>

<div>

<p class="MsoNormal">On Tue, Jun 1, 2010 at 10:47 AM, François Legal &lt;<a href="mailto:devel@thom.fr.eu.org" target="_blank">devel@thom.fr.eu.org</a>&gt;
wrote:</p>

</div>

</div>

<blockquote style="border-style: none none none solid; border-color: -moz-use-text-color -moz-use-text-color -moz-use-text-color rgb(204, 204, 204); border-width: medium medium medium 1pt; padding: 0cm 0cm 0cm 6pt; margin-left: 4.8pt; margin-right: 0cm;">


<div>

<div>

<p>Oops,</p>

<p> </p>

<p>I meant</p>

<div>

<p>&quot;should probably be replaced by</p>

</div>

<p>    chanid = ftdm_channel_get_id(sigmsg-&gt;channel);&quot;</p>

<p> </p>

<p><span style="color: rgb(136, 136, 136);">François</span></p>

<div>

<div>

<p>On Tue, 01 Jun 2010 16:27:19 +0200, François Legal &lt;<a href="mailto:devel@thom.fr.eu.org" target="_blank">devel@thom.fr.eu.org</a>&gt;
wrote:</p>

<blockquote style="border-style: none none none solid; border-color: -moz-use-text-color -moz-use-text-color -moz-use-text-color rgb(16, 16, 255); border-width: medium medium medium 1.5pt; padding: 0cm 0cm 0cm 4pt; margin-left: 3.75pt; margin-top: 5pt; margin-bottom: 5pt;">


<p>Hello,</p>

<p> </p>

<p>I recently upgraded to latest snapshot, and started using freetdm instead of
openzap, and I found a small error in mod_freetdm.</p>

<p>When setting up the channel name in function ftdm_channel_from_event line
1286, the line</p>

<p style="margin-bottom: 12pt;">    chanid =
ftdm_channel_get_span_id(sigmsg-&gt;channel);</p>

<p>should probably be replaced by</p>

<p>    chanid = ftdm_channel_get_number(sigmsg-&gt;channel);</p>

<p> </p>

<p>I wanted to post this on JIRA, but was not able to find a subproject for
freetdm in JIRA.</p>

<p> </p>

<p>I also ported my patches from openzap to get the CID onto FXS channel work
on european hardware with freetdm. Please let me know where I should post
these.</p>

<p> </p>

<p>François</p>

</blockquote>

</div>

</div>

<p class="MsoNormal"> </p>

</div>

</div>

<div>

<p class="MsoNormal" style="margin-bottom: 12pt;">_______________________________________________<br>
FreeSWITCH-dev mailing list<br>
<a href="mailto:FreeSWITCH-dev@lists.freeswitch.org" target="_blank">FreeSWITCH-dev@lists.freeswitch.org</a><br>
<a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev</a><br>
UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-dev" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-dev</a><br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a></p>

</div>

</blockquote>

</div>

<p class="MsoNormal"> </p>

</div>

<p class="MsoNormal"> </p>

</div>

</div>

</div>


<br>_______________________________________________<br>
FreeSWITCH-dev mailing list<br>
<a href="mailto:FreeSWITCH-dev@lists.freeswitch.org">FreeSWITCH-dev@lists.freeswitch.org</a><br>
<a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev</a><br>
UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-dev" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-dev</a><br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
<br></blockquote></div><br>