On Monday, April 9, 2012 at 11:35 PM, Anthony Minessale wrote:
Isn't it only a problem if you clean your working code differentlyfrom the remote?You should resist doing any local whitespace changes and we can make atradition to maybe clean up the tree at every major release in asingle sweep so the history is not tainted by tons of whitespacechanges.On Mon, Apr 9, 2012 at 7:50 AM, Rafael Vargas <vargas.khomp@gmail.com> wrote:My two cents:As already stated by Ken Rice, trailing spaces are not a problem. And Ipersonally had a bad experience in purely aesthetic code cleanups. It messesup the "blame" function of the VCS (git in this case), once the lastmodifications in the the altered lines will be assigned to whoever commitedthe cleanup.--Rafael VargasOn Mon, Apr 9, 2012 at 09:24, Seven Du <dujinfang@gmail.com> wrote:I also prefer small, controlled updates, however I can't do git push andjira would be a little pain ...Ken mentioned there's nothing wrong with white spaces in another mail, Iagree but still think it's a little pain to generate "clean" diff whenthere's many trailing spaces involved. And as I said doing this could affectall devs So I'd like to get their ideas, especially we have more branchesthan before it's means need more merge and possible there's conflicts...7.On Sunday, April 8, 2012 at 4:01 AM, Michael Collins wrote:/usr/src/freeswitch/src# grep -rc "\s\+$" * | grep -v ":0$"1200+ files with trailing whitespace does seem a bit excessive, however Idon't know how large a "problem" it really is. If you're going to dowhitespace cleanup I recommend starting small, like with mod_rtmp.c. Runyour whitespace cleanup script on just a few files, recompile them, verifythat it's all good, then commit & push. I don't know about the other devs,but I would feel much more comfortable with small, controlled updates than alarge sweep that does a lot of files.Just my $0.02...-MCOn Sat, Apr 7, 2012 at 8:49 AM, Seven Du <dujinfang@gmail.com> wrote:cat -t mod_rtmp.c | grep Icat mod_rtmp.c | grep " $"some editors insert tabs automatically when you press enter.On Saturday, April 7, 2012 at 12:26 PM, Michael Collins wrote:can you show us an example of code w/ trailing whitespaces?-MC_________________________________________________________________________Professional FreeSWITCH Consulting Services:FreeSWITCH-powered IP PBX: The CudaTel Communication ServerOfficial FreeSWITCH SitesFreeSWITCH-dev mailing list_________________________________________________________________________Professional FreeSWITCH Consulting Services:FreeSWITCH-powered IP PBX: The CudaTel Communication ServerOfficial FreeSWITCH SitesFreeSWITCH-dev mailing list_________________________________________________________________________Professional FreeSWITCH Consulting Services:FreeSWITCH-powered IP PBX: The CudaTel Communication ServerOfficial FreeSWITCH SitesFreeSWITCH-dev mailing list--Anthony Minessale IIFreeSWITCH http://www.freeswitch.org/ClueCon http://www.cluecon.com/Twitter: http://twitter.com/FreeSWITCH_wireAIM: anthmGTALK/JABBER/PAYPAL:anthony.minessale@gmail.comIRC: irc.freenode.net #freeswitchFreeSWITCH Developer Conferencegoogletalk:conf+888@conference.freeswitch.orgpstn:+19193869900_________________________________________________________________________Professional FreeSWITCH Consulting Services:FreeSWITCH-powered IP PBX: The CudaTel Communication ServerOfficial FreeSWITCH SitesFreeSWITCH-dev mailing list