<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Piotr,<div class=""><br class=""></div><div class=""><span style="orphans: 2; text-align: -webkit-auto; widows: 2;" class="">I am glad that you are working on the avmd module! I tried myself a few months ago but found the code very difficult to follow and debug due to its overuse of macros. Do you plan to rewrite these macros as inline functions? For my part, I ended up rewriting all these macros as functions just to understand the code.</span></div><div class=""><span style="orphans: 2; text-align: -webkit-auto; widows: 2;" class=""><br class=""></span></div><div class=""><span style="orphans: 2; text-align: -webkit-auto; widows: 2;" class="">I eventually wrote a new module from scratch as I noticed the bugs you mention and needed incompatible changes in the api. But had not time to clean it up and check the licensing matters yet.</span></div><div class=""><span style="orphans: 2; text-align: -webkit-auto; widows: 2;" class=""><br class=""></span></div><div class=""><span style="orphans: 2; text-align: -webkit-auto; widows: 2;" class="">The real breakthrough is actually the one you mentioned in FS-8875: I have noticed real improvements in the cpu usage and detection accuracy by checking only the convergence of OMEGA instead of sin(OMEGA) and thus avoiding the sin calculation entirely!</span></div><div class=""><span style="orphans: 2; text-align: -webkit-auto; widows: 2;" class=""><br class=""></span></div><div class=""><span style="orphans: 2; text-align: -webkit-auto; widows: 2;" class="">I will be glad to help in any way. Please keep me in touch when you publish your patch, I’ll be happy to have a look.</span></div><div class=""><span style="orphans: 2; text-align: -webkit-auto; widows: 2;" class=""><br class=""></span></div><div class=""><span style="orphans: 2; text-align: -webkit-auto; widows: 2;" class="">Best Regards,</span></div><div class=""><span style="orphans: 2; text-align: -webkit-auto; widows: 2;" class="">Vallimamod</span></div><div class=""><span style="orphans: 2; text-align: -webkit-auto; widows: 2;" class="">.</span><br class="">
<br class=""><div><blockquote type="cite" class=""><div class="">On 16 Mar 2016, at 02:13, Piotr Gregor <<a href="mailto:piotrek.gregor@gmail.com" class="">piotrek.gregor@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Hi Abaci,<div class=""><br class=""><div class="">what issues do you mean by "same issue"?</div><div class="">Is this amount of false positives?</div><div class="">Could you describe the tests you perform in more details please?</div><div class=""><br class=""></div><div class="">The avmd module is being revised by myself at this moment</div><div class="">and there is at least one bug in this module that influence the results</div><div class=""><h3 class="" style="margin:10px 10px 0px 0px;padding:0px;color:rgb(51,51,51);font-size:20px;font-weight:normal;line-height:1.5;word-wrap:break-word;font-family:Arial,sans-serif">FS-8855 fix calc of variance of tone's freq estimator</h3></div><div class=""><br class=""></div><div class="">and it has been fixed now in pull request #714 and will be merged soon</div><div class="">after I do some more testing and rebase, to the end of this week.</div><div class="">Apart from this, there are improvements coming, e.g.</div><div class=""><br class=""></div><div class=""><h3 class="" style="margin:10px 10px 0px 0px;padding:0px;color:rgb(51,51,51);font-size:20px;font-weight:normal;line-height:1.5;word-wrap:break-word;font-family:Arial,sans-serif">FS-8875 <span style="font-size:24px;line-height:1.25" class="">Enable faster beep detection</span></h3></div><div class="gmail_extra"><br class=""></div><div class="gmail_extra">cheers,</div><div class="gmail_extra">Piotr</div></div></div>
_________________________________________________________________________<br class="">Professional FreeSWITCH Consulting Services: <br class=""><a href="mailto:consulting@freeswitch.org" class="">consulting@freeswitch.org</a><br class="">http://www.freeswitchsolutions.com<br class=""><br class="">Official FreeSWITCH Sites<br class="">http://www.freeswitch.org<br class="">http://confluence.freeswitch.org<br class="">http://www.cluecon.com<br class=""><br class="">FreeSWITCH-users mailing list<br class="">FreeSWITCH-users@lists.freeswitch.org<br class="">http://lists.freeswitch.org/mailman/listinfo/freeswitch-users<br class="">UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users<br class="">http://www.freeswitch.org</div></blockquote></div><br class=""></div></body></html>