<div dir="ltr"><div><div>Hi Dragos, <br></div>I tried to use your patch but have no luck with compiling it. <br><br></div>I clonne stable 1.2 and then replace mod_opus.c with your code. Maybe do you know how to fix it?<br><div><div><div><div><br>This is what I get:<br>d_opus/mod_opus.c -fPIC -DPIC -o .libs/mod_opus.o<br>/usr/src/freeswitch/src/mod/codecs/mod_opus/mod_opus.c: In function 'switch_opus_fmtp_parse':<br>/usr/src/freeswitch/src/mod/codecs/mod_opus/mod_opus.c:155:18: error: 'switch_codec_fmtp_t' has no member named 'stereo'<br>/usr/src/freeswitch/src/mod/codecs/mod_opus/mod_opus.c: In function 'switch_opus_decode':<br>/usr/src/freeswitch/src/mod/codecs/mod_opus/mod_opus.c:423:3: error: statement with no effect [-Werror=unused-value]<br>cc1: all warnings being treated as errors<br>make[4]: *** [mod_opus.lo] Error 1<br>make[3]: *** [all] Error 1<br>make[2]: *** [mod_opus-all] Error 1<br>make[1]: *** [mod_opus] Error 2<br>make: *** [mod_opus] Error 2<br><br></div></div></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">2015-04-14 14:52 GMT+06:00 Dragos Oancea <span dir="ltr"><<a href="mailto:droancea@yahoo.com" target="_blank">droancea@yahoo.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div style="color:#000;background-color:#fff;font-family:HelveticaNeue,Helvetica Neue,Helvetica,Arial,Lucida Grande,sans-serif;font-size:16px"><div><br></div><div>Hi Kamil,<br></div><div><br></div><div>I've done a patch for Opus with FEC , but it has not been merged:</div><div><a href="https://freeswitch.org/stash/projects/FS/repos/freeswitch/pull-requests/184/overview" target="_blank">https://freeswitch.org/stash/projects/FS/repos/freeswitch/pull-requests/184/overview</a></div><div>I was inspired by how they've done it with SILK.</div><div><br></div><div><br></div><div>Regards,</div><div>Dragos Oancea</div><div><br></div><div><br></div><div><br></div><div>On 2015-04-13 16:49, Kamil Nigmatullin wrote:</div><div>> Hello. </div><div>> </div><div>> Anybody from developers could please clarify if FreeSWITCH uses</div><div>> Forward Error Correction feature in opus codec? We actually are not a</div><div>> specialists in C and cannot fully understand how decode function works</div><div>> in 414 line. According to opus documentation decode function is</div><div>> called with special flag if previous packet is lost in order to call</div><div>> fec feature. In mod_opus it is hard to say for me as i don't see i or</div><div>> i+1 packets. Thanks </div><div>> _________________________________________________________________________</div><div>> Professional FreeSWITCH Consulting Services: </div><div>> <a href="mailto:consulting@freeswitch.org" target="_blank">consulting@freeswitch.org</a></div><div>> <a href="http://www.freeswitchsolutions.com" target="_blank">http://www.freeswitchsolutions.com</a></div><div>> </div><div>> Official FreeSWITCH Sites</div><div>> <a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a></div><div>> <a href="http://confluence.freeswitch.org" target="_blank">http://confluence.freeswitch.org</a></div><div>> <a href="http://www.cluecon.com" target="_blank">http://www.cluecon.com</a></div><div>> </div><div>> FreeSWITCH-users mailing list</div><div>> <a href="mailto:FreeSWITCH-users@lists.freeswitch.org" target="_blank">FreeSWITCH-users@lists.freeswitch.org</a></div><div>> <a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-users</a></div><div>> UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-users</a></div><div>> <a href="http://www.freeswitch.org/" target="_blank">http://www.freeswitch.org</a></div><div><br></div></div></div></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature"><div dir="ltr">Kamil Nigmatullin<br>Tel: 77272323748<br>mob: 7 (707) 2517003<br>Skype: kamil.nigmatullin</div></div>
</div>