<div dir="ltr">I suspect it's performing some sanity checks that git commit does not. Which you could then argue is either a bug or feature in git.<div><div><div class="gmail_extra"><br></div><div class="gmail_extra"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On 10 March 2015 at 11:33, Ben Langfeld <span dir="ltr"><<a href="mailto:ben@langfeld.co.uk" target="_blank">ben@langfeld.co.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">git fsck complains about it.<div><br></div><div><span><div>➭ git fsck</div><div>Checking object directories: 100% (256/256), done.</div><div>error in commit 487128950df6ee433c131b5feaafe81ee86629f4: invalid format - expected 'committer' line</div><div>error in commit 8574988c3a378b4d5861ecaeb0e958657635703b: invalid format - expected 'committer' line</div></span><div>Checking objects: 100% (294760/294760), done.</div><div>dangling commit f62e8f0e250b35bbadb7367082127304f3e72e74</div><div>dangling commit dc844f983605a015bf600232864122b94a278e76</div></div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On 9 March 2015 at 23:21, Ken Rice <span dir="ltr"><<a href="mailto:krice@freeswitch.org" target="_blank">krice@freeswitch.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<font face="Monaco, Courier New"><span style="font-size:11pt">Git itself doesn’t say this is an invalid commit (we use stash/git and its perfectly fine with this)... There is a git-lint process that github uses and it rejects this commit<span><br>
<br>
<br>
On 3/9/15, 6:57 PM, "Ben Langfeld" <<a href="http://ben@langfeld.co.uk" target="_blank">ben@langfeld.co.uk</a>> wrote:<br>
<br>
</span></span></font><blockquote><span><font face="Monaco, Courier New"><span style="font-size:11pt">I understand very well why rewriting history is undesirable and how git works. What I wonder is what process was used to convince git to create a commit which it would later say is invalid. As I said, I'm curious.<br>
<br>
On 9 March 2015 at 20:12, Steven Ayre <<a href="http://steveayre@gmail.com" target="_blank">steveayre@gmail.com</a>> wrote:<br>
</span></font></span><blockquote><span><font face="Monaco, Courier New"><span style="font-size:11pt">Plus it's rather annoying to do so (rewrite history). The identifier of each commit is a hash computed from the content of the commit plus the metadata which includes the authors. Changing the author would change the identifier of the commit. That then changes the identifier of every commit afterwards. That then breaks every checkout / fork based off the tree as they no longer know where they are forked from. And since identifiers have all been rewritten we would no longer know what version you were running, or what version bug reports were reported against.<br>
<br>
(that's why git makes it easy to amend your latest uncommitted commit message but rather difficult to edit any others)<br>
<br>
<br>
<br>
<br>
On 9 March 2015 at 13:41, Michael Jerris <<a href="http://mike@jerris.com" target="_blank">mike@jerris.com</a>> wrote:<br>
</span></font></span><blockquote><span><font face="Monaco, Courier New"><span style="font-size:11pt">We are not rewriting history to fix this so it doesn't really matter who is right or wrong.<br>
<br>
Mike<br>
<br>
</span></font></span><blockquote><span><font face="Monaco, Courier New"><span style="font-size:11pt">On Mar 9, 2015, at 9:13 AM, Ben Langfeld <<a href="http://ben@langfeld.co.uk" target="_blank">ben@langfeld.co.uk</a>> wrote:<br>
<br>
</span></font><font size="1"><font face="Helvetica, Verdana, Arial"><span style="font-size:9pt">I'm curious about this one... If git fsck complains about the issue, what is the justification for saying that Github is broken? How were these commits created with a format that git itself complains about?<br>
<br>
On 9 March 2015 at 09:01, <<a href="http://cmrienzo@gmail.com" target="_blank">cmrienzo@gmail.com</a>> wrote:<br>
</span></font></font></span><blockquote><font size="1"><font face="Helvetica, Verdana, Arial"><span style="font-size:9pt">I switched to <a href="http://bitbucket.org" target="_blank">bitbucket.org</a> <<a href="http://bitbucket.org/" target="_blank">http://bitbucket.org/</a>> just for the FreeSWITCH repo to work around this. <span><br>
<br>
<br>
On Mar 8, 2015, at 20:34, Ken Rice <<a href="http://krice@freeswitch.org" target="_blank">krice@freeswitch.org</a>> wrote:<br>
<br>
</span></span></font></font><blockquote><font face="Monaco, Courier New"><span style="font-size:11pt"><span>This is a known issue with github and will not be fixed <br>
<br>
<br>
<br></span><div><div>
On 3/8/15, 3:39 PM, "Podrigal, Aron" <<a href="http://aronp@guaranteedplus.com" target="_blank">aronp@guaranteedplus.com</a> <<a href="http://aronp@guaranteedplus.com/" target="_blank">http://aronp@guaranteedplus.com/</a>> > wrote:<br>
<br>
</div></div></span></font><div><div><blockquote><font face="Monaco, Courier New"><span style="font-size:11pt">Hi,<br>
<br>
I'm trying to push the freeswitch git repo to my github, but I get the following error<br>
<br>
<br>
remote: error: object 487128950df6ee433c131b5feaafe81ee86629f4:invalid format - expected 'committer' line<br>
remote: fatal: Error in object<br>
channel_by_id: 0: bad id: channel free<br>
Received window adjust for non-open channel 0.<br>
error: pack-objects died of signal 13<br>
<br>
This is caused by having multiple authors on a commit (which in general is not allowed by git) and github verifies the commits and rejects it.<br>
<br>
here is the output of git fsck<br>
<br>
Checking object directories: 100% (256/256), done.<br>
error in commit 487128950df6ee433c131b5feaafe81ee86629f4: invalid format - expected 'committer' line<br>
error in commit 8574988c3a378b4d5861ecaeb0e958657635703b: invalid format - expected 'committer' line<br>
Checking objects: 100% (254227/254227), done.<br>
<br>
</span></font></blockquote></div></div></blockquote></blockquote></blockquote><div><div><font face="Monaco, Courier New"><span style="font-size:11pt"><br>
<br>
_________________________________________________________________________<br>
Professional FreeSWITCH Consulting Services:<br>
<a href="http://consulting@freeswitch.org" target="_blank">consulting@freeswitch.org</a><br>
<a href="http://www.freeswitchsolutions.com" target="_blank">http://www.freeswitchsolutions.com</a><br>
<br>
Official FreeSWITCH Sites<br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
<a href="http://confluence.freeswitch.org" target="_blank">http://confluence.freeswitch.org</a><br>
<a href="http://www.cluecon.com" target="_blank">http://www.cluecon.com</a><br>
<br>
FreeSWITCH-users mailing list<br>
<a href="http://FreeSWITCH-users@lists.freeswitch.org" target="_blank">FreeSWITCH-users@lists.freeswitch.org</a><br>
<a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-users</a><br>
UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-users</a><br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
</span></font></div></div></blockquote><div><div><font face="Monaco, Courier New"><span style="font-size:11pt"><br>
<br>
_________________________________________________________________________<br>
Professional FreeSWITCH Consulting Services:<br>
<a href="http://consulting@freeswitch.org" target="_blank">consulting@freeswitch.org</a><br>
<a href="http://www.freeswitchsolutions.com" target="_blank">http://www.freeswitchsolutions.com</a><br>
<br>
Official FreeSWITCH Sites<br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
<a href="http://confluence.freeswitch.org" target="_blank">http://confluence.freeswitch.org</a><br>
<a href="http://www.cluecon.com" target="_blank">http://www.cluecon.com</a><br>
<br>
FreeSWITCH-users mailing list<br>
<a href="http://FreeSWITCH-users@lists.freeswitch.org" target="_blank">FreeSWITCH-users@lists.freeswitch.org</a><br>
<a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-users</a><br>
UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-users</a><br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
</span></font></div></div></blockquote><font face="Monaco, Courier New"><span style="font-size:11pt"><br>
<br>
<hr align="CENTER" size="3" width="95%"></span></font><span><font><font face="Consolas, Courier New, Courier"><span style="font-size:10pt">_________________________________________________________________________<br>
Professional FreeSWITCH Consulting Services: <br>
<a href="http://consulting@freeswitch.org" target="_blank">consulting@freeswitch.org</a><br>
<a href="http://www.freeswitchsolutions.com" target="_blank">http://www.freeswitchsolutions.com</a><br>
<br>
Official FreeSWITCH Sites<br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
<a href="http://confluence.freeswitch.org" target="_blank">http://confluence.freeswitch.org</a><br>
<a href="http://www.cluecon.com" target="_blank">http://www.cluecon.com</a><br>
<br>
FreeSWITCH-users mailing list<br>
<a href="http://FreeSWITCH-users@lists.freeswitch.org" target="_blank">FreeSWITCH-users@lists.freeswitch.org</a><br>
<a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-users</a><br>
UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-users</a><br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
</span></font></font></span></blockquote><font><font face="Consolas, Courier New, Courier"><span style="font-size:10pt"><br>
</span></font></font><span><font face="Monaco, Courier New"><span style="font-size:11pt">-- <br>
Ken<br>
<font color="#0000FF"><u><a href="http://www.FreeSWITCH.org" target="_blank">http://www.FreeSWITCH.org</a><br>
<a href="http://www.ClueCon.com" target="_blank">http://www.ClueCon.com</a><br>
<a href="http://www.OSTAG.org" target="_blank">http://www.OSTAG.org</a><br>
</u></font><a href="http://irc.freenode.net" target="_blank">irc.freenode.net</a> #freeswitch<br>
Twitter: @FreeSWITCH<br>
<br>
</span></font>
</span></div>
<br>_________________________________________________________________________<br>
Professional FreeSWITCH Consulting Services:<br>
<a href="mailto:consulting@freeswitch.org" target="_blank">consulting@freeswitch.org</a><br>
<a href="http://www.freeswitchsolutions.com" target="_blank">http://www.freeswitchsolutions.com</a><br>
<br>
Official FreeSWITCH Sites<br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
<a href="http://confluence.freeswitch.org" target="_blank">http://confluence.freeswitch.org</a><br>
<a href="http://www.cluecon.com" target="_blank">http://www.cluecon.com</a><br>
<br>
FreeSWITCH-users mailing list<br>
<a href="mailto:FreeSWITCH-users@lists.freeswitch.org" target="_blank">FreeSWITCH-users@lists.freeswitch.org</a><br>
<a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-users</a><br>
UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-users</a><br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br></blockquote></div><br></div>
</div></div><br>_________________________________________________________________________<br>
Professional FreeSWITCH Consulting Services:<br>
<a href="mailto:consulting@freeswitch.org" target="_blank">consulting@freeswitch.org</a><br>
<a href="http://www.freeswitchsolutions.com" target="_blank">http://www.freeswitchsolutions.com</a><br>
<br>
Official FreeSWITCH Sites<br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
<a href="http://confluence.freeswitch.org" target="_blank">http://confluence.freeswitch.org</a><br>
<a href="http://www.cluecon.com" target="_blank">http://www.cluecon.com</a><br>
<br>
FreeSWITCH-users mailing list<br>
<a href="mailto:FreeSWITCH-users@lists.freeswitch.org" target="_blank">FreeSWITCH-users@lists.freeswitch.org</a><br>
<a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-users</a><br>
UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-users</a><br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br></blockquote></div><br></div></div></div></div>