<div dir="ltr">I got a couple of reviews and comments and replied to them. What's the process of approving and merging this to master?</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 1, 2014 at 5:54 AM, Oleg Stolyar <span dir="ltr"><<a href="mailto:olegstolyar@gmail.com" target="_blank">olegstolyar@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Guys,<div><br><div>could someone take a look at this pull request? I understand that it's not the highest priority but it's very small.</div><div><a href="https://stash.freeswitch.org/projects/FS/repos/freeswitch/pull-requests/56/overview" target="_blank">https://stash.freeswitch.org/projects/FS/repos/freeswitch/pull-requests/56/overview</a><br></div></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Sep 14, 2014 at 9:18 AM, Oleg Stolyar <span dir="ltr"><<a href="mailto:olegstolyar@gmail.com" target="_blank">olegstolyar@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Pull request created. Thanks Michael, Steven, <span style="color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px">Dušan!</span></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Sep 14, 2014 at 8:46 AM, Oleg Stolyar <span dir="ltr"><<a href="mailto:olegstolyar@gmail.com" target="_blank">olegstolyar@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks Dušan!<br><div><br></div><div>Jira account I already have. Will start the process.</div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Sep 14, 2014 at 7:45 AM, Dušan Dragić <span dir="ltr"><<a href="mailto:dragic.dusan@gmail.com" target="_blank">dragic.dusan@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">There is a nice guide (with pictures!) at<br>
<a href="https://confluence.freeswitch.org/display/FREESWITCH/Pull+Requests" target="_blank">https://confluence.freeswitch.org/display/FREESWITCH/Pull+Requests</a><br>
Just one thing, there's no need to clone your forked repo if you<br>
already have a copy of main freeswitch repo.<br>
Add it as a new remote (git remote add ...), push to it and then<br>
continue with creating the pull request etc.<br>
<div><div><br>
On 14 September 2014 16:15, Oleg Stolyar <<a href="mailto:olegstolyar@gmail.com" target="_blank">olegstolyar@gmail.com</a>> wrote:<br>
> I've made the changes (using regex) but I believe I need a login to commit<br>
> to a branch before make a pull request on <a href="http://stash.freeswitch.org" target="_blank">stash.freeswitch.org</a>.<br>
><br>
> Can I get that or can I send my changes to someone to quickly review and<br>
> commit them? It's just two files - mod_xml_rpc.c and xml_rpc.conf.xml in<br>
> the vanilla conf where I added a commented out example and a comment<br>
> explaning what it does.<br>
><br>
> On Fri, Sep 12, 2014 at 5:27 PM, Oleg Stolyar <<a href="mailto:olegstolyar@gmail.com" target="_blank">olegstolyar@gmail.com</a>> wrote:<br>
>><br>
>> Those are excellent ideas Steven, thanks!<br>
>><br>
>> I am thinking of implementing the configurability by adding the strings or<br>
>> regex patterns to the config file. Only commands that contain those<br>
>> patterns will be logged. It's been a looooong time since I worked with C,<br>
>> so this may take me a bit of time.<br>
>><br>
>> One question that'll need to be decided - should I allow regex patterns in<br>
>> the config file or just a list of strings that will be compared to the<br>
>> command + api_str using simple stristr. What do you think?<br>
>><br>
>> On Fri, Sep 12, 2014 at 4:39 PM, Steven Ayre <<a href="mailto:steveayre@gmail.com" target="_blank">steveayre@gmail.com</a>> wrote:<br>
>>><br>
>>> You can submit it as a pull request on <a href="http://stash.freeswitch.org" target="_blank">stash.freeswitch.org</a><br>
>>><br>
>>> I'd suggest though that a) you make it debug not info and b) make it<br>
>>> configurable (at least so you can enable it, disabled by default - you could<br>
>>> also allow the user to configure the logging level. In some use cases a busy<br>
>>> server it could result in a lot of logging which may be undesirable.<br>
>>><br>
>>><br>
>>><br>
>>><br>
>>> On 13 September 2014 00:12, Oleg Stolyar <<a href="mailto:olegstolyar@gmail.com" target="_blank">olegstolyar@gmail.com</a>> wrote:<br>
>>>><br>
>>>> Thanks Michael!<br>
>>>><br>
>>>> I added this as line 1057 in mod_xml_rpc.c<br>
>>>><br>
>>>> switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_INFO, "Executed HTTP<br>
>>>> request command: %s. Args: %s.\n", command, api_str);<br>
>>>><br>
>>>> Could someone review it and check it into the repo?<br>
>>>><br>
>>>><br>
>>>> On Fri, Sep 12, 2014 at 1:33 PM, Michael Jerris <<a href="mailto:mike@jerris.com" target="_blank">mike@jerris.com</a>> wrote:<br>
>>>>><br>
>>>>> I suspect it requires a 1 line code change to the mod_xml_rpc.c to log<br>
>>>>> before executing. It would be somewhere right around mod_xml_rpc.c line<br>
>>>>> 1056 (which is the line that actually executes the command).<br>
>>>>><br>
>>>>><br>
>>>>> On Sep 11, 2014, at 7:21 PM, Oleg Stolyar <<a href="mailto:olegstolyar@gmail.com" target="_blank">olegstolyar@gmail.com</a>><br>
>>>>> wrote:<br>
>>>>><br>
>>>>> > Guys,<br>
>>>>> ><br>
>>>>> > is there a way to log cli commands that are being executed? More<br>
>>>>> > specifically I use the txtapi command from the xml_rpc module and need to be<br>
>>>>> > able to see when FreeSWITCH received and executed each command with<br>
>>>>> > argument. Is it doable already or would it require a code change?<br>
>>>>> ><br>
>>>>> > I already have this in my logfile.conf.xml<br>
>>>>> > <map name="all" value="debug,info,notice,warning,err,crit,alert"/><br>
>>>>> ><br>
>>>>><br>
>>>>><br>
>>>>><br>
>>>>> _________________________________________________________________________<br>
>>>>> Professional FreeSWITCH Consulting Services:<br>
>>>>> <a href="mailto:consulting@freeswitch.org" target="_blank">consulting@freeswitch.org</a><br>
>>>>> <a href="http://www.freeswitchsolutions.com" target="_blank">http://www.freeswitchsolutions.com</a><br>
>>>>><br>
>>>>> Official FreeSWITCH Sites<br>
>>>>> <a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
>>>>> <a href="http://confluence.freeswitch.org" target="_blank">http://confluence.freeswitch.org</a><br>
>>>>> <a href="http://www.cluecon.com" target="_blank">http://www.cluecon.com</a><br>
>>>>><br>
>>>>> FreeSWITCH-powered IP PBX: The CudaTel Communication Server<br>
>>>>> <a href="http://www.cudatel.com" target="_blank">http://www.cudatel.com</a><br>
>>>>><br>
>>>>> FreeSWITCH-users mailing list<br>
>>>>> <a href="mailto:FreeSWITCH-users@lists.freeswitch.org" target="_blank">FreeSWITCH-users@lists.freeswitch.org</a><br>
>>>>> <a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-users</a><br>
>>>>><br>
>>>>> UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-users</a><br>
>>>>> <a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
>>>><br>
>>>><br>
>>>><br>
>>>><br>
>>>> _________________________________________________________________________<br>
>>>> Professional FreeSWITCH Consulting Services:<br>
>>>> <a href="mailto:consulting@freeswitch.org" target="_blank">consulting@freeswitch.org</a><br>
>>>> <a href="http://www.freeswitchsolutions.com" target="_blank">http://www.freeswitchsolutions.com</a><br>
>>>><br>
>>>> Official FreeSWITCH Sites<br>
>>>> <a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
>>>> <a href="http://confluence.freeswitch.org" target="_blank">http://confluence.freeswitch.org</a><br>
>>>> <a href="http://www.cluecon.com" target="_blank">http://www.cluecon.com</a><br>
>>>><br>
>>>> FreeSWITCH-powered IP PBX: The CudaTel Communication Server<br>
>>>> <a href="http://www.cudatel.com" target="_blank">http://www.cudatel.com</a><br>
>>>><br>
>>>> FreeSWITCH-users mailing list<br>
>>>> <a href="mailto:FreeSWITCH-users@lists.freeswitch.org" target="_blank">FreeSWITCH-users@lists.freeswitch.org</a><br>
>>>> <a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-users</a><br>
>>>> UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-users</a><br>
>>>> <a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
>>><br>
>>><br>
>>><br>
>>> _________________________________________________________________________<br>
>>> Professional FreeSWITCH Consulting Services:<br>
>>> <a href="mailto:consulting@freeswitch.org" target="_blank">consulting@freeswitch.org</a><br>
>>> <a href="http://www.freeswitchsolutions.com" target="_blank">http://www.freeswitchsolutions.com</a><br>
>>><br>
>>> Official FreeSWITCH Sites<br>
>>> <a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
>>> <a href="http://confluence.freeswitch.org" target="_blank">http://confluence.freeswitch.org</a><br>
>>> <a href="http://www.cluecon.com" target="_blank">http://www.cluecon.com</a><br>
>>><br>
>>> FreeSWITCH-powered IP PBX: The CudaTel Communication Server<br>
>>> <a href="http://www.cudatel.com" target="_blank">http://www.cudatel.com</a><br>
>>><br>
>>> FreeSWITCH-users mailing list<br>
>>> <a href="mailto:FreeSWITCH-users@lists.freeswitch.org" target="_blank">FreeSWITCH-users@lists.freeswitch.org</a><br>
>>> <a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-users</a><br>
>>> UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-users</a><br>
>>> <a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
>><br>
>><br>
><br>
><br>
> _________________________________________________________________________<br>
> Professional FreeSWITCH Consulting Services:<br>
> <a href="mailto:consulting@freeswitch.org" target="_blank">consulting@freeswitch.org</a><br>
> <a href="http://www.freeswitchsolutions.com" target="_blank">http://www.freeswitchsolutions.com</a><br>
><br>
> Official FreeSWITCH Sites<br>
> <a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
> <a href="http://confluence.freeswitch.org" target="_blank">http://confluence.freeswitch.org</a><br>
> <a href="http://www.cluecon.com" target="_blank">http://www.cluecon.com</a><br>
><br>
> FreeSWITCH-powered IP PBX: The CudaTel Communication Server<br>
> <a href="http://www.cudatel.com" target="_blank">http://www.cudatel.com</a><br>
><br>
> FreeSWITCH-users mailing list<br>
> <a href="mailto:FreeSWITCH-users@lists.freeswitch.org" target="_blank">FreeSWITCH-users@lists.freeswitch.org</a><br>
> <a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-users</a><br>
> UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-users</a><br>
> <a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
<br>
<br>
<br>
</div></div><span><font color="#888888">--<br>
Dušan Dragić<br>
</font></span><div><div><br>
_________________________________________________________________________<br>
Professional FreeSWITCH Consulting Services:<br>
<a href="mailto:consulting@freeswitch.org" target="_blank">consulting@freeswitch.org</a><br>
<a href="http://www.freeswitchsolutions.com" target="_blank">http://www.freeswitchsolutions.com</a><br>
<br>
Official FreeSWITCH Sites<br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
<a href="http://confluence.freeswitch.org" target="_blank">http://confluence.freeswitch.org</a><br>
<a href="http://www.cluecon.com" target="_blank">http://www.cluecon.com</a><br>
<br>
FreeSWITCH-powered IP PBX: The CudaTel Communication Server<br>
<a href="http://www.cudatel.com" target="_blank">http://www.cudatel.com</a><br>
<br>
FreeSWITCH-users mailing list<br>
<a href="mailto:FreeSWITCH-users@lists.freeswitch.org" target="_blank">FreeSWITCH-users@lists.freeswitch.org</a><br>
<a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-users</a><br>
UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-users</a><br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a></div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>