<div>I know the solution of putting "if(!session.ready())exit()" to every check point. But as my script already has nearly 3000 lines, there are too many "if(!session.ready())exit()" to add.</div><div><br>
</div><div>I tried error(); it works just because error is not defined. Using intentional mistake to force exit is creative but strange.</div><div>After some thoughts I found that throw a user defined exception in the hook may be a better way to force exit without the red [ERR] line.</div>
<div><br></div><div>By the way, I still feel that let exit() in the hook stop the whole script instead of the hook only seems to be more consistent because they are not executed in separate thread. Would you please consider this if it is not difficult? Thanks.</div>
<br><br><div class="gmail_quote">On Sat, Jul 24, 2010 at 6:17 AM, Anthony Minessale <span dir="ltr"><<a href="mailto:anthony.minessale@gmail.com">anthony.minessale@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
if session.ready is false it means the channel is hungup.<div><div><br></div><div><div>error(); will exit your script.</div><div><br></div><div>you can probably remove some of them if you are getting better results with the patch.</div>
<div><div></div><div class="h5">
<div><br></div><div><br><br><div class="gmail_quote">On Fri, Jul 23, 2010 at 4:56 PM, xuyan yang <span dir="ltr"><<a href="mailto:xyangni@gmail.com" target="_blank">xyangni@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks for your update. I have tested it again base on the latest git tree, the hangup hook does work every time and the script continue to run without error message. <div><br></div><div>But this behaviour change caused another problem as I still need to stop the script when the session is hangup. </div>
<div>Adding if(session.ready()) to every line of my script does not seem to be a good solution. So I decided to call exit() in the hangup hook. However the test result is that exit() in hangup hook only works the same as "return". That means exit() in hangup hook only stops the hook while the main program can not be stopped.</div>
<div><br></div><div>Is there any good solution to stop the script immediately when hangup?</div><div><div></div><div><div><br><div class="gmail_quote">On Sat, Jul 24, 2010 at 3:13 AM, Anthony Minessale <span dir="ltr"><<a href="mailto:anthony.minessale@gmail.com" target="_blank">anthony.minessale@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">give lastest HEAD a try, I pushed in some more checks and made calling session.hangup() nonfatal when it's already hungup.<div>
<br><div><div><div></div><div><br><div class="gmail_quote">On Fri, Jul 23, 2010 at 1:27 PM, xuyan yang <span dir="ltr"><<a href="mailto:xyangni@gmail.com" target="_blank">xyangni@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I added many <span style="font-family:arial, sans-serif;font-size:13px;border-collapse:collapse">session.ready() as below and re-do the test again.</span><div>
<font face="arial, sans-serif"><span style="border-collapse:collapse">the steps are:</span></font></div>
<div><font face="arial, sans-serif"><span style="border-collapse:collapse">1. type jsrun test.js in fs_cli</span></font></div><div><font face="arial, sans-serif"><span style="border-collapse:collapse">2. answer the call in x-lite.</span></font></div>
<div><font face="arial, sans-serif"><span style="border-collapse:collapse">3. when I hear the speech, hangup the call in about 1 second.</span></font></div><div><font face="arial, sans-serif"><span style="border-collapse:collapse">4 check the log to find "</span></font><span style="font-family:arial, sans-serif;font-size:13px;border-collapse:collapse">hangup!!!!!!!!!!!!!"</span></div>
<div><br><div>the result is that</div><div> about half of the test failed to call hangup hook.</div><div>in all tests the script end up with [ERR] inline:1 Session is not active! then the script stopped and session.ready() near the end can not get the chance to run.</div>
<div><br></div><div><br></div><div><br></div><div><span style="font-family:arial, sans-serif;font-size:13px;border-collapse:collapse"><div><div>////test.js</div><div>function on_hangup(session, how){</div>
<div><span style="white-space:pre-wrap"> </span>console_log("notice","hangup!!!!!!!!!!!!!\n");</div><div>}</div><div><br></div><div>session = new Session("sofia/gateway/12voip-out/*********");</div>
<div>session.waitForAnswer();</div></div><div>session.ready();</div><div><div>session.execute("set","continue_on_fail=true");</div><div>var res=session.setHangupHook(on_hangup);</div><div>console_log("notice","res:"+res+"\n");</div>
</div><div>if(session.ready())session.execute("speak", "This is an example of flite text to speech engine. We can test the work of hanguphook.");</div><div>if(session.ready())session.execute("speak","you are calling from " + session.caller_id_num + " You are calling " + session.destination );</div>
<div>session.ready();</div><div>session.hangup();</div></span></div><div><div></div><div><div><br><div class="gmail_quote">On Sat, Jul 24, 2010 at 1:08 AM, Anthony Minessale <span dir="ltr"><<a href="mailto:anthony.minessale@gmail.com" target="_blank">anthony.minessale@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p>It checks before and after blocking calls like that.<br>
</p>
<p></p><blockquote type="cite"><div>On Jul 23, 2010 11:53 AM, "Dan" <<a href="mailto:freeswitch-users@digitaldan.com" target="_blank">freeswitch-users@digitaldan.com</a>> wrote:<br><br></div><div>
<div style="font-family:Times New Roman;font-size:12pt;color:#000000"><div>
So If I call session.recordFile which blocks in code until the user hangs up, and can't make periodic calls to session.ready, is the hangup hook not realiable in this scenario? <br><br><hr><b>From: </b>"Anthony Minessale" <<a href="mailto:anthony.minessale@gmail.com" target="_blank">anthony.minessale@gmail.com</a>><br>
<b>To: </b>"FreeSWITCH Users Help" <<a href="mailto:freeswitch-users@lists.freeswitch.org" target="_blank">freeswitch-users@lists.freeswitch.org</a>><br><b>Sent: </b>Thursday, July 22, 2010 10:30:48 AM<br>
<b>Subject: </b>Re: [Freeswitch-users] Unstable hangup hook in javascript</div><p><font color="#500050"><br><br>You must make periodic calls to session.ready() or some other freeswitch api functions to trigger ...</font></p>
</div>
</div><div><br>_______________________________________________<br>
FreeSWITCH-users mailing list<br>
<a href="mailto:FreeSWITCH-users@lists.freeswitch.org" target="_blank">FreeSWITCH-users@lists.freeswitch.org</a><br>
<a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-users</a><br>
UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-users</a><br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
<br></div></blockquote><p></p>
<br>_______________________________________________<br>
FreeSWITCH-users mailing list<br>
<a href="mailto:FreeSWITCH-users@lists.freeswitch.org" target="_blank">FreeSWITCH-users@lists.freeswitch.org</a><br>
<a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-users</a><br>
UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-users</a><br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
<br></blockquote></div><br></div></div></div></div>
<br>_______________________________________________<br>
FreeSWITCH-users mailing list<br>
<a href="mailto:FreeSWITCH-users@lists.freeswitch.org" target="_blank">FreeSWITCH-users@lists.freeswitch.org</a><br>
<a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-users</a><br>
UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-users</a><br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
<br></blockquote></div><br><br clear="all"><br></div></div><div>-- <br>Anthony Minessale II<br><br>FreeSWITCH <a href="http://www.freeswitch.org/" target="_blank">http://www.freeswitch.org/</a><br>ClueCon <a href="http://www.cluecon.com/" target="_blank">http://www.cluecon.com/</a><br>
Twitter: <a href="http://twitter.com/FreeSWITCH_wire" target="_blank">http://twitter.com/FreeSWITCH_wire</a><br><br>AIM: anthm<br><a href="mailto:MSN%3Aanthony_minessale@hotmail.com" target="_blank">MSN:anthony_minessale@hotmail.com</a><br>
GTALK/JABBER/<a href="mailto:PAYPAL%3Aanthony.minessale@gmail.com" target="_blank">PAYPAL:anthony.minessale@gmail.com</a><br>
IRC: <a href="http://irc.freenode.net" target="_blank">irc.freenode.net</a> #freeswitch<br><br>FreeSWITCH Developer Conference<br><a href="mailto:sip%3A888@conference.freeswitch.org" target="_blank">sip:888@conference.freeswitch.org</a><br>
<a href="mailto:googletalk%3Aconf%2B888@conference.freeswitch.org" target="_blank">googletalk:conf+888@conference.freeswitch.org</a><br>
pstn:+19193869900<br>
</div></div></div>
<br>_______________________________________________<br>
FreeSWITCH-users mailing list<br>
<a href="mailto:FreeSWITCH-users@lists.freeswitch.org" target="_blank">FreeSWITCH-users@lists.freeswitch.org</a><br>
<a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-users</a><br>
UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-users</a><br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
FreeSWITCH-users mailing list<br>
<a href="mailto:FreeSWITCH-users@lists.freeswitch.org" target="_blank">FreeSWITCH-users@lists.freeswitch.org</a><br>
<a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-users</a><br>
UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-users</a><br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br>Anthony Minessale II<br><br>FreeSWITCH <a href="http://www.freeswitch.org/" target="_blank">http://www.freeswitch.org/</a><br>ClueCon <a href="http://www.cluecon.com/" target="_blank">http://www.cluecon.com/</a><br>
Twitter: <a href="http://twitter.com/FreeSWITCH_wire" target="_blank">http://twitter.com/FreeSWITCH_wire</a><br><br>AIM: anthm<br><a href="mailto:MSN%3Aanthony_minessale@hotmail.com" target="_blank">MSN:anthony_minessale@hotmail.com</a><br>
GTALK/JABBER/<a href="mailto:PAYPAL%3Aanthony.minessale@gmail.com" target="_blank">PAYPAL:anthony.minessale@gmail.com</a><br>
IRC: <a href="http://irc.freenode.net" target="_blank">irc.freenode.net</a> #freeswitch<br><br>FreeSWITCH Developer Conference<br><a href="mailto:sip%3A888@conference.freeswitch.org" target="_blank">sip:888@conference.freeswitch.org</a><br>
<a href="mailto:googletalk%3Aconf%2B888@conference.freeswitch.org" target="_blank">googletalk:conf+888@conference.freeswitch.org</a><br>
pstn:+19193869900<br>
</div></div></div></div></div>
<br>_______________________________________________<br>
FreeSWITCH-users mailing list<br>
<a href="mailto:FreeSWITCH-users@lists.freeswitch.org">FreeSWITCH-users@lists.freeswitch.org</a><br>
<a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-users</a><br>
UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-users" target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-users</a><br>
<a href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br>
<br></blockquote></div><br>