<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Apr 10, 2009, at 1:35 AM, Traun Leyden wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><br>Hey you beat me to it. I was going to have a look this morning but<br>had no internet because some asswipe cut a bunch of fiber optic cables<br>and took out phone/internet for a big part of the bay area.<br><br>I haven't tried your patch yet, but I see something that looks suspect:<br> <br><a href="http://fisheye.freeswitch.org/browse/FreeSWITCH/src/switch_cpp.cpp?r=12958">http://fisheye.freeswitch.org/browse/FreeSWITCH/src/switch_cpp.cpp?r=12958</a><br><br>In <span class="annLine" title="8238 anthm > 11 months"><span class="hl_identifier">playAndGetDigits() there are now two calls to </span></span><span class="annLine" title="12958 anthm > 16 hours"><span class="hl_identifier">begin_allow_threads</span>() <br> (line 778 and 780) followed by only one call to end_allow_threads() (line 793)</span></blockquote><div><br></div>Extra line removed, I did notice when looking in that file other methods that probably need begin/end, for example the blocking pop in event consumer. Would you mind going through the rest and seeing if their are other obvious misses?</div><div><br></div><div>Mike</div><div><br><blockquote type="cite"><span class="annLine" title="12958 anthm > 16 hours"><br>Also I guess it would have better to test against JS, since it should have<br>had the same bug right? Lua just ignores the threadswapping stuff but<br> IIRC javascript uses it in much the same way as python. Or did I miss something?<br></span></blockquote></div><br></body></html>