[Freeswitch-users] valet_park and caller Id number

[Preston Hagar]

I'll make myself a note to try and see if I can circle back around someday
if possible and do that.  I'm happy to share the code if anyone else wants
to do the extra work of adding a config option and making a patch request.
I'm unfortunately too tied up right now trying to get my final caller ID
name bug fixed.  It seems I may be the last person still using PRIs :)  (or
at least no one uses PRIs with FreeSWITCH).



On Fri, Apr 27, 2018 at 5:06 PM, Joel Serrano <joel at gogii.net> wrote:

> Maybe you can make that functionality configurable and submit a PR to
> upstream?
>
> I’m sure someone can/will benefit from your effort.
>
> Joel.
>
> On Fri, Apr 27, 2018 at 13:47 Preston Hagar <prestonh at gmail.com> wrote:
>
>> Just thought I would send a followup in case someone ever runs into the
>> same problem and comes across this thread later.
>>
>> We ended up having to modify mod_valet_parking.c to pull in the
>> caller_id_number channel variable and then added it as an
>> event_header_string.
>>
>> Then in sofia_presence.c we edited the section that builds the presence
>> XML for parked calls and grabbed that caller ID number and put it in the
>> <remote><identity display="" section instead of just having the word "park"
>> hardcoded like it is now.
>>
>> We now get caller Id numbers on things like Voice Operator Panel by
>> having it monitor the presence on the parked extensions.
>>
>> If anyone ever needs the code, feel free to contact me and I'm happy to
>> share.
>>
>> On Thu, Apr 19, 2018 at 1:23 PM, Preston Hagar <prestonh at gmail.com>
>> wrote:
>>
>>> I've setup mod_valet_park to have a set of "parking slots" so that our
>>> receptionist can park the calls in, page for someone to pickup, and then
>>> that person can dial in and pick up.  That is all working well.
>>>
>>> I'm using Voice Operator Panel (VOP) for the receptionist software and
>>> want them to be able to monitor presence on the parking slots so that they
>>> can see which ones have calls parked that haven't been picked up.  I'd also
>>> like them to be able to see the caller id of the call parked in each slot.
>>>
>>> VOP is monitoring presence fine, but for callerId it just shows "park"
>>> as the number.  I traced the presence packets in the console and the
>>> problem is that in the remote->identity display section of the notify
>>> packet, it has "park" as the value to display, instead of the caller id
>>> number parked there.
>>>
>>> (see example XML below).
>>>
>>> I have a couple of questions:
>>>
>>> 1.  Is it even possible to get mod_valet_park/freeswitch to report the
>>> parked caller id number in presence requests in the current
>>> mod_valet_park?  If so, how is it done?
>>>
>>> 2.  If it isn't in the current code, can anyone point me to the code
>>> block that generates that remote XML section of the presence notification?
>>> I poked around in the valet_send_presence function of mod_valet_parking.c,
>>> but can't seem to figure out how that block is built.  I will admit that
>>> I'm still getting up to speed on how Presence works in FreeSWITCH.
>>>
>>> Thanks for your help!
>>>
>>> Here is a sample notify block:
>>>
>>> <?xml version="1.0"?>
>>>       <dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info"
>>> version="0" state="full" entity="sip:park+8001 at pbx.
>>> myfreeswitchdomain.com">
>>>         <dialog id="8001" direction="recipient">
>>>          <state>confirmed</state>
>>>           <local>
>>>              <identity display="park">sip:8001 at pbx.
>>> myfreeswitchdomain.com;proto=park</identity>
>>>               <target uri="sip:8001 at pbx.myfreeswitchdomain.com;proto=
>>> park">
>>>                 <param pname="+sip.rendering" pvalue="no"/>
>>>                </target>
>>>             </local>
>>>             <remote>
>>>               <identity display="park">sip:8001</identity>
>>>               <target uri="sip:park+8001 at pbx.myfreeswitchdomain.com"/>
>>>             </remote>
>>>            </dialog>
>>>         </dialog-info>
>>>
>>>
>>>
>>>
>> _________________________________________________________________________
>> Professional FreeSWITCH Consulting Services:
>> consulting at freeswitch.org
>> http://www.freeswitchsolutions.com
>>
>> Official FreeSWITCH Sites
>> http://www.freeswitch.org
>> http://confluence.freeswitch.org
>> http://www.cluecon.com
>>
>> FreeSWITCH-users mailing list
>> FreeSWITCH-users at lists.freeswitch.org
>> http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
>> UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
>> http://www.freeswitch.org
>
>
> _________________________________________________________________________
> Professional FreeSWITCH Consulting Services:
> consulting at freeswitch.org
> http://www.freeswitchsolutions.com
>
> Official FreeSWITCH Sites
> http://www.freeswitch.org
> http://confluence.freeswitch.org
> http://www.cluecon.com
>
> FreeSWITCH-users mailing list
> FreeSWITCH-users at lists.freeswitch.org
> http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
> UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
> http://www.freeswitch.org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freeswitch.org/pipermail/freeswitch-users/attachments/20180430/ead33850/attachment.html>