[Freeswitch-users] week day and time condition possible bug

[Steven Ayre]

> the proper way to include an entire day is 00:00:00-23:59:59 which covers
all possible seconds in a range

What about 23:59:60? ;)

Bipin, if you're matching on the entire day, why do you need the
time-of-day attribute at all? wday would be enough on its own.

On 4 September 2016 at 16:14, Ken Rice <krice at freeswitch.org> wrote:

> Ok lets try to make sense of this.
>
> The time-of-day matching in your initial email
> >>       <condition wday="1-2" time-of-day="00:00:00-00:00:00"
> break="never">
>
> happens in 2 stages... stage 1) does wday fall in the range of 1-2
> wday="1-2"
> wdaymin = 1
> wdayamx = 2
> so does if (today >= wday-min || today <= wday-max).... if you set this
> for 0-0 or 1-1 then only day 0 or only day 1 would match. Now the above
> example is simplified psuedo code just for the sake of explanation...
>
> The time-of-day matching works similarly... after the value for the time
> of day field is parsed the following if statement (actually taken from the
> code) happens
>
> if (range_start <= range_end ? (val >= range_start && val <= range_end) :
> (val >= range_start || val <= range_end)) { ... }
>
> so this allos for the range_end to be a lower value... however the same
> thing happens does the current time val fall in the range of times... so if
> you set the start and the end time to 00:00:00 the only time it will match
> is 00:00:00. lets reduce this for the sake of simplicity from the long date
> to just seconds of the day... 00:00:00 == second 0 for the day... so
>
>
> range start is <= range_end (in fact its 0) so ... we'll do the true half
> of the expression?true:false statement there...
> if (val >= range_start && val <= range_end)  where val is the current
> number of seconds into today...
>
> so you have told it that the only range that can match is 0 thru 0
> inclusive... how can any other time match...
>
> so in your example there are only 2 times that will match 00:00:00 on day
> 1 and 00:00:00 on day 2...
>
> the proper way to include an entire day is 00:00:00-23:59:59 which covers
> all possible seconds in a range
>
>
>
> On Sun, Sep 4, 2016 at 9:35 AM, Bipin Patel <bipin at xbipin.com> wrote:
>
>> well but if u follow the guide of wrap around time similar to my 3rd
>> condition then doesnt it need to be true or does it only work when 'a' hour
>> is higher than 'b' in a "a-b" time span because if u specify a range of
>> "05:00-05:00" then this would also be zero even though u set a weekday of
>> "1-2"
>>
>>
>> Regards,
>> Bipin
>>
>>
>> ------------------------------
>> -------- Original Message --------
>> Subject: Re: [Freeswitch-users] week day and time condition possible bug
>> From: Ken Rice <krice at freeswitch.org> <krice at freeswitch.org>
>> To: FreeSWITCH Users Help <freeswitch-users at lists.freeswitch.org>
>> <freeswitch-users at lists.freeswitch.org>
>> Date: 9/4/2016, 6:14:44 PM
>>
>> No it tells it second 0 to second 0 on days days 1 and 2
>>
>>
>>
>> Sent from my iPhone
>>
>> On Sep 4, 2016, at 8:45 AM, Bipin Patel <bipin at xbipin.com> wrote:
>>
>> but doesnt specifying 1-2 as weekday tell it Sunday 0 to Monday 0
>>
>>
>> Regards,
>> Bipin
>>
>>
>> ------------------------------
>> -------- Original Message --------
>> Subject: Re: [Freeswitch-users] week day and time condition possible bug
>> From: Ken Rice <krice at freeswitch.org> <krice at freeswitch.org>
>> To: FreeSWITCH Users Help <freeswitch-users at lists.freeswitch.org>
>> <freeswitch-users at lists.freeswitch.org>
>> Date: 9/4/2016, 5:35:09 PM
>>
>> Its a misconfig you are specifying only 1 second where the first
>> condition can fire 0 thru 0 is just 0
>>
>> Sent from my iPhone
>>
>> On Sep 4, 2016, at 8:24 AM, Bipin Patel <bipin at xbipin.com> wrote:
>>
>> i found one bug today relating to conditions where day and date are used,
>> just wanted to confirm if its a bug or a misconfig
>>
>> i have a condition as below
>>
>>       <condition wday="1-2" time-of-day="00:00:00-00:00:00"
>> break="never">
>>           <action application="set" data="out-prefix=777" inline="true"/>
>>       </condition>
>>
>> what this does is if its a Sunday to Monday morning then set out-prefix
>> variable to 777 but even though being a Sunday this always parses as fail
>> unless i set wday to 1 and time-of-day to 00:00:00-23:59:59
>>
>> the reason i use the above is because i have more conditions which r as
>> follows
>>
>>       <condition wday="2-7" time-of-day="7:00-21:00" break="never">
>>           <action application="set" data="out-prefix=888" inline="true"/>
>>       </condition>
>>       <condition wday="2-7" time-of-day="21:00:00-7:00:00" break="never">
>>           <action application="set" data="out-prefix=777" inline="true"/>
>>       </condition>
>>
>>
>> --
>> Regards,
>> Bipin
>>
>>
>> ------------------------------
>>
>> _________________________________________________________________________
>> Professional FreeSWITCH Consulting Services:
>> consulting at freeswitch.org
>> http://www.freeswitchsolutions.com
>>
>> Official FreeSWITCH Sites
>> http://www.freeswitch.org
>> http://confluence.freeswitch.org
>> http://www.cluecon.com
>>
>> FreeSWITCH-users mailing list
>> FreeSWITCH-users at lists.freeswitch.org
>> http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
>> UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
>> http://www.freeswitch.org
>>
>>
>>
>> _________________________________________________________________________
>> Professional FreeSWITCH Consulting Services: consulting at freeswitch.orghttp://www.freeswitchsolutions.com
>>
>> Official FreeSWITCH Siteshttp://www.freeswitch.orghttp://confluence.freeswitch.orghttp://www.cluecon.com
>>
>> FreeSWITCH-users mailing listFreeSWITCH-users at lists.freeswitch.orghttp://lists.freeswitch.org/mailman/listinfo/freeswitch-users
>> UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-usershttp://www.freeswitch.org
>>
>>
>> _________________________________________________________________________
>> Professional FreeSWITCH Consulting Services:
>> consulting at freeswitch.org
>> http://www.freeswitchsolutions.com
>>
>> Official FreeSWITCH Sites
>> http://www.freeswitch.org
>> http://confluence.freeswitch.org
>> http://www.cluecon.com
>>
>> FreeSWITCH-users mailing list
>> FreeSWITCH-users at lists.freeswitch.org
>> http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
>> UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
>> http://www.freeswitch.org
>>
>>
>>
>> _________________________________________________________________________
>> Professional FreeSWITCH Consulting Services: consulting at freeswitch.orghttp://www.freeswitchsolutions.com
>>
>> Official FreeSWITCH Siteshttp://www.freeswitch.orghttp://confluence.freeswitch.orghttp://www.cluecon.com
>>
>> FreeSWITCH-users mailing listFreeSWITCH-users at lists.freeswitch.orghttp://lists.freeswitch.org/mailman/listinfo/freeswitch-users
>> UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-usershttp://www.freeswitch.org
>>
>>
>>
>> _________________________________________________________________________
>> Professional FreeSWITCH Consulting Services:
>> consulting at freeswitch.org
>> http://www.freeswitchsolutions.com
>>
>> Official FreeSWITCH Sites
>> http://www.freeswitch.org
>> http://confluence.freeswitch.org
>> http://www.cluecon.com
>>
>> FreeSWITCH-users mailing list
>> FreeSWITCH-users at lists.freeswitch.org
>> http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
>> UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
>> http://www.freeswitch.org
>>
>
>
> _________________________________________________________________________
> Professional FreeSWITCH Consulting Services:
> consulting at freeswitch.org
> http://www.freeswitchsolutions.com
>
> Official FreeSWITCH Sites
> http://www.freeswitch.org
> http://confluence.freeswitch.org
> http://www.cluecon.com
>
> FreeSWITCH-users mailing list
> FreeSWITCH-users at lists.freeswitch.org
> http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
> UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
> http://www.freeswitch.org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.freeswitch.org/pipermail/freeswitch-users/attachments/20160904/a330992c/attachment.html