[Freeswitch-users] API break vs uuid_break

[Marek Slivanský - Livispace s.r.]

Thank you very much for your response and clarifying, Michael. We have change break to uuid_break. Anyway as you say, it has no influence on function, as it’s alias for the same.

 

 

From: freeswitch-users-bounces at lists.freeswitch.org [mailto:freeswitch-users-bounces at lists.freeswitch.org] On Behalf Of Michael Collins
Sent: Sunday, March 13, 2016 8:53 PM
To: FreeSWITCH Users Help <freeswitch-users at lists.freeswitch.org>
Subject: Re: [Freeswitch-users] API break vs uuid_break

 

It appears that nearly six years ago the API 'break' was simply changed to 'uuid_break' in this commit:

https://freeswitch.org/stash/projects/FS/repos/freeswitch/commits/63120a7452ad16fe62dd2b5d22135eb6222e6611

 

>From what I see in the code, both 'break' and 'uuid_break' call 'break_function' in mod_commands.c, so 'break' is really just an alias for 'uuid_break':

 

SWITCH_ADD_API(commands_api_interface, "break", "uuid_break", break_function, BREAK_SYNTAX);

SWITCH_ADD_API(commands_api_interface, "uuid_break", "Break out of media sent to channel", break_function, BREAK_SYNTAX);

 

For the sake of consistency you might want to consider changing your 'bgapi break <uuid>' calls to 'bgapi uuid_break <uuid>'. There is a whole family of uuid_* APIs and 'uuid_break' fits in nicely among them. You may find the word 'break' all over source code, but if you see 'uuid_break' then you know exactly what that means.

 

-MSC

 

On Sat, Mar 12, 2016 at 1:24 AM, Marek Slivanský - Livispace s.r.o. <marek at telfa.cz <mailto:marek at telfa.cz> > wrote:

Hi there,

 

sorry if I’m not choosing the right way for asking for something, please point me out, this is my first time using the mailing list.

 

I have a question regarding API command “break” has changed to “uuid_break”. I really tried to but I’ve not found any information about that.

 

We are using ”bgapi break <uuid>” to stop playing some sound to a call (leg), e.g. moh, and to continue with next dialplan item. We are using v1.2.stable. Probably since last upgrade to the latest commit in this branch (prior we were using some 09/2012 commit), sometimes (rarely) the command “bgapi break <uuid>” gets ignored by FreeSwitch and sound remains playing forever (local_stream://moh).

 

Could anyone please shed some light on this change (and perhaps add some info why break has been deprecated and consequences of continuing to use it, into wiki)?

 

Thanks in advance for any answer,

 

Marek


_________________________________________________________________________
Professional FreeSWITCH Consulting Services:
consulting at freeswitch.org <mailto:consulting at freeswitch.org> 
http://www.freeswitchsolutions.com

Official FreeSWITCH Sites
http://www.freeswitch.org
http://confluence.freeswitch.org
http://www.cluecon.com

FreeSWITCH-users mailing list
FreeSWITCH-users at lists.freeswitch.org <mailto:FreeSWITCH-users at lists.freeswitch.org> 
http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
http://www.freeswitch.org

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.freeswitch.org/pipermail/freeswitch-users/attachments/20160314/3a9bc3fa/attachment.html