[Freeswitch-users] FEC feature in mod_opus

[Michael Jerris]

We no longer label branches as "stable" like this.  !.4 is the current maintained release, and 1.2 no longer gets even security patches.  If there are any issues in 1.4, they need to be filed in jira ASAP.


> On May 9, 2015, at 8:26 AM, Ken Rice <krice at freeswitch.org> wrote:
> 
> If there are regressions in the 1.4 release versions you should make sure there have been jira tickets opened on them.
> 
> Sent from my iPhone
> 
> On May 9, 2015, at 3:49 AM, Kamil Nigmatullin <kamil.nigmatullin at gmail.com <mailto:kamil.nigmatullin at gmail.com>> wrote:
> 
>> Yes, it is old but it is stable. A lot of things it does it does better than any development version of 1.4. Thanks I will try.
>> 
>> 2015-05-09 1:26 GMT+06:00 Michael Jerris <mike at jerris.com <mailto:mike at jerris.com>>:
>> 1.2 is quite old, why would you be using it?  Have you tried on top of 1.4?
>> 
>>> On May 8, 2015, at 2:11 PM, Kamil Nigmatullin <kamil.nigmatullin at gmail.com <mailto:kamil.nigmatullin at gmail.com>> wrote:
>>> 
>>> Hi Dragos, 
>>> I tried to use your patch but have no luck with compiling it. 
>>> 
>>> I clonne stable 1.2 and then replace mod_opus.c with your code. Maybe do you know how to fix it?
>>> 
>>> This is what I get:
>>> d_opus/mod_opus.c  -fPIC -DPIC -o .libs/mod_opus.o
>>> /usr/src/freeswitch/src/mod/codecs/mod_opus/mod_opus.c: In function 'switch_opus_fmtp_parse':
>>> /usr/src/freeswitch/src/mod/codecs/mod_opus/mod_opus.c:155:18: error: 'switch_codec_fmtp_t' has no member named 'stereo'
>>> /usr/src/freeswitch/src/mod/codecs/mod_opus/mod_opus.c: In function 'switch_opus_decode':
>>> /usr/src/freeswitch/src/mod/codecs/mod_opus/mod_opus.c:423:3: error: statement with no effect [-Werror=unused-value]
>>> cc1: all warnings being treated as errors
>>> make[4]: *** [mod_opus.lo] Error 1
>>> make[3]: *** [all] Error 1
>>> make[2]: *** [mod_opus-all] Error 1
>>> make[1]: *** [mod_opus] Error 2
>>> make: *** [mod_opus] Error 2
>>> 
>>> 
>>> 2015-04-14 14:52 GMT+06:00 Dragos Oancea <droancea at yahoo.com <mailto:droancea at yahoo.com>>:
>>> 
>>> Hi Kamil,
>>> 
>>> I've done a patch for Opus with FEC , but it has not been merged:
>>> https://freeswitch.org/stash/projects/FS/repos/freeswitch/pull-requests/184/overview <https://freeswitch.org/stash/projects/FS/repos/freeswitch/pull-requests/184/overview>
>>> I was inspired by how they've done it with SILK.
>>> 
>>> 
>>> Regards,
>>> Dragos Oancea
>>> 
>>> 
>>> 
>>> On 2015-04-13 16:49, Kamil Nigmatullin wrote:
>>> > Hello. 
>>> > 
>>> > Anybody from developers could please clarify if FreeSWITCH uses
>>> > Forward Error Correction feature in opus codec? We actually are not a
>>> > specialists in C and cannot fully understand how decode function works
>>> > in 414 line. According to opus documentation decode function  is
>>> > called with special flag if previous packet is lost in order to call
>>> > fec feature. In mod_opus it is hard to say for me as i don't see i or
>>> > i+1 packets. Thanks    
>>> > _________________________________________________________________________

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.freeswitch.org/pipermail/freeswitch-users/attachments/20150510/e155b0ae/attachment.html