[Freeswitch-users] FEC feature in mod_opus

[Michael Jerris]

1.2 is quite old, why would you be using it?  Have you tried on top of 1.4?

> On May 8, 2015, at 2:11 PM, Kamil Nigmatullin <kamil.nigmatullin at gmail.com> wrote:
> 
> Hi Dragos, 
> I tried to use your patch but have no luck with compiling it. 
> 
> I clonne stable 1.2 and then replace mod_opus.c with your code. Maybe do you know how to fix it?
> 
> This is what I get:
> d_opus/mod_opus.c  -fPIC -DPIC -o .libs/mod_opus.o
> /usr/src/freeswitch/src/mod/codecs/mod_opus/mod_opus.c: In function 'switch_opus_fmtp_parse':
> /usr/src/freeswitch/src/mod/codecs/mod_opus/mod_opus.c:155:18: error: 'switch_codec_fmtp_t' has no member named 'stereo'
> /usr/src/freeswitch/src/mod/codecs/mod_opus/mod_opus.c: In function 'switch_opus_decode':
> /usr/src/freeswitch/src/mod/codecs/mod_opus/mod_opus.c:423:3: error: statement with no effect [-Werror=unused-value]
> cc1: all warnings being treated as errors
> make[4]: *** [mod_opus.lo] Error 1
> make[3]: *** [all] Error 1
> make[2]: *** [mod_opus-all] Error 1
> make[1]: *** [mod_opus] Error 2
> make: *** [mod_opus] Error 2
> 
> 
> 2015-04-14 14:52 GMT+06:00 Dragos Oancea <droancea at yahoo.com <mailto:droancea at yahoo.com>>:
> 
> Hi Kamil,
> 
> I've done a patch for Opus with FEC , but it has not been merged:
> https://freeswitch.org/stash/projects/FS/repos/freeswitch/pull-requests/184/overview <https://freeswitch.org/stash/projects/FS/repos/freeswitch/pull-requests/184/overview>
> I was inspired by how they've done it with SILK.
> 
> 
> Regards,
> Dragos Oancea
> 
> 
> 
> On 2015-04-13 16:49, Kamil Nigmatullin wrote:
> > Hello. 
> > 
> > Anybody from developers could please clarify if FreeSWITCH uses
> > Forward Error Correction feature in opus codec? We actually are not a
> > specialists in C and cannot fully understand how decode function works
> > in 414 line. According to opus documentation decode function  is
> > called with special flag if previous packet is lost in order to call
> > fec feature. In mod_opus it is hard to say for me as i don't see i or
> > i+1 packets. Thanks    
> > _________________________________________________________________________
> > Professional FreeSWITCH Consulting Services: 
> > consulting at freeswitch.org <mailto:consulting at freeswitch.org>
> > http://www.freeswitchsolutions.com <http://www.freeswitchsolutions.com/>
> > 
> > Official FreeSWITCH Sites
> > http://www.freeswitch.org <http://www.freeswitch.org/>
> > http://confluence.freeswitch.org <http://confluence.freeswitch.org/>
> > http://www.cluecon.com <http://www.cluecon.com/>
> > 
> > FreeSWITCH-users mailing list
> > FreeSWITCH-users at lists.freeswitch.org <mailto:FreeSWITCH-users at lists.freeswitch.org>
> > http://lists.freeswitch.org/mailman/listinfo/freeswitch-users <http://lists.freeswitch.org/mailman/listinfo/freeswitch-users>
> > UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users <http://lists.freeswitch.org/mailman/options/freeswitch-users>
> > http://www.freeswitch.org <http://www.freeswitch.org/>
> 
> 
> 
> 
> -- 
> Kamil Nigmatullin
> Tel: 77272323748
> mob: 7 (707) 2517003
> Skype: kamil.nigmatullin
> _________________________________________________________________________
> Professional FreeSWITCH Consulting Services: 
> consulting at freeswitch.org
> http://www.freeswitchsolutions.com
> 
> Official FreeSWITCH Sites
> http://www.freeswitch.org
> http://confluence.freeswitch.org
> http://www.cluecon.com
> 
> FreeSWITCH-users mailing list
> FreeSWITCH-users at lists.freeswitch.org
> http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
> UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
> http://www.freeswitch.org

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.freeswitch.org/pipermail/freeswitch-users/attachments/20150508/47ca6065/attachment.html