[Freeswitch-users] mod_opus bug?
Thomas Auge
auge at virtues.net
Fri Jan 16 21:59:45 MSK 2015
Stupid question: Where do you "see" that? I couldn't find anything in the logs. I don't *know* if it was enabled. We
just had some embarrassing sound glitches on air today which sounded exactly like what happened when DTX was enabled,
and then I noticed that usedtx=0 wasn't there in the a-leg local SDP, it's enabled by default in mod_opus, and figured
(hoped) that might be it.
I didn't know comfort noise could be disabled on the freeswitch side. I wonder how Chrome reacts to that. The Chrome
people did discuss the merit of CN, but opted to keep it. :/ Will try that, thanks! :-)
On 16.01.2015 15:39, Anthony Minessale wrote:
> Looking at your issue however I don't see dtx being enabled when I lab up what you described.
>
> Try this in vars.xml to disable CNG completely.
>
> <X-PRE-PROCESScmd="set"data="suppress_cng=true"/>
>
>
>
>
> On Fri, Jan 16, 2015 at 12:28 PM, Anthony Minessale <anthony.minessale at gmail.com <mailto:anthony.minessale at gmail.com>>
> wrote:
>
> Its better to ask by filing the jira its one click to close it and if there is a real issue we need logs etc
> attached and something to reference if we push a fix.
>
>
>
> On Fri, Jan 16, 2015 at 12:26 PM, Thomas Auge <auge at virtues.net <mailto:auge at virtues.net>> wrote:
>
> I figured I'd ask for an opinion before filing a bogus bug. :P
>
>
> On 16.01.2015 15:16, Anthony Minessale wrote:
> > Its also a bug to send bugs to the mailing list instead ofhttp://jira.freeswitch.org
> >
> >
> > On Fri, Jan 16, 2015 at 12:12 PM, Thomas Auge <auge at virtues.net <mailto:auge at virtues.net> <mailto:auge at virtues.net <mailto:auge at virtues.net>>> wrote:
> >
> > Hello list,
> >
> > I noticed that in an opus call where the a-leg sends usedtx=0, it is properly forwarded to the b-leg, which in this case
> > also correctly responds with usedtx=0. However, the local SDP for the a-leg then does not have usedtx in the fmtp at
> > all, and it seems to be enabled.
> >
> > My C skills are limited, but could this be a bug:
> >
> > static opus_codec_settings_t default_codec_settings = {
> > ....
> > /*.usedtx */ 1,
> > ....
> > };
> >
> > By default, usedtx is enabled, correct?
> >
> > However, in
> >
> > static char *gen_fmtp(opus_codec_settings_t *settings, switch_memory_pool_t *pool)
> >
> > there's this:
> >
> > if (settings->usedtx) {
> > snprintf(buf + strlen(buf), sizeof(buf) - strlen(buf), "usedtx=1; ");
> > }
> >
> >
> > Am I interpreting this correctly that if usedtx is zero, it is omitted in the fmtp line, but then enabled, because
> > that's the default setting?
> >
> > Problem is that Chrome can't handle DTX and generates comfort noise every time it kicks in.
> >
> > Cheers!
> >
> > Thomas
> >
> > P.S.: If my interpretation is correct, it'll also affect useinbandfec.
> >
> > _________________________________________________________________________
> > Professional FreeSWITCH Consulting Services:
> > consulting at freeswitch.org <mailto:consulting at freeswitch.org> <mailto:consulting at freeswitch.org
> <mailto:consulting at freeswitch.org>>
> >http://www.freeswitchsolutions.com
> >
> > Official FreeSWITCH Sites
> >http://www.freeswitch.org
> >http://confluence.freeswitch.org
> >http://www.cluecon.com
> >
> > FreeSWITCH-users mailing list
> > FreeSWITCH-users at lists.freeswitch.org <mailto:FreeSWITCH-users at lists.freeswitch.org>
> <mailto:FreeSWITCH-users at lists.freeswitch.org <mailto:FreeSWITCH-users at lists.freeswitch.org>>
> >http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
> > UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
> >http://www.freeswitch.org
> >
> >
> >
> >
> > --
> > Anthony Minessale II ♬ @anthmfs ♬ @FreeSWITCH ♬
> >
> > ☞http://freeswitch.org/ ☞ http://cluecon.com/ ☞ http://twitter.com/FreeSWITCH
> > ☞ irc.freenode.net <http://irc.freenode.net> <http://irc.freenode.net> #freeswitch ☞ _http://freeswitch.org/g+_
> >
> > ClueCon Weekly Development Call
> > ☎ sip:888 at conference.freeswitch.org <mailto:sip%3A888 at conference.freeswitch.org>
> <mailto:sip%3A888 at conference.freeswitch.org <mailto:sip%253A888 at conference.freeswitch.org>> ☎ +19193869900
> <tel:%2B19193869900>
> >
> >
> >
> > _________________________________________________________________________
> > Professional FreeSWITCH Consulting Services:
> > consulting at freeswitch.org <mailto:consulting at freeswitch.org>
> > http://www.freeswitchsolutions.com
> >
> > Official FreeSWITCH Sites
> > http://www.freeswitch.org
> > http://confluence.freeswitch.org
> > http://www.cluecon.com
> >
> > FreeSWITCH-users mailing list
> > FreeSWITCH-users at lists.freeswitch.org <mailto:FreeSWITCH-users at lists.freeswitch.org>
> > http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
> > UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
> > http://www.freeswitch.org
> >
>
>
> _________________________________________________________________________
> Professional FreeSWITCH Consulting Services:
> consulting at freeswitch.org <mailto:consulting at freeswitch.org>
> http://www.freeswitchsolutions.com
>
> Official FreeSWITCH Sites
> http://www.freeswitch.org
> http://confluence.freeswitch.org
> http://www.cluecon.com
>
> FreeSWITCH-users mailing list
> FreeSWITCH-users at lists.freeswitch.org <mailto:FreeSWITCH-users at lists.freeswitch.org>
> http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
> UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
> http://www.freeswitch.org
>
>
>
>
> --
> Anthony Minessale II ♬ @anthmfs ♬ @FreeSWITCH ♬
>
> ☞ http://freeswitch.org/ ☞ http://cluecon.com/ ☞ http://twitter.com/FreeSWITCH
> ☞ irc.freenode.net <http://irc.freenode.net> #freeswitch ☞ _http://freeswitch.org/g+_
>
> ClueCon Weekly Development Call
> ☎ sip:888 at conference.freeswitch.org <mailto:sip%3A888 at conference.freeswitch.org> ☎ +19193869900 <tel:%2B19193869900>
>
>
>
>
> --
> Anthony Minessale II ♬ @anthmfs ♬ @FreeSWITCH ♬
>
> ☞ http://freeswitch.org/ ☞ http://cluecon.com/ ☞ http://twitter.com/FreeSWITCH
> ☞ irc.freenode.net <http://irc.freenode.net> #freeswitch ☞ _http://freeswitch.org/g+_
>
> ClueCon Weekly Development Call
> ☎ sip:888 at conference.freeswitch.org <mailto:sip%3A888 at conference.freeswitch.org> ☎ +19193869900
>
>
>
> _________________________________________________________________________
> Professional FreeSWITCH Consulting Services:
> consulting at freeswitch.org
> http://www.freeswitchsolutions.com
>
> Official FreeSWITCH Sites
> http://www.freeswitch.org
> http://confluence.freeswitch.org
> http://www.cluecon.com
>
> FreeSWITCH-users mailing list
> FreeSWITCH-users at lists.freeswitch.org
> http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
> UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
> http://www.freeswitch.org
>
Join us at ClueCon 2016 Aug 8-12, 2016
More information about the FreeSWITCH-users
mailing list