[Freeswitch-users] mod_opus bug?

[Anthony Minessale]

Its better to ask by filing the jira its one click to close it and if there
is a real issue we need logs etc attached and something to reference if we
push a fix.



On Fri, Jan 16, 2015 at 12:26 PM, Thomas Auge <auge at virtues.net> wrote:

> I figured I'd ask for an opinion before filing a bogus bug. :P
>
>
> On 16.01.2015 15:16, Anthony Minessale wrote:
> > Its also a bug to send bugs to the mailing list instead of
> http://jira.freeswitch.org
> >
> >
> > On Fri, Jan 16, 2015 at 12:12 PM, Thomas Auge <auge at virtues.net <mailto:
> auge at virtues.net>> wrote:
> >
> >     Hello list,
> >
> >     I noticed that in an opus call where the a-leg sends usedtx=0, it is
> properly forwarded to the b-leg, which in this case
> >     also correctly responds with usedtx=0. However, the local SDP for
> the a-leg then does not have usedtx in the fmtp at
> >     all, and it seems to be enabled.
> >
> >     My C skills are limited, but could this be a bug:
> >
> >     static opus_codec_settings_t default_codec_settings = {
> >     ....
> >           /*.usedtx */ 1,
> >     ....
> >     };
> >
> >     By default, usedtx is enabled, correct?
> >
> >     However, in
> >
> >     static char *gen_fmtp(opus_codec_settings_t *settings,
> switch_memory_pool_t *pool)
> >
> >     there's this:
> >
> >     if (settings->usedtx) {
> >           snprintf(buf + strlen(buf), sizeof(buf) - strlen(buf),
> "usedtx=1; ");
> >     }
> >
> >
> >     Am I interpreting this correctly that if usedtx is zero, it is
> omitted in the fmtp line, but then enabled, because
> >     that's the default setting?
> >
> >     Problem is that Chrome can't handle DTX and generates comfort noise
> every time it kicks in.
> >
> >     Cheers!
> >
> >     Thomas
> >
> >     P.S.: If my interpretation is correct, it'll also affect
> useinbandfec.
> >
> >
>  _________________________________________________________________________
> >     Professional FreeSWITCH Consulting Services:
> >     consulting at freeswitch.org <mailto:consulting at freeswitch.org>
> >     http://www.freeswitchsolutions.com
> >
> >     Official FreeSWITCH Sites
> >     http://www.freeswitch.org
> >     http://confluence.freeswitch.org
> >     http://www.cluecon.com
> >
> >     FreeSWITCH-users mailing list
> >     FreeSWITCH-users at lists.freeswitch.org <mailto:
> FreeSWITCH-users at lists.freeswitch.org>
> >     http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
> >     UNSUBSCRIBE:
> http://lists.freeswitch.org/mailman/options/freeswitch-users
> >     http://www.freeswitch.org
> >
> >
> >
> >
> > --
> > Anthony Minessale II       ♬ @anthmfs  ♬ @FreeSWITCH  ♬
> >
> > ☞ http://freeswitch.org/  ☞ http://cluecon.com/  ☞
> http://twitter.com/FreeSWITCH
> > ☞ irc.freenode.net <http://irc.freenode.net> #freeswitch ☞ _
> http://freeswitch.org/g+_
> >
> > ClueCon Weekly Development Call
> > ☎ sip:888 at conference.freeswitch.org <mailto:
> sip%3A888 at conference.freeswitch.org>  ☎ +19193869900
> >
> >
> >
> > _________________________________________________________________________
> > Professional FreeSWITCH Consulting Services:
> > consulting at freeswitch.org
> > http://www.freeswitchsolutions.com
> >
> > Official FreeSWITCH Sites
> > http://www.freeswitch.org
> > http://confluence.freeswitch.org
> > http://www.cluecon.com
> >
> > FreeSWITCH-users mailing list
> > FreeSWITCH-users at lists.freeswitch.org
> > http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
> > UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
> > http://www.freeswitch.org
> >
>
>
> _________________________________________________________________________
> Professional FreeSWITCH Consulting Services:
> consulting at freeswitch.org
> http://www.freeswitchsolutions.com
>
> Official FreeSWITCH Sites
> http://www.freeswitch.org
> http://confluence.freeswitch.org
> http://www.cluecon.com
>
> FreeSWITCH-users mailing list
> FreeSWITCH-users at lists.freeswitch.org
> http://lists.freeswitch.org/mailman/listinfo/freeswitch-users
> UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-users
> http://www.freeswitch.org
>



-- 
Anthony Minessale II       ♬ @anthmfs  ♬ @FreeSWITCH  ♬

☞ http://freeswitch.org/  ☞ http://cluecon.com/  ☞
http://twitter.com/FreeSWITCH
☞ irc.freenode.net #freeswitch ☞ *http://freeswitch.org/g+
<http://freeswitch.org/g+>*

ClueCon Weekly Development Call
☎ sip:888 at conference.freeswitch.org  ☎ +19193869900
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.freeswitch.org/pipermail/freeswitch-users/attachments/20150116/7b3a3faa/attachment-0001.html