[Freeswitch-users] FreeSWITCH Week in Review(Master Branch) May 11th-17th

Wed May 21 02:32:34 MSD 2014

Hello, again. This passed week in the FreeSWITCH master branch we had 60 
commits. The majority of the commits continued work toward fixing bugs 
reported by Coverity. Coverity is a static code analysis tool used to 
find bugs in source code. It is currently being used to identify and fix 
various issues in the FS source code and the CID numbers at the 
beginning of some of the commit oneline messages reference a Coverity 
ticket. https://scan.coverity.com/

The following bugs were squashed:

cbe6f74 FS-6285 fixed issue with ANY, RR not working properly in 
mod_skypopen
Jira: http://jira.freeswitch.org/browse/FS-6285
9a1c4f6 fixed passing a large structure by its value in mod_voicemail
3480720 Chinese say now say "one" before "ten" for numbers >99 in mod_say_zh
2b93912 Fix raw GSM AT command execution not returning the proper token 
count in freetdm
7dbab7b FS-6517 fixed mod_skypopen not using configured context with 
mod_sms chatplan with PATCH. Thanks Russell Treleaven.
Jira: http://jira.freeswitch.org/browse/FS-6517

New features that were added:
3666029 add auth-subscriptions flag. sofia ua can now optionally 
challenge subscription requests

Improvements in cross platform build supports:
c006db6 fix test for pkg-config

dee864e added modules.inc to .gitignore
b263201 Avoid polluting CFLAGS for mod_snmp
e488834 Prevent opus lib from re-configuring on every make
94ec447 Cleanup makefile library dependencies of mod_snmp

Coverity fixes:
ecde431 CID:1025850 Dereference before null check in mod_cidlookup

e1f8e19 CID:1087632 fixed a resource leak
7d5434f CID: 1214223-1214230 If sent an invalid registration 
authentication header with multiple params of the same name, then only 
use the first of the params instead of leaking memory in mod_sofia
d055f5b CID 1214263: mod_ssml - remove unused pointer value
68825ff CID:1214220 fixed resource leak in mod_dptools
619b31e CID:1214140 Buffer not null terminated, make sure hostname is 
always null terminated
8fa7398 CID:1025868 Simplified a function arguments never called
07b6bba CID:1214209 Resource leak, don't leak event populated by 
switch_channel_get_variables in mod_fsk
1286013 CID:1214255 Unused pointer value removed from mod_conference
dc83348 Fix build for 31b8b55d0b31dfd58b5e6f8166a228ab2f456d3d
0469db0 CID:1214200 Dereference null return value in mod_httapi
bdbefdc CID:1087631 In the unlikely case the sprintf fails, free the 
memory instead of leak it
6b90242 CID:1214189 Division or modulo by float zero in libteletone
452d7a3 CID:1214163 Unchecked return value, check return value of 
switch_ivr_play_file and bail out if it fails in mod_fifo
c1f7887 CID:1024580 removed logically dead code from mod_commands
a997331 CID:1214125 fixed the size of the the destination buffer in 
mod_voicemail_ivr
455ed10 CID:1214130 Buffer not null terminated in mod_xml_curl and 
mod_xml_scgi
c19aa58 CID: 1214222 fixed a resource leak in mod_sofia
386000d CID:1024418 fixed unintentional integer overflow in mod_dptools
92c6f3a CID:1214192 Dereference after null check, don't crash when no 
file name passed on file open in mod_httapi
a67389a CID:1025879 removed logically dead code in mod_cidlookup
3e18f08 clean up Coverity warnings and improve error checking in 
mod_voicemail
21a5d16 CID:1024581 removed logically dead code from mod_commands
b10c865 CID:1025849 Dereference before null check in mod_cidlookup
b7b1420 CID 1214210: mod_ssml - resource leak when parsing SSML
ebc0a99 CID:1024250 Dereference before null check. CID:1024251 
Dereference before null check, we don't need to check these, as they are 
already used above in all cases
bf8b88c CID: 1210583 removed dead code reported by Coverity
269db09 CID:1214232 fixed a resource leak reported by Coverity in switch_ivr
d8d58fd CID:1214141 Buffer not null terminated in mod_unimrcp
6a8002d CID:1024582 removed logically dead code from mod_commands
622cd21 CID:1214231 don't leak when using invalid syntax
73c1e09 CID:1024579 removed logically dead code from mod_commands
44401e8 CID:1023936 Unused pointer value
31b8b55 CID:1214216 fixed a resource leak in mod_dingaling
179e07c CID:1214219 fixed resource leak in mod_hash
65d9cf6 CID:1214237 String not null terminated
1680518 CID:1214256 Unused pointer value removed from mod_conference
4238339 CID:1023970 removed unused pointer value from mod_dptools
7c72e94 CID:1214158 Buffer not null terminated in mod_fifo
d2884ac CD:1214211 fixed resource leak in mod_sms
54fc2f5 CID:1023975 Unused pointer value in mod_commands
b58bbd1 CID:1214233 Pointer to local outside scope
9b1ebff CID:1024270 Dereference before null check in mod_commands
4653d78 CID:1087387 Unused pointer value
29e2263 CID:1210789 Make return value of a function available from the 
another calling function and add small status check in mod_callcenter
4e888a2 CID:1214196 Dereference null return value, if we hit this 
condition, something very bad has happened, we should never have the 
private not set if we get to the hangup hook, log error instead of 
crashing in mod_spy
388e119 CID: 1214221,1214222 fixed a resource leak in mod_sofia
1b0bdaf CID:1214212 Resource leak in voicemail_list in mod_voicemail
19f3ab5 CID:1214218 fix memory leak in conference_event_channel_handler

Feedback is welcome at kathleen.king at quentustech.com and the commits for 
this week are in the attached file along with the corresponding Jira links.

-- 
Kathleen King
Quentus Technologies, INC
1037 NE 65th St Suite 273
Seattle, WA 98115
Main:   (877) 211-9337
Cell:   (703) 859-3757
kathleen.king at quentustech.com

-------------- next part --------------
Build:
c006db6 fix test for pkg-config
dee864e added modules.inc to .gitignore
b263201 Avoid polluting CFLAGS for mod_snmp
e488834 Prevent opus lib from re-configuring on every make
94ec447 Cleanup makefile library dependencies of mod_snmp

Bug:
cbe6f74 FS-6285 fixed issue with ANY, RR not working properly in mod_skypopen
Jira: http://jira.freeswitch.org/browse/FS-6285
9a1c4f6 fixed passing a large structure by its value in mod_voicemail 
3480720 Chinese say now say "one" before "ten" for numbers >99 in mod_say_zh
2b93912 Fix raw GSM AT command execution not returning the proper token count in freetdm
7dbab7b FS-6517 fixed mod_skypopen not using configured context with mod_sms chatplan with PATCH. Thanks Russell Treleaven.
Jira: http://jira.freeswitch.org/browse/FS-6517

Features:
3666029 add auth-subscriptions flag. sofia ua can now optionally challenge subscription requests

Packaging:

Misc:
ecde431 CID:1025850 Dereference before null check in mod_cidlookup
e1f8e19 CID:1087632 fixed a resource leak 
7d5434f CID: 1214223-1214230 If sent an invalid registration authentication header with multiple params of the same name, then only use the first of the params instead of leaking memory in mod_sofia
d055f5b CID 1214263: mod_ssml - remove unused pointer value
68825ff CID:1214220 fixed resource leak in mod_dptools
619b31e CID:1214140 Buffer not null terminated, make sure hostname is always null terminated
8fa7398 CID:1025868 Simplified a function arguments never called
07b6bba CID:1214209 Resource leak, don't leak event populated by switch_channel_get_variables in mod_fsk
1286013 CID:1214255 Unused pointer value removed from mod_conference
dc83348 Fix build for 31b8b55d0b31dfd58b5e6f8166a228ab2f456d3d
0469db0 CID:1214200 Dereference null return value in mod_httapi
bdbefdc CID:1087631 In the unlikely case the sprintf fails, free the memory instead of leak it
6b90242 CID:1214189 Division or modulo by float zero in libteletone
452d7a3 CID:1214163 Unchecked return value, check return value of switch_ivr_play_file and bail out if it fails in mod_fifo
c1f7887 CID:1024580 removed logically dead code from mod_commands
a997331 CID:1214125 fixed the size of the the destination buffer in mod_voicemail_ivr
455ed10 CID:1214130 Buffer not null terminated in mod_xml_curl and mod_xml_scgi
c19aa58 CID: 1214222 fixed a resource leak in mod_sofia
386000d CID:1024418 fixed unintentional integer overflow in mod_dptools
92c6f3a CID:1214192 Dereference after null check, don't crash when no file name passed on file open in mod_httapi
a67389a CID:1025879 removed logically dead code in mod_cidlookup
3e18f08 clean up Coverity warnings and improve error checking in mod_voicemail
21a5d16 CID:1024581 removed logically dead code from mod_commands
b10c865 CID:1025849 Dereference before null check in mod_cidlookup
b7b1420 CID 1214210: mod_ssml - resource leak when parsing SSML
ebc0a99 CID:1024250 Dereference before null check. CID:1024251 Dereference before null check, we don't need to check these, as they are already used above in all cases
bf8b88c CID: 1210583 removed dead code reported by Coverity
269db09 CID:1214232 fixed a resource leak reported by Coverity in switch_ivr
d8d58fd CID:1214141 Buffer not null terminated in mod_unimrcp
6a8002d CID:1024582 removed logically dead code from mod_commands
622cd21 CID:1214231 don't leak when using invalid syntax
73c1e09 CID:1024579 removed logically dead code from mod_commands
44401e8 CID:1023936 Unused pointer value
31b8b55 CID:1214216 fixed a resource leak in mod_dingaling
179e07c CID:1214219 fixed resource leak in mod_hash
65d9cf6 CID:1214237 String not null terminated
1680518 CID:1214256 Unused pointer value removed from mod_conference
4238339 CID:1023970 removed unused pointer value from mod_dptools
7c72e94 CID:1214158 Buffer not null terminated in mod_fifo
d2884ac CD:1214211 fixed resource leak in mod_sms
54fc2f5 CID:1023975 Unused pointer value in mod_commands
b58bbd1 CID:1214233 Pointer to local outside scope
9b1ebff CID:1024270 Dereference before null check in mod_commands
4653d78 CID:1087387 Unused pointer value
29e2263 CID:1210789 Make return value of a function available from the another calling function and add small status check in mod_callcenter
4e888a2 CID:1214196 Dereference null return value, if we hit this condition, something very bad has happened, we should never have the private not set if we get to the hangup hook, log error instead of crashing in mod_spy
388e119 CID: 1214221,1214222 fixed a resource leak in mod_sofia
1b0bdaf CID:1214212 Resource leak in voicemail_list in mod_voicemail

Stability:
19f3ab5 CID:1214218 fix memory leak in conference_event_channel_handler

Performance: